From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jerry Ray <jerry.ray@microchip.com>,
Rob Herring <robh+dt@kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] dts: arm: Adding documentation for SAMA5D3-EDS board
Date: Tue, 30 Aug 2022 19:57:12 +0300 [thread overview]
Message-ID: <7f58edca-3685-d9a8-d4f6-40a45c3f385d@linaro.org> (raw)
In-Reply-To: <20220830152428.12625-1-jerry.ray@microchip.com>
On 30/08/2022 18:24, Jerry Ray wrote:
> Adding the SAMA5D3-EDS board from Microchip into the atmel AT91 board
> description yaml file.
>
> Signed-off-by: Jerry Ray <jerry.ray@microchip.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
Use subject prefixes matching the subsystem (git log --oneline -- ...).
> v4->v5:
> - No change
> v3->v4:
> - No change
> v2->v3:
> - No change
> v1->v2:
> - Added Device Tree documentation for Microchip SAMA5D3-EDS board
> ---
> Documentation/devicetree/bindings/arm/atmel-at91.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> index 08efb259a947..635491aaeb0c 100644
> --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> @@ -138,6 +138,13 @@ properties:
> - const: atmel,at91sam9g20
> - const: atmel,at91sam9
>
> + - description: Microchip SAMA5D3 Ethernet Development System Board
> + items:
> + - const: microchip,sama5d3-eds
> + - const: atmel,sama5d36
This does not match your DTS.
Test your bindings...
Please drop Rob's ack as this is not correct.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-08-30 16:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 15:24 [PATCH v5 1/2] dts: arm: Adding documentation for SAMA5D3-EDS board Jerry Ray
2022-08-30 15:24 ` [PATCH v5 2/2] dts: arm: at91: Add " Jerry Ray
2022-08-30 17:02 ` Krzysztof Kozlowski
2022-08-30 20:16 ` Jerry.Ray
2022-08-31 6:06 ` Krzysztof Kozlowski
2022-08-30 16:57 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f58edca-3685-d9a8-d4f6-40a45c3f385d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=jerry.ray@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).