From: Mudit Sharma <muditsharma.info@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: lars@metafoo.de, krzk+dt@kernel.org, conor+dt@kernel.org,
robh@kernel.org, ivan.orlov0322@gmail.com,
javier.carrasco.cruz@gmail.com, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/2] iio: light: ROHM BH1745 colour sensor
Date: Mon, 17 Jun 2024 19:47:39 +0100 [thread overview]
Message-ID: <7f60db41-8935-4997-b65d-c69785f872e7@gmail.com> (raw)
In-Reply-To: <20240608172227.17996c75@jic23-huawei>
On 08/06/2024 17:22, Jonathan Cameron wrote:
> On Thu, 6 Jun 2024 17:29:42 +0100
>
> Hi Mudit,
>
> Welcome to IIO.
>
> Some comments inline. Some apply more widely than where I've
> called them out, so please look for similar cases and tidy them all
> up for v5.
>
> Thanks,
>
> Jonathan
>
Hi Jonathan,
Thank you for the review and suggestions on this.
I'll address the comments and include related fixes in v5.
Best regards,
Mudit Sharma
next prev parent reply other threads:[~2024-06-17 18:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 16:29 [PATCH v4 1/2] dt-bindings: iio: light: ROHM BH1745 Mudit Sharma
2024-06-06 16:29 ` [PATCH v4 2/2] iio: light: ROHM BH1745 colour sensor Mudit Sharma
2024-06-08 16:22 ` Jonathan Cameron
2024-06-10 5:58 ` Matti Vaittinen
2024-06-11 17:14 ` Jonathan Cameron
2024-06-12 6:07 ` Matti Vaittinen
2024-06-15 18:23 ` Jonathan Cameron
2024-06-17 7:08 ` Matti Vaittinen
2024-06-23 16:52 ` Jonathan Cameron
2024-06-17 18:52 ` Mudit Sharma
2024-06-17 18:47 ` Mudit Sharma [this message]
2024-06-08 15:27 ` [PATCH v4 1/2] dt-bindings: iio: light: ROHM BH1745 Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f60db41-8935-4997-b65d-c69785f872e7@gmail.com \
--to=muditsharma.info@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ivan.orlov0322@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).