* [PATCH v3 03/16] dt-bindings: qcom_nandc: make nand-ecc-strength optional [not found] <1527250904-21988-1-git-send-email-absahu@codeaurora.org> @ 2018-05-25 12:21 ` Abhishek Sahu 2018-05-26 8:42 ` Miquel Raynal 2018-05-25 12:21 ` [PATCH v3 04/16] dt-bindings: qcom_nandc: remove nand-ecc-step-size Abhishek Sahu 1 sibling, 1 reply; 4+ messages in thread From: Abhishek Sahu @ 2018-05-25 12:21 UTC (permalink / raw) To: Boris Brezillon Cc: David Woodhouse, Brian Norris, Marek Vasut, Richard Weinberger, Cyrille Pitchen, Miquel Raynal, linux-arm-msm, linux-kernel, linux-mtd, Andy Gross, Archit Taneja, Abhishek Sahu, Rob Herring, Mark Rutland, devicetree If nand-ecc-strength specified in DT, then controller will use this ECC strength otherwise ECC strength will be calculated according to chip requirement and available OOB size. Signed-off-by: Abhishek Sahu <absahu@codeaurora.org> --- * Changes from v2: NONE * Changes from v1: NEW PATCH Documentation/devicetree/bindings/mtd/qcom_nandc.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt index 73d336be..f246aa0 100644 --- a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt +++ b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt @@ -45,11 +45,13 @@ Required properties: number (e.g., 0, 1, 2, etc.) - #address-cells: see partition.txt - #size-cells: see partition.txt -- nand-ecc-strength: see nand.txt - nand-ecc-step-size: must be 512. see nand.txt for more details. Optional properties: - nand-bus-width: see nand.txt +- nand-ecc-strength: see nand.txt. If not specified, then ECC strength will + be used according to chip requirement and available + OOB size. Each nandcs device node may optionally contain a 'partitions' sub-node, which further contains sub-nodes describing the flash partition mapping. See -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3 03/16] dt-bindings: qcom_nandc: make nand-ecc-strength optional 2018-05-25 12:21 ` [PATCH v3 03/16] dt-bindings: qcom_nandc: make nand-ecc-strength optional Abhishek Sahu @ 2018-05-26 8:42 ` Miquel Raynal 2018-05-28 5:53 ` Abhishek Sahu 0 siblings, 1 reply; 4+ messages in thread From: Miquel Raynal @ 2018-05-26 8:42 UTC (permalink / raw) To: Abhishek Sahu Cc: Boris Brezillon, David Woodhouse, Brian Norris, Marek Vasut, Richard Weinberger, Cyrille Pitchen, linux-arm-msm, linux-kernel, linux-mtd, Andy Gross, Archit Taneja, Rob Herring, Mark Rutland, devicetree Hi Abhishek, On Fri, 25 May 2018 17:51:31 +0530, Abhishek Sahu <absahu@codeaurora.org> wrote: > If nand-ecc-strength specified in DT, then controller will use > this ECC strength otherwise ECC strength will be calculated > according to chip requirement and available OOB size. > > Signed-off-by: Abhishek Sahu <absahu@codeaurora.org> > --- > * Changes from v2: > NONE > > * Changes from v1: > NEW PATCH > > Documentation/devicetree/bindings/mtd/qcom_nandc.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt > index 73d336be..f246aa0 100644 > --- a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt > +++ b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt > @@ -45,11 +45,13 @@ Required properties: > number (e.g., 0, 1, 2, etc.) > - #address-cells: see partition.txt > - #size-cells: see partition.txt > -- nand-ecc-strength: see nand.txt > - nand-ecc-step-size: must be 512. see nand.txt for more details. I think you can squash the two dt-bindings commits as they are tightly related to each other. > > Optional properties: > - nand-bus-width: see nand.txt > +- nand-ecc-strength: see nand.txt. If not specified, then ECC strength will > + be used according to chip requirement and available > + OOB size. > > Each nandcs device node may optionally contain a 'partitions' sub-node, which > further contains sub-nodes describing the flash partition mapping. See -- Miquel Raynal, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 03/16] dt-bindings: qcom_nandc: make nand-ecc-strength optional 2018-05-26 8:42 ` Miquel Raynal @ 2018-05-28 5:53 ` Abhishek Sahu 0 siblings, 0 replies; 4+ messages in thread From: Abhishek Sahu @ 2018-05-28 5:53 UTC (permalink / raw) To: Miquel Raynal Cc: Boris Brezillon, David Woodhouse, Brian Norris, Marek Vasut, Richard Weinberger, Cyrille Pitchen, linux-arm-msm, linux-kernel, linux-mtd, Andy Gross, Archit Taneja, Rob Herring, Mark Rutland, devicetree On 2018-05-26 14:12, Miquel Raynal wrote: > Hi Abhishek, > > On Fri, 25 May 2018 17:51:31 +0530, Abhishek Sahu > <absahu@codeaurora.org> wrote: > >> If nand-ecc-strength specified in DT, then controller will use >> this ECC strength otherwise ECC strength will be calculated >> according to chip requirement and available OOB size. >> >> Signed-off-by: Abhishek Sahu <absahu@codeaurora.org> >> --- >> * Changes from v2: >> NONE >> >> * Changes from v1: >> NEW PATCH >> >> Documentation/devicetree/bindings/mtd/qcom_nandc.txt | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt >> b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt >> index 73d336be..f246aa0 100644 >> --- a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt >> +++ b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt >> @@ -45,11 +45,13 @@ Required properties: >> number (e.g., 0, 1, 2, etc.) >> - #address-cells: see partition.txt >> - #size-cells: see partition.txt >> -- nand-ecc-strength: see nand.txt >> - nand-ecc-step-size: must be 512. see nand.txt for more details. > > I think you can squash the two dt-bindings commits as they are tightly > related to each other. > Sure Miquel. Earlier made one patch and then split into two. Will squash that and make single patch again :-) Thanks, Abhishek >> >> Optional properties: >> - nand-bus-width: see nand.txt >> +- nand-ecc-strength: see nand.txt. If not specified, then ECC >> strength will >> + be used according to chip requirement and available >> + OOB size. >> >> Each nandcs device node may optionally contain a 'partitions' >> sub-node, which >> further contains sub-nodes describing the flash partition mapping. >> See ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v3 04/16] dt-bindings: qcom_nandc: remove nand-ecc-step-size [not found] <1527250904-21988-1-git-send-email-absahu@codeaurora.org> 2018-05-25 12:21 ` [PATCH v3 03/16] dt-bindings: qcom_nandc: make nand-ecc-strength optional Abhishek Sahu @ 2018-05-25 12:21 ` Abhishek Sahu 1 sibling, 0 replies; 4+ messages in thread From: Abhishek Sahu @ 2018-05-25 12:21 UTC (permalink / raw) To: Boris Brezillon Cc: David Woodhouse, Brian Norris, Marek Vasut, Richard Weinberger, Cyrille Pitchen, Miquel Raynal, linux-arm-msm, linux-kernel, linux-mtd, Andy Gross, Archit Taneja, Abhishek Sahu, Rob Herring, Mark Rutland, devicetree QCOM NAND controller supports only one step size (512) but nand-ecc-step-size is required property in DT. This DT property can be removed and ecc step size can be assigned in driver with 512 value. Signed-off-by: Abhishek Sahu <absahu@codeaurora.org> --- Currently there is no user in mainline linux kernel for QPIC. Following patches for this node is in review https://patchwork.kernel.org/patch/10426405/ https://patchwork.kernel.org/patch/10426385/ If these changes got merged then I will submit another change to remove the nand-ecc-step-size from actual DTS. * Changes from v2: NEW CHANGE Documentation/devicetree/bindings/mtd/qcom_nandc.txt | 3 --- 1 file changed, 3 deletions(-) diff --git a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt index f246aa0..1123cc6 100644 --- a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt +++ b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt @@ -45,7 +45,6 @@ Required properties: number (e.g., 0, 1, 2, etc.) - #address-cells: see partition.txt - #size-cells: see partition.txt -- nand-ecc-step-size: must be 512. see nand.txt for more details. Optional properties: - nand-bus-width: see nand.txt @@ -79,7 +78,6 @@ nand-controller@1ac00000 { reg = <0>; nand-ecc-strength = <4>; - nand-ecc-step-size = <512>; nand-bus-width = <8>; partitions { @@ -119,7 +117,6 @@ nand-controller@79b0000 { nand@0 { reg = <0>; nand-ecc-strength = <4>; - nand-ecc-step-size = <512>; nand-bus-width = <8>; partitions { -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-28 5:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1527250904-21988-1-git-send-email-absahu@codeaurora.org>
2018-05-25 12:21 ` [PATCH v3 03/16] dt-bindings: qcom_nandc: make nand-ecc-strength optional Abhishek Sahu
2018-05-26 8:42 ` Miquel Raynal
2018-05-28 5:53 ` Abhishek Sahu
2018-05-25 12:21 ` [PATCH v3 04/16] dt-bindings: qcom_nandc: remove nand-ecc-step-size Abhishek Sahu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).