[PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board

[PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board

[michael.opdenacker]

From: Michael Opdenacker <michael.opdenacker@rootcommit.com>

Document the compatible string for the OrangePi R2S board [1], which
is marketed as using the Ky X1 SoC but is in fact identical to
the SpacemiT K1 SoC [2].

Link: http://www.orangepi.org/html/hardWare/computerAndMicrocontrollers/details/Orange-Pi-R2S.html [1]
Link: https://www.spacemit.com/en/key-stone-k1 [2]
Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
---
 Documentation/devicetree/bindings/riscv/spacemit.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/riscv/spacemit.yaml b/Documentation/devicetree/bindings/riscv/spacemit.yaml
index 52fe39296031..9c49482002f7 100644
--- a/Documentation/devicetree/bindings/riscv/spacemit.yaml
+++ b/Documentation/devicetree/bindings/riscv/spacemit.yaml
@@ -23,6 +23,7 @@ properties:
               - bananapi,bpi-f3
               - milkv,jupiter
               - spacemit,musepi-pro
+              - xunlong,orangepi-r2s
               - xunlong,orangepi-rv2
           - const: spacemit,k1
 

[PATCH v3 2/2] riscv: dts: spacemit: Add OrangePi R2S board device tree

[michael.opdenacker]

From: Michael Opdenacker <michael.opdenacker@rootcommit.com>

Add initial device tree support for the OrangePi RV2 board [1], which is
marketed as using the Ky X1 SoC but has been confirmed to be
identical to the SpacemiT K1 [2].

Enable UART0, to boot into a serial console

Two Gigabit Ethernet ports with RGMII interface standard support
are enabled, each port is connected to an external
Motorcomm YT8531C PHY chip which uses the GPIO for reset control.

Enable PDMA.

Enable 8 GB eMMC chip for storage.

Link: http://www.orangepi.org/html/hardWare/computerAndMicrocontrollers/details/Orange-Pi-R2S.html [1]
Link: https://www.spacemit.com/en/key-stone-k1 [2]
Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
---
 arch/riscv/boot/dts/spacemit/Makefile         |  1 +
 .../boot/dts/spacemit/k1-orangepi-r2s.dts     | 90 +++++++++++++++++++
 2 files changed, 91 insertions(+)
 create mode 100644 arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts

diff --git a/arch/riscv/boot/dts/spacemit/Makefile b/arch/riscv/boot/dts/spacemit/Makefile
index 942ecb38bea0..96b3a13a3944 100644
--- a/arch/riscv/boot/dts/spacemit/Makefile
+++ b/arch/riscv/boot/dts/spacemit/Makefile
@@ -3,3 +3,4 @@ dtb-$(CONFIG_ARCH_SPACEMIT) += k1-bananapi-f3.dtb
 dtb-$(CONFIG_ARCH_SPACEMIT) += k1-milkv-jupiter.dtb
 dtb-$(CONFIG_ARCH_SPACEMIT) += k1-musepi-pro.dtb
 dtb-$(CONFIG_ARCH_SPACEMIT) += k1-orangepi-rv2.dtb
+dtb-$(CONFIG_ARCH_SPACEMIT) += k1-orangepi-r2s.dtb
diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
new file mode 100644
index 000000000000..58098c4a2aab
--- /dev/null
+++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-r2s.dts
@@ -0,0 +1,90 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright (C) 2025 Michael Opdenacker <michael.opdenacker@rootcommit.com>
+ */
+
+/dts-v1/;
+
+#include "k1.dtsi"
+#include "k1-pinctrl.dtsi"
+
+/ {
+	model = "OrangePi R2S";
+	compatible = "xunlong,orangepi-r2s", "spacemit,k1";
+
+	aliases {
+		serial0 = &uart0;
+		ethernet0 = &eth0;
+		ethernet1 = &eth1;
+	};
+
+	chosen {
+		stdout-path = "serial0";
+	};
+};
+
+&emmc {
+	bus-width = <8>;
+	mmc-hs400-1_8v;
+	mmc-hs400-enhanced-strobe;
+	non-removable;
+	no-sd;
+	no-sdio;
+	status = "okay";
+};
+
+&eth0 {
+	phy-handle = <&rgmii0>;
+	phy-mode = "rgmii-id";
+	pinctrl-names = "default";
+	pinctrl-0 = <&gmac0_cfg>;
+	rx-internal-delay-ps = <0>;
+	tx-internal-delay-ps = <0>;
+	status = "okay";
+
+	mdio-bus {
+		#address-cells = <0x1>;
+		#size-cells = <0x0>;
+
+		reset-gpios = <&gpio K1_GPIO(110) GPIO_ACTIVE_LOW>;
+		reset-delay-us = <10000>;
+		reset-post-delay-us = <100000>;
+
+		rgmii0: phy@1 {
+			reg = <0x1>;
+		};
+	};
+};
+
+&eth1 {
+	phy-handle = <&rgmii1>;
+	phy-mode = "rgmii-id";
+	pinctrl-names = "default";
+	pinctrl-0 = <&gmac1_cfg>;
+	rx-internal-delay-ps = <0>;
+	tx-internal-delay-ps = <250>;
+	status = "okay";
+
+	mdio-bus {
+		#address-cells = <0x1>;
+		#size-cells = <0x0>;
+
+		reset-gpios = <&gpio K1_GPIO(115) GPIO_ACTIVE_LOW>;
+		reset-delay-us = <10000>;
+		reset-post-delay-us = <100000>;
+
+		rgmii1: phy@1 {
+			reg = <0x1>;
+		};
+	};
+};
+
+&pdma {
+	status = "okay";
+};
+
+&uart0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&uart0_2_cfg>;
+	status = "okay";
+};

Re: [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board

[Krzysztof Kozlowski]

On Mon, Nov 10, 2025 at 10:06:48PM +0000, michael.opdenacker@rootcommit.com wrote:
> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> 
> Document the compatible string for the OrangePi R2S board [1], which
> is marketed as using the Ky X1 SoC but is in fact identical to
> the SpacemiT K1 SoC [2].

Different SoC means different compatible. It is very, very unlikely that
different vendor made same die, which would warrant same compatible.
Identical does not mean the same die, so your explanation is not
complete.

Best regards,
Krzysztof

Re: [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board

[Yixun Lan]

Hi Krzysztof, 

On 08:43 Tue 11 Nov     , Krzysztof Kozlowski wrote:
> On Mon, Nov 10, 2025 at 10:06:48PM +0000, michael.opdenacker@rootcommit.com wrote:
> > From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> > 
> > Document the compatible string for the OrangePi R2S board [1], which
> > is marketed as using the Ky X1 SoC but is in fact identical to
Maybe, just say it "same" to clarify the ambiguity?

> > the SpacemiT K1 SoC [2].
> 
> Different SoC means different compatible. It is very, very unlikely that
> different vendor made same die, which would warrant same compatible.
> Identical does not mean the same die, so your explanation is not
> complete.
Unfortunately, it's true that Ky X1 is just a rebrand of SpacemiT K1 SoC.

I guess it's a marketing strategy although personally I don't know
what's the motivation behind and even wish it never happens..

-- 
Yixun Lan (dlan)

Re: [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board

[Krzysztof Kozlowski]

On 11/11/2025 11:11, Yixun Lan wrote:
> Hi Krzysztof, 
> 
> On 08:43 Tue 11 Nov     , Krzysztof Kozlowski wrote:
>> On Mon, Nov 10, 2025 at 10:06:48PM +0000, michael.opdenacker@rootcommit.com wrote:
>>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>>
>>> Document the compatible string for the OrangePi R2S board [1], which
>>> is marketed as using the Ky X1 SoC but is in fact identical to
> Maybe, just say it "same" to clarify the ambiguity?

What is exactly "same"? Same die? Or same blocks/pieces? Whichever you
choose please make it very explicit.

Best regards,
Krzysztof

Re: [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board

[Michael Opdenacker]

Greetings

Thanks one more time for the reviews!

On 11/11/25 11:13, Krzysztof Kozlowski wrote:
> On 11/11/2025 11:11, Yixun Lan wrote:
>> Hi Krzysztof,
>>
>> On 08:43 Tue 11 Nov     , Krzysztof Kozlowski wrote:
>>> On Mon, Nov 10, 2025 at 10:06:48PM +0000, michael.opdenacker@rootcommit.com wrote:
>>>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>>>
>>>> Document the compatible string for the OrangePi R2S board [1], which
>>>> is marketed as using the Ky X1 SoC but is in fact identical to
>> Maybe, just say it "same" to clarify the ambiguity?
> What is exactly "same"? Same die? Or same blocks/pieces? Whichever you
> choose please make it very explicit.

Maybe Troy Mitchell from Spacemit can shed light on this question.

Anyway, I could use the same wording as in this commit introducing 
"OrangePi RV2":
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch?id=bab8dea259100a99e047fd11a48940b229d30031

"The board is described as using the Ky X1 SoC, which, based on 
available downstream sources and testing, appears to be identical or 
very closely related to the SpacemiT K1 SoC".

What do you think?

Cheers,
Michael

-- 
Michael Opdenacker
Root Commit
Yocto Project and OpenEmbedded Training course - Learn by doing:
https://rootcommit.com/training/yocto/

Re: [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board

[Krzysztof Kozlowski]

On 11/11/2025 11:29, Michael Opdenacker wrote:
> Greetings
> 
> Thanks one more time for the reviews!
> 
> On 11/11/25 11:13, Krzysztof Kozlowski wrote:
>> On 11/11/2025 11:11, Yixun Lan wrote:
>>> Hi Krzysztof,
>>>
>>> On 08:43 Tue 11 Nov     , Krzysztof Kozlowski wrote:
>>>> On Mon, Nov 10, 2025 at 10:06:48PM +0000, michael.opdenacker@rootcommit.com wrote:
>>>>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>>>>
>>>>> Document the compatible string for the OrangePi R2S board [1], which
>>>>> is marketed as using the Ky X1 SoC but is in fact identical to
>>> Maybe, just say it "same" to clarify the ambiguity?
>> What is exactly "same"? Same die? Or same blocks/pieces? Whichever you
>> choose please make it very explicit.
> 
> Maybe Troy Mitchell from Spacemit can shed light on this question.
> 
> Anyway, I could use the same wording as in this commit introducing 
> "OrangePi RV2":
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch?id=bab8dea259100a99e047fd11a48940b229d30031
> 
> "The board is described as using the Ky X1 SoC, which, based on 
> available downstream sources and testing, appears to be identical or 
> very closely related to the SpacemiT K1 SoC".
> 
> What do you think?

This clearly suggests they are not identical thus you should have also
dedicated compatible. Let me then precise, I thought it is obvious, that
except writing it more detailed in commit msg, you also need proper
binding expressing this. If this is not the same die and they look
compatible, then usually it means you need a compatible.

Best regards,
Krzysztof

Re: [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board

[Michael Opdenacker]

Hi Krzystof,

On 11/11/25 11:34, Krzysztof Kozlowski wrote:
> On 11/11/2025 11:29, Michael Opdenacker wrote:
>> Greetings
>>
>> Thanks one more time for the reviews!
>>
>> On 11/11/25 11:13, Krzysztof Kozlowski wrote:
>>> On 11/11/2025 11:11, Yixun Lan wrote:
>>>> Hi Krzysztof,
>>>>
>>>> On 08:43 Tue 11 Nov     , Krzysztof Kozlowski wrote:
>>>>> On Mon, Nov 10, 2025 at 10:06:48PM +0000, michael.opdenacker@rootcommit.com wrote:
>>>>>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>>>>>
>>>>>> Document the compatible string for the OrangePi R2S board [1], which
>>>>>> is marketed as using the Ky X1 SoC but is in fact identical to
>>>> Maybe, just say it "same" to clarify the ambiguity?
>>> What is exactly "same"? Same die? Or same blocks/pieces? Whichever you
>>> choose please make it very explicit.
>> Maybe Troy Mitchell from Spacemit can shed light on this question.
>>
>> Anyway, I could use the same wording as in this commit introducing
>> "OrangePi RV2":
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch?id=bab8dea259100a99e047fd11a48940b229d30031
>>
>> "The board is described as using the Ky X1 SoC, which, based on
>> available downstream sources and testing, appears to be identical or
>> very closely related to the SpacemiT K1 SoC".
>>
>> What do you think?
> This clearly suggests they are not identical thus you should have also
> dedicated compatible. Let me then precise, I thought it is obvious, that
> except writing it more detailed in commit msg, you also need proper
> binding expressing this. If this is not the same die and they look
> compatible, then usually it means you need a compatible.

Note quite, the sentence I reused says "identical *or* very closely 
related".

Anyway, that's not up to me to decide, as what you suggest would mean to 
fix the DTS for OrangePi RV2 too.

I was just trying to share code for this board too in a very similar way 
to what was shared for OrangePi RV2, so that people can use the mainline 
kernel to collaborate and make support for this board better than the 
custom code produced by the board vendor...

Cheers
Michael.

-- 
Michael Opdenacker
Root Commit
Yocto Project and OpenEmbedded Training course - Learn by doing:
https://rootcommit.com/training/yocto/

Re: [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board

[Yixun Lan]

Hi All,

On 11:34 Tue 11 Nov     , Krzysztof Kozlowski wrote:
> On 11/11/2025 11:29, Michael Opdenacker wrote:
> > Greetings
> > 
> > Thanks one more time for the reviews!
> > 
> > On 11/11/25 11:13, Krzysztof Kozlowski wrote:
> >> On 11/11/2025 11:11, Yixun Lan wrote:
> >>> Hi Krzysztof,
> >>>
> >>> On 08:43 Tue 11 Nov     , Krzysztof Kozlowski wrote:
> >>>> On Mon, Nov 10, 2025 at 10:06:48PM +0000, michael.opdenacker@rootcommit.com wrote:
> >>>>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> >>>>>
> >>>>> Document the compatible string for the OrangePi R2S board [1], which
> >>>>> is marketed as using the Ky X1 SoC but is in fact identical to
> >>> Maybe, just say it "same" to clarify the ambiguity?
> >> What is exactly "same"? Same die? Or same blocks/pieces? Whichever you
> >> choose please make it very explicit.
> > 
> > Maybe Troy Mitchell from Spacemit can shed light on this question.
> > 
> > Anyway, I could use the same wording as in this commit introducing 
> > "OrangePi RV2":
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch?id=bab8dea259100a99e047fd11a48940b229d30031
> > 
> > "The board is described as using the Ky X1 SoC, which, based on 
> > available downstream sources and testing, appears to be identical or 
> > very closely related to the SpacemiT K1 SoC".
sorry for bringing confusion in previous series, we had no further discussion on this..

> > 
> > What do you think?
> 
> This clearly suggests they are not identical thus you should have also
> dedicated compatible. Let me then precise, I thought it is obvious, that
> except writing it more detailed in commit msg, you also need proper
> binding expressing this. If this is not the same die and they look
> compatible, then usually it means you need a compatible.
> 

to be explicit, the Xy X1 has same die, same packaging as SpacemiT K1,
so we should not introduce new compatible in the SoC level, but a new
board compatible in patch [1/2] is ok to me

I hope this clarify this issue..

-- 
Yixun Lan (dlan)