From: Christopher Obbard <chris.obbard@collabora.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-rockchip@lists.infradead.org
Cc: kernel@collabora.com, Andy Yan <andyshrk@163.com>,
Chris Morgan <macromorgan@hotmail.com>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>, Jagan Teki <jagan@edgeble.ai>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Maya Matuszczyk <maccraft123mc@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Tianling Shen <cnsztl@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] arm64: dts: rockchip: Add Radxa ROCK 4SE
Date: Thu, 06 Jul 2023 12:33:06 +0100 [thread overview]
Message-ID: <7fa80568e37cca3b8c4560e033cd2cfc18b2eb27.camel@collabora.com> (raw)
In-Reply-To: <b573535b-25f8-8986-3d5d-2e8d4b4c5ca1@linaro.org>
Hi Krzysztof,
On Wed, 2023-07-05 at 17:53 +0200, Krzysztof Kozlowski wrote:
> On 05/07/2023 16:10, Christopher Obbard wrote:
> > Add board-specific devicetree file for the RK3399T-based Radxa ROCK 4SE
> > board. This board offers similar peripherals in a similar form-factor to
> > the existing ROCK Pi 4B but uses the cost-optimised RK3399T processor
> > (which has different OPP table than the RK3399) and other minimal hardware
> > changes.
> >
> > Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
> > ---
> >
>
>
> > +
> > +&sdio0 {
> > + status = "okay";
> > +
> > + brcmf: wifi@1 {
> > + compatible = "brcm,bcm4329-fmac";
> > + reg = <1>;
> > + interrupt-parent = <&gpio0>;
> > + interrupts = <RK_PA3 GPIO_ACTIVE_HIGH>;
>
> I just send a patch to fix this in some files, so let's try keep it
> good. Use proper interrupt type, not none.
Thank you for your review. I missed that patch, sent only a few hours before mine. I will address this in v2.
Cheers!
Chris
prev parent reply other threads:[~2023-07-06 11:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 14:10 [PATCH v1 0/3] Add support for Radxa ROCK 4SE Christopher Obbard
2023-07-05 14:10 ` [PATCH v1 1/3] arm64: dts: rockchip: Move OPP table from ROCK Pi 4 dtsi Christopher Obbard
2023-07-05 14:10 ` [PATCH v1 2/3] dt-bindings: arm: rockchip: Add Radxa ROCK 4SE Christopher Obbard
2023-07-05 15:52 ` Krzysztof Kozlowski
2023-07-05 14:10 ` [PATCH v1 3/3] arm64: dts: " Christopher Obbard
2023-07-05 15:53 ` Krzysztof Kozlowski
2023-07-06 11:33 ` Christopher Obbard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fa80568e37cca3b8c4560e033cd2cfc18b2eb27.camel@collabora.com \
--to=chris.obbard@collabora.com \
--cc=andyshrk@163.com \
--cc=cnsztl@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jagan@edgeble.ai \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maccraft123mc@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).