From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BDD5C81857 for ; Mon, 27 Apr 2020 23:09:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 17AC92072D for ; Mon, 27 Apr 2020 23:09:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="kguuEGw+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726204AbgD0XJY (ORCPT ); Mon, 27 Apr 2020 19:09:24 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:24831 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726285AbgD0XJY (ORCPT ); Mon, 27 Apr 2020 19:09:24 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1588028964; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=oMxZb5I+GDPuJhllgcs2iwGmqgsZIZTUBZ0afvMS0fU=; b=kguuEGw+ZCiOVeyvqN4L0kCpqhIrOJoBzylNNDzvMT7ghQFv/bzabcYzJKrmoUISPEXG4HRd qBrNzYL1FNk1uzwmP7L0T7n+0+Bjca7YfGkNs8xMeuCdj0gFD+07yuNzVxV5Q8rHXkKLZ9iO napKrnJB0JNA0LKE/s/QiFg0elg= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5ea76613.7fdbc1aff998-smtp-out-n03; Mon, 27 Apr 2020 23:09:07 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 10FD8C432C2; Mon, 27 Apr 2020 23:09:07 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: tanmay) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6377CC433CB; Mon, 27 Apr 2020 23:09:06 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 27 Apr 2020 16:09:06 -0700 From: tanmay@codeaurora.org To: Rob Herring Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, swboyd@chromium.org, seanpaul@chromium.org, abhinavk@codeaurora.org, varar@codeaurora.org, aravindh@codeaurora.org, freedreno@lists.freedesktop.org, dri-devel Subject: Re: [PATCH 1/2] dt-bindings: msm: disp: Add Display Port HPD GPIO bindings In-Reply-To: <20200415152439.GA9882@bogus> References: <1586299709-14222-1-git-send-email-tanmay@codeaurora.org> <20200415152439.GA9882@bogus> Message-ID: <7fb3a6c19c244c4a37bded7cd249a1f8@codeaurora.org> X-Sender: tanmay@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Thanks Rob for reviews. We are using Display Port Controller block to detect hot plug. So we won't be using that pin as GPIO. I found now that we don't need any bindings for that pin in such case. So I am abandoning this patch series and upload new patch. Thanks. On 2020-04-15 08:24, Rob Herring wrote: > On Tue, Apr 07, 2020 at 03:48:28PM -0700, Tanmay Shah wrote: >> Add Display Port HPD GPIO description in bindings >> >> This Patch depends on: >> https://patchwork.kernel.org/patch/11468505/ > > This belongs below the '---' and probably means you should send all > this > as one series. > >> >> Signed-off-by: Tanmay Shah >> --- >> Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml | 7 > +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git > a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml > b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml >> index 761a01d..003f5f7 100644 >> --- a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml >> @@ -155,6 +155,11 @@ properties: >> data-lanes: >> description: Maximum number of lanes that can be used for > Display port. >> >> + dp-hpd-gpio: > > We already have a standard property for this. Use it. > > It belongs in the connector node as HPD is part of the connector. > >> + maxItems: 1 >> + description: Specifies HPD gpio for DP connector without >> + USB PHY or AUX switch. >> + >> usbplug-cc-gpio: > > Note that this too should be in a connector node. > >> maxItems: 1 >> description: Specifies the usbplug orientation gpio. >> @@ -282,6 +287,8 @@ examples: >> aux-sel-gpio = <&msmgpio 110 1>; >> usbplug-cc-gpio = <&msmgpio 90 1>; >> >> + dp-hpd-gpio = <&msmgpio 117 0>; >> + >> ports { >> #address-cells = <1>; >> #size-cells = <0>; >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora > Forum, >> a Linux Foundation Collaborative Project > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel