Re: [PATCH v2] regulator: dt-bindings: microchip,mcp16502: convert to YAML

[<Andrei.Simion@microchip.com>]

On 30.01.2024 10:21, Krzysztof Kozlowski wrote:
> [You don't often get email from krzysztof.kozlowski@linaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 29/01/2024 14:53, Andrei Simion wrote:
>> Convert devicetree binding mcp16502-regulator.txt to YAML format.
>>
>> Signed-off-by: Andrei Simion <andrei.simion@microchip.com>
> 
> Thank you for your patch. There is something to discuss/improve.
> 
>> ---
>> Changes v1 -> v2:
>> - reverse subject prefixes
>> - line break after file "description:"
>> - drop description for reg
>> - drop regulator-name
>> - add regulator-initial-mode
>> - unevaluatedProperties just after $ref: regulator.yaml#
>> - additionalProperties  just before "required"
>> - node names generic in example
>> - use 4 spaces for example indentation
> 
> 
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  regulators:
>> +    type: object

	additionalProperties: false  -> forgot this line. That is my missing to hit all the points in the previous review. Let me know If that is all.

>> +    description: List of regulators and its properties.
>> +      A node that houses a sub-node for each regulator within
>> +      the device. Each sub-node is identified using the node's
>> +      name. The content of each sub-node is defined by the
>> +      standard binding for regulators;> 
> This is a friendly reminder during the review process.
> 
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.
> > Also: you can keep just one line of description. Rest is redundant.
> 
Yes, I will change in v3 .

>> Best regards,
> Krzysztof
> 

Thank you for review and best regards,
Andrei Simion