From: <Tudor.Ambarus@microchip.com>
To: <Sergiu.Moga@microchip.com>, <broonie@kernel.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<Claudiu.Beznea@microchip.com>
Cc: <linux-spi@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<Kavyasree.Kotagiri@microchip.com>,
<UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH v2] spi: atmel: convert spi_atmel to json-schema
Date: Mon, 4 Jul 2022 13:24:54 +0000 [thread overview]
Message-ID: <7fc3b50b-c9fc-b1b5-ba84-752b2e3da7d7@microchip.com> (raw)
In-Reply-To: <20220704083143.56150-1-sergiu.moga@microchip.com>
On 7/4/22 11:31, Sergiu Moga wrote:
> + atmel,fifo-size:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + Maximum number of data the RX and TX FIFOs can store for FIFO
> + capable SPI controllers.
> + minimum: 16
> + maximum: 32
Shouldn't we have an enum instead of a range? Can the FIFO size have a value of 24?
next prev parent reply other threads:[~2022-07-04 13:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 8:31 [PATCH v2] spi: atmel: convert spi_atmel to json-schema Sergiu Moga
2022-07-04 12:52 ` Krzysztof Kozlowski
2022-07-04 13:13 ` Claudiu.Beznea
2022-07-04 13:15 ` Krzysztof Kozlowski
2022-07-04 13:32 ` Sergiu.Moga
2022-07-04 13:48 ` Krzysztof Kozlowski
2022-07-04 13:24 ` Tudor.Ambarus [this message]
2022-07-04 13:42 ` Tudor.Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fc3b50b-c9fc-b1b5-ba84-752b2e3da7d7@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Kavyasree.Kotagiri@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=Sergiu.Moga@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox