From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75E35C04A94 for ; Sat, 12 Aug 2023 14:15:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234144AbjHLOPr (ORCPT ); Sat, 12 Aug 2023 10:15:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232935AbjHLOPp (ORCPT ); Sat, 12 Aug 2023 10:15:45 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EAC81FE1 for ; Sat, 12 Aug 2023 07:15:47 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2ba1e9b1fa9so44331711fa.3 for ; Sat, 12 Aug 2023 07:15:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691849746; x=1692454546; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qvNfKvAylgC4uffqZdOpDtDEQniAKRUYrpspZKXOdVw=; b=uaob22TaDg5gc6wd2x6oAmstMdvuIntX/ooZtiKg/Mabf45YKhmTbWO8SHjMIZsmW3 0TopC3dapyE1aOYoTlTw7cmcM0cTZN4EvHhKD4Uy7efPeb7SU9dVfCcbE0JtS4sE7ZiK 9sGwOTAsSJXsd0LdxnzbaMkw7wcbnPoeBWv3jXa/l5eyzv9UiX2APimfvuOLdpug+RAe Q0M8uRxz1X1m4V81nJ0BV+XDfB0tzrhEOBBJsUdRF7y9IHo6kKySH4h4Z2Jn4r5PowRC Jt/gwaJizugCV/xagAy3n95q6fXwXfsHZtZ7ajNBW/Vch+OcY6d/5AjgsUDW/APLAIOM hcjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691849746; x=1692454546; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qvNfKvAylgC4uffqZdOpDtDEQniAKRUYrpspZKXOdVw=; b=fWoHEN4z320WiHyZyW65Vqtgq4rivk5HII1MfS8Y4hVVfNnubjjwBxvg14WbU06UM0 Q71lRPte6hQmhmmCKZIngi2kQBFGMKj9LNmqWNzqDk8OAtnNkW66IrMctvqcAT591+1g qU9HHCozCl2FJhGny3uTqOqg1ZjahBCLJ6giFD514oaDNnWhK1c1H+/pDlpJr1ZluS/U 7q4S7/U4/FcOP3X+6VazZV3APSseaLBUCeuEkdcuO4tJ5UhoL1DIilHkbmJJcrcQyezg e5Y9h3iVOLpfRrwjUlK5egK0xMLjLoMbrbSAaODeFfvj0GZmkNUS2IZM9A/aDRajKBtp tCaQ== X-Gm-Message-State: AOJu0Yykw/yRzOq68C9p/3oUOmLve1g9VCNIY0C9z52t6LuN2P3WTc2Y qQgBYhAlzBKxEObo18iAIgyRzw== X-Google-Smtp-Source: AGHT+IFL6tE/6U9ldoGNxkeCqcwrKZNfJf7CoWEEGGip0Ja1JpmeFtdg+zMsAU41yxbwqNhXljwMJw== X-Received: by 2002:a2e:964e:0:b0:2b6:bb08:91c4 with SMTP id z14-20020a2e964e000000b002b6bb0891c4mr3858490ljh.42.1691849745828; Sat, 12 Aug 2023 07:15:45 -0700 (PDT) Received: from [192.168.1.101] (abyj188.neoplus.adsl.tpnet.pl. [83.9.29.188]) by smtp.gmail.com with ESMTPSA id j22-20020a2e3c16000000b002b6cb598558sm1405915lja.49.2023.08.12.07.15.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 12 Aug 2023 07:15:45 -0700 (PDT) Message-ID: <7fdee4c2-4c14-4a7f-b161-52ccd2458d3f@linaro.org> Date: Sat, 12 Aug 2023 16:15:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] ARM: dts: qcom: ipq4019-ap.dk01.1: align flash node with bindings Content-Language: en-US To: Robert Marko Cc: agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Caleb Connolly References: <20230811210142.403160-1-robimarko@gmail.com> <20230811210142.403160-2-robimarko@gmail.com> <4c96210b-4567-4cb5-80bb-7adca6c5f124@linaro.org> <7116b473-7f22-43df-af39-81e5f6db4507@linaro.org> <389904f7-86fa-48be-ba30-aa8cfeb44353@linaro.org> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12.08.2023 16:12, Robert Marko wrote: > On Sat, 12 Aug 2023 at 16:08, Konrad Dybcio wrote: >> >> On 12.08.2023 16:07, Robert Marko wrote: >>> On Sat, 12 Aug 2023 at 12:47, Konrad Dybcio wrote: >>>> >>>> On 12.08.2023 11:55, Robert Marko wrote: >>>>> On Sat, 12 Aug 2023 at 00:56, Konrad Dybcio wrote: >>>>>> >>>>>> On 11.08.2023 23:35, Robert Marko wrote: >>>>>>> On Fri, 11 Aug 2023 at 23:28, Konrad Dybcio wrote: >>>>>>>> >>>>>>>> On 11.08.2023 23:01, Robert Marko wrote: >>>>>>>>> Rename the SPI-NOR node to flash@0, remove #address-cells and #size-cells >>>>>>>>> as they should be under the partitions subnode and use the generic >>>>>>>>> jedec,spi-nor compatible. >>>>>>>>> >>>>>>>>> Signed-off-by: Robert Marko >>>>>>>>> --- >>>>>>>> You can also do "nandmanufacturer,mx25l25635e", "jedec,spi-nor" >>>>>>> >>>>>>> Hi, >>>>>>> I grepped the vendor U-Boot to make sure it's not being triggered off >>>>>>> the mx25l25635e >>>>>>> compatible but the only hit is the IC support itself. >>>>>>> MX25L25635 was just the original NOR IC Qualcomm used on the board so >>>>>>> to me it made >>>>>>> most sense to just use the JEDEC compatible as NOR itself is JEDEC NOR >>>>>>> compatible. >>>>>> OK if dynamic identification works fine >>>>> >>>>> It should work fine, datasheet is clear that its JEDEC compatible. >>>>> That being said, I dont actually have the board, just figured it was >>>>> time for a cleanup as >>>>> OpenWrt has been patching DK01 and DK04 for ages. >>>> Hm. Do we know whether there are still users of this boards? >>> >>> I honestly doubt it as they have been broken in OpenWrt for years and >>> nobody complained. >>> So we are currently removing support for them, but I still wanted to >>> at least fixup the DTS state >>> upstream. >>> These boards are not obtainable anymore. >> I also noticed they were detached from the other snapdragons in u-boot >> for no good reason (at first glance anyway). > > If you are talking about the mainline U-Boot then yeah, my basic port was done > years ago and I knew way less about the SoC then now. > Currently its on my TODO to merge them with Snapdragon and add some proper > GPIO and pinctrl drivers as well as using the Linux DTS. Take a look at this branch of mine [1], I already did some of that. If you wish to upstream that, please coordinate with Caleb (+CC) who may be interested in the same in parallel. [1] https://github.com/konradybcio/u-boot/commits/konrad/rb1_forcepushing Konrad