From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Elliot Berman <quic_eberman@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>
Cc: Conor Dooley <conor.dooley@microchip.com>,
linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] dt-bindings: crypto: qcom,prng: Add SM8450
Date: Mon, 6 Nov 2023 19:06:35 +0100 [thread overview]
Message-ID: <7fe60d90-83b3-421f-89b2-51c62d4207a0@linaro.org> (raw)
In-Reply-To: <e2b73ea0-c659-431e-9275-88d1a98f37cf@quicinc.com>
On 06/11/2023 18:05, Elliot Berman wrote:
>
>
> On 11/5/2023 5:03 AM, Krzysztof Kozlowski wrote:
>> On 03/11/2023 23:52, Elliot Berman wrote:
>>> From: Konrad Dybcio <konrad.dybcio@linaro.org>
>>>
>>> SM8450's PRNG does not require a core clock reference. Add a new
>>> compatible with a qcom,prng-ee fallback and handle that.
>>>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>>> Signed-off-by: Elliot Berman <quic_eberman@quicinc.com>
>>> ---
>>> I noticed this patch got missed while running make dtbs_check. No
>>> changes to this patch from the original version:
>>>
>>> https://lore.kernel.org/all/2c208796-5ad6-c362-dabc-1228b978ca1d@linaro.org/
>>>
>>
>> I don't understand why do you send this. This is not a correct patch,
>> was rejected. Different patch was already merged.
>
> I see that 6.6 has
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sm8450.dtsi?h=v6.6#n1741
>
> but bindings not updated:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/crypto/qcom,prng.yaml?h=v6.6
>
> I came up with similar-ish fix offline, then found Konrad had posted the patch when searching lore.
> I didn't find any other patch on lore.
>
> I think you rejected a proposal to drop "p" from "prng", but this patch
> doesn't do that and we stayed course with naming scheme.
Please start working on linux-next, not on the last kernel release.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-11-06 18:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 22:52 [RESEND PATCH] dt-bindings: crypto: qcom,prng: Add SM8450 Elliot Berman
2023-11-05 13:03 ` Krzysztof Kozlowski
2023-11-06 17:05 ` Elliot Berman
2023-11-06 18:06 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fe60d90-83b3-421f-89b2-51c62d4207a0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_eberman@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).