From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73582C7EE43 for ; Mon, 12 Jun 2023 10:03:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236885AbjFLKDw (ORCPT ); Mon, 12 Jun 2023 06:03:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236437AbjFLKCH (ORCPT ); Mon, 12 Jun 2023 06:02:07 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E39361985 for ; Mon, 12 Jun 2023 02:45:45 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-4f6370ddd27so4684256e87.0 for ; Mon, 12 Jun 2023 02:45:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686563144; x=1689155144; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DWwcG8B478jMSpAgeoJrfgqQXgVZW1IwS0fWhOn6gk0=; b=upBU3IKs93WTyz/V/gEN+RLEp9WIg19EH3y6zBS6ow1ie08c4Ipr7gH1W7uhqwZOZI lHfKdssyJ2ly3Fgt/rckwxO3zaArORYq2ZFx8c17CQHCAsSfdrg7KsckJGSP0yKEU0Le DR/5IZGAvGTxCdtwx/N/S9z7bWRqufplkmUQ9wk2OEmy9ZahyBakPrxs4eboJOwYkPQE anV+zG3p1ay1p4RJxaaMU3uW1z1NCTEFyK2SO42tFuiFuAZu/d0MOqBNMizvH07LrfLg VKKf9/6i55Jqj6kFbbj0TPbZhChRYgMDsqpcRE9tkFansq7SNLw3JHSdfqJE6ugpNGZD Gt/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686563144; x=1689155144; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DWwcG8B478jMSpAgeoJrfgqQXgVZW1IwS0fWhOn6gk0=; b=KRwPdyuv2ha6pXOFnN0u3Cq1ik3fPcpVtCtsaSRzjwqyYj5PAOBEDvcHQp3RqBjF8B S694mKWZBMuV4dWWMaUTG2/w72PN6Y7Nz/Uv1NwIMyjcQ7jlAGTWCNYviTHdjZmXkIQo 41S1MwbUqhnWAqwvwAuoP3SEBnlyggPMA2+g9xd7YH9wE84xtAEgzk5KAmisAGxH0C3/ 4EkMX4fSXH+YtzSyoNS1pRR34GqhdMdM3qaVmZ75WWiepBNC6JrEe1z25aP0FSD/gJVT xWpX3RhTR4HQ5GWDcgHslALIjoe+MXFgbcTq5Lcfz91FePasbUd5XaGoCZ6FtjVSRYMW +ugA== X-Gm-Message-State: AC+VfDyGZQDMGuTrmFwXbi/j6nv7/6J585NZgjRcGaug5gggf2zFG6Ty WvO/66mwqXkQvUyI/xlKA2TgMw== X-Google-Smtp-Source: ACHHUZ43/gi+znYlYQvf2z3Zeqhx6w4RHoSruCkErpQAm+KwwannknuxHnOqh55jxAdULPv7Gxv4YA== X-Received: by 2002:a2e:908f:0:b0:2b1:e943:8abe with SMTP id l15-20020a2e908f000000b002b1e9438abemr2380153ljg.47.1686563144165; Mon, 12 Jun 2023 02:45:44 -0700 (PDT) Received: from [192.168.1.101] (abyj190.neoplus.adsl.tpnet.pl. [83.9.29.190]) by smtp.gmail.com with ESMTPSA id n23-20020a2e86d7000000b002ac78893a9csm1672079ljj.72.2023.06.12.02.45.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jun 2023 02:45:43 -0700 (PDT) Message-ID: <7fe7078e-404d-28e5-0dd1-53b7f9cd7626@linaro.org> Date: Mon, 12 Jun 2023 11:45:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 03/26] phy: qcom: add the SGMII SerDes PHY driver Content-Language: en-US To: Bartosz Golaszewski , Vinod Koul , Bhupesh Sharma , Andy Gross , Bjorn Andersson , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kishon Vijay Abraham I , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu Cc: netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Bartosz Golaszewski References: <20230612092355.87937-1-brgl@bgdev.pl> <20230612092355.87937-4-brgl@bgdev.pl> From: Konrad Dybcio In-Reply-To: <20230612092355.87937-4-brgl@bgdev.pl> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12.06.2023 11:23, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Implement support for the SGMII/SerDes PHY present on various Qualcomm > platforms. > > Signed-off-by: Bartosz Golaszewski > --- > +static const struct regmap_config qcom_dwmac_sgmii_phy_regmap_cfg = { > + .reg_bits = 32, > + .val_bits = 32, > + .reg_stride = 4, > + .use_relaxed_mmio = true, > + .disable_locking = true, The last two are rather brave, no? Konrad > +}; > + > +static int qcom_dwmac_sgmii_phy_probe(struct platform_device *pdev) > +{ > + struct qcom_dwmac_sgmii_phy_data *data; > + struct device *dev = &pdev->dev; > + struct phy_provider *provider; > + struct clk *refclk; > + void __iomem *base; > + struct phy *phy; > + > + data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); > + if (!data) > + return -ENOMEM; > + > + base = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(base)) > + return PTR_ERR(base); > + > + data->regmap = devm_regmap_init_mmio(dev, base, > + &qcom_dwmac_sgmii_phy_regmap_cfg); > + if (IS_ERR(data->regmap)) > + return PTR_ERR(data->regmap); > + > + phy = devm_phy_create(dev, NULL, &qcom_dwmac_sgmii_phy_ops); > + if (IS_ERR(phy)) > + return PTR_ERR(phy); > + > + refclk = devm_clk_get_enabled(dev, "sgmi_ref"); > + if (IS_ERR(refclk)) > + return PTR_ERR(refclk); > + > + provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); > + if (IS_ERR(provider)) > + return PTR_ERR(provider); > + > + phy_set_drvdata(phy, data); > + platform_set_drvdata(pdev, data); > + > + return 0; > +} > + > +static const struct of_device_id qcom_dwmac_sgmii_phy_of_match[] = { > + { .compatible = "qcom,sa8775p-dwmac-sgmii-phy" }, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, qcom_dwmac_sgmii_phy_of_match); > + > +static struct platform_driver qcom_dwmac_sgmii_phy_driver = { > + .probe = qcom_dwmac_sgmii_phy_probe, > + .driver = { > + .name = "qcom-dwmac-sgmii-phy", > + .of_match_table = qcom_dwmac_sgmii_phy_of_match, > + } > +}; > + > +module_platform_driver(qcom_dwmac_sgmii_phy_driver); > + > +MODULE_DESCRIPTION("Qualcomm DWMAC SGMII PHY driver"); > +MODULE_LICENSE("GPL");