devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh@nvidia.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Aaron Kling <webgeek1234@gmail.com>
Cc: Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH v4 3/5] memory: tegra186-emc: Support non-bpmp icc scaling
Date: Wed, 10 Dec 2025 04:08:42 +0000	[thread overview]
Message-ID: <7ffdd81b-927e-46f1-976c-91fe2fee4f07@nvidia.com> (raw)
In-Reply-To: <83142b0c-0743-4a23-8846-e9f5e72a7677@kernel.org>


On 09/12/2025 05:53, Krzysztof Kozlowski wrote:
> On 09/12/2025 05:26, Aaron Kling wrote:
>> On Sat, Nov 22, 2025 at 6:01 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>
>>> On 21/11/2025 12:21, Jon Hunter wrote:
>>>>
>>>> On 12/11/2025 07:21, Aaron Kling wrote:
>>>>> On Wed, Nov 12, 2025 at 12:18 AM Jon Hunter <jonathanh@nvidia.com> wrote:
>>>>>>
>>>>>>
>>>>>> On 11/11/2025 23:17, Aaron Kling wrote:
>>>>>>
>>>>>> ...
>>>>>>
>>>>>>> Alright, I think I've got the picture of what's going on now. The
>>>>>>> standard arm64 defconfig enables the t194 pcie driver as a module. And
>>>>>>> my simple busybox ramdisk that I use for mainline regression testing
>>>>>>> isn't loading any modules. If I set the pcie driver to built-in, I
>>>>>>> replicate the issue. And I don't see the issue on my normal use case,
>>>>>>> because I have the dt changes as well.
>>>>>>>
>>>>>>> So it appears that the pcie driver submits icc bandwidth. And without
>>>>>>> cpufreq submitting bandwidth as well, the emc driver gets a very low
>>>>>>> number and thus sets a very low emc freq. The question becomes... what
>>>>>>> to do about it? If the related dt changes were submitted to
>>>>>>> linux-next, everything should fall into place. And I'm not sure where
>>>>>>> this falls on the severity scale since it doesn't full out break boot
>>>>>>> or prevent operation.
>>>>>>
>>>>>> Where are the related DT changes? If we can get these into -next and
>>>>>> lined up to be merged for v6.19, then that is fine. However, we should
>>>>>> not merge this for v6.19 without the DT changes.
>>>>>
>>>>> The dt changes are here [0].
>>>>
>>>> To confirm, applying the DT changes do not fix this for me. Thierry is
>>>> having a look at this to see if there is a way to fix this.
>>>>
>>>> BTW, I have also noticed that Thierry's memory frequency test [0] is
>>>> also failing on Tegra186. The test simply tries to set the frequency via
>>>> the sysfs and this is now failing. I am seeing ..
>>
>> With this patch dropped from -next, what needs to happen to get it
>> requeued? I gave an analysis over two weeks ago and have seen no
>> response since.
> 
> Hm, I did not see the root cause identified, so maybe I missed something.
> 
> Anyway, I am waiting for the patchset to be retested and resent. And
> testing MUST include kernel development process rules, including how
> patches are taken - see maintainer soc profile. Any dependencies must be
> clearly marked.

Yes me too. I am happy to re-test any updates.

Jon

-- 
nvpublic


  reply	other threads:[~2025-12-10  4:08 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-27 18:55 [PATCH v4 0/5] memory: tegra: Support EMC dfs on Tegra186/Tegra194 Aaron Kling via B4 Relay
2025-10-27 18:55 ` [PATCH v4 1/5] dt-bindings: memory: tegra186-mc: Add dummy client IDs for Tegra186 Aaron Kling via B4 Relay
2025-10-27 18:55 ` [PATCH v4 2/5] dt-bindings: memory: tegra194-mc: Add dummy client IDs for Tegra194 Aaron Kling via B4 Relay
2025-10-27 18:55 ` [PATCH v4 3/5] memory: tegra186-emc: Support non-bpmp icc scaling Aaron Kling via B4 Relay
2025-11-10 21:25   ` Jon Hunter
2025-11-10 21:55     ` Aaron Kling
2025-11-11  1:39       ` Aaron Kling
2025-11-11 11:13         ` Jon Hunter
2025-11-11 11:16           ` Krzysztof Kozlowski
2025-11-11 12:05             ` Jon Hunter
2025-11-11 14:35               ` Jon Hunter
2025-11-11 17:04                 ` Aaron Kling
2025-11-11 21:29                   ` Jon Hunter
2025-11-11 23:17                     ` Aaron Kling
2025-11-12  6:18                       ` Jon Hunter
2025-11-12  7:21                         ` Aaron Kling
2025-11-12  7:31                           ` Krzysztof Kozlowski
2025-11-21 11:21                           ` Jon Hunter
2025-11-21 18:17                             ` Aaron Kling
2025-12-10  4:08                               ` Jon Hunter
2025-12-10  5:06                                 ` Aaron Kling
2025-12-10 15:03                                   ` Jon Hunter
2025-12-10 18:32                                     ` Aaron Kling
2025-12-10 21:24                                       ` Jon Hunter
2025-12-10 22:41                                         ` Aaron Kling
2025-12-11  7:46                                           ` Jon Hunter
2025-11-22 12:01                             ` Krzysztof Kozlowski
2025-12-09  4:26                               ` Aaron Kling
2025-12-09  5:53                                 ` Krzysztof Kozlowski
2025-12-10  4:08                                   ` Jon Hunter [this message]
2025-11-12  7:26                         ` Krzysztof Kozlowski
2025-11-12 10:59                           ` Jon Hunter
2025-11-12 11:42                             ` Krzysztof Kozlowski
2025-11-12 12:29                               ` Jon Hunter
2025-11-12  7:26                       ` Krzysztof Kozlowski
2025-10-27 18:55 ` [PATCH v4 4/5] memory: tegra186: Support " Aaron Kling via B4 Relay
2025-10-27 18:55 ` [PATCH v4 5/5] memory: tegra194: " Aaron Kling via B4 Relay
2025-10-31 13:21 ` [PATCH v4 0/5] memory: tegra: Support EMC dfs on Tegra186/Tegra194 Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ffdd81b-927e-46f1-976c-91fe2fee4f07@nvidia.com \
    --to=jonathanh@nvidia.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=webgeek1234@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).