From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 07/24] ARM: shmobile: Drop dev_irq_safe from r8a7779 genpd config Date: Wed, 11 Jun 2014 11:13:11 -0700 Message-ID: <7ha99jiabs.fsf@paris.lan> References: <1402397497-26737-1-git-send-email-ulf.hansson@linaro.org> <1402397497-26737-8-git-send-email-ulf.hansson@linaro.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1402397497-26737-8-git-send-email-ulf.hansson@linaro.org> (Ulf Hansson's message of "Tue, 10 Jun 2014 12:51:20 +0200") Sender: linux-pm-owner@vger.kernel.org To: Ulf Hansson Cc: "Rafael J. Wysocki" , Len Brown , Pavel Machek , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alan Stern , Greg Kroah-Hartman , Daniel Lezcano , Tomasz Figa , devicetree@vger.kernel.org, Linus Walleij , Simon Horman , Magnus Damm , Ben Dooks , Kukjin Kim , Stephen Boyd , Philipp Zabel , Mark Brown List-Id: devicetree@vger.kernel.org Ulf Hansson writes: > The dev_irq_safe configuration is redundant, genpd don't have any > special treatmeant for handling it. Let's remove it. Why? The genpd core needs to handle irq_safe properly eventully (right now it just doesn't call power_off/power_on callbacks, but that needs to be implmenented. c.f commit 0aa2a22169) If we remove these flags from platforms, we're taking away information that the platform maintainers have specified tha will be useful when full support is avialble. Kevin