From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v3 01/13] PM / Domains: Add genpd attach/detach callbacks Date: Fri, 26 Sep 2014 08:47:34 -0700 Message-ID: <7heguy4c4p.fsf@deeprootsystems.com> References: <1411662520-22795-1-git-send-email-geert+renesas@glider.be> <1411662520-22795-2-git-send-email-geert+renesas@glider.be> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1411662520-22795-2-git-send-email-geert+renesas@glider.be> (Geert Uytterhoeven's message of "Thu, 25 Sep 2014 18:28:28 +0200") Sender: linux-pm-owner@vger.kernel.org To: Geert Uytterhoeven Cc: "Rafael J. Wysocki" , Simon Horman , Magnus Damm , Ulf Hansson , Tomasz Figa , Philipp Zabel , Grygorii Strashko , linux-sh@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org Geert Uytterhoeven writes: > While a PM domain can enable PM runtime management of its devices' module > clocks by setting > > genpd->dev_ops.stop = pm_clk_suspend; > genpd->dev_ops.start = pm_clk_resume; > > this also requires registering the clocks with the pm_clk subsystem. > In the legacy case, this is handled by the platform code, after > attaching the device to its PM domain. > > When the devices are instantiated from DT, devices are attached to their > PM domains by generic code, leaving no method for the platform-specific > PM domain code to register their clocks. > > Add two callbacks, allowing a PM domain to perform platform-specific > tasks when a device is attached to or detached from a PM domain. > > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Ulf Hansson I replied to the previous RFC, but just to be thorough (and because I like this approach): Reviewed-by: Kevin Hilman Kevin