Devicetree
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
To: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
Cc: linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM64: dts: amlogic: use generic bus node names
Date: Thu, 07 Dec 2017 11:30:27 -0800	[thread overview]
Message-ID: <7hindiqqss.fsf@baylibre.com> (raw)
In-Reply-To: <fb631d1c-2b12-34e4-c157-ba11242e68de-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> (Neil Armstrong's message of "Thu, 7 Dec 2017 09:35:50 +0100")

Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> writes:

> On 06/12/2017 20:30, Kevin Hilman wrote:
>> The DT spec recommends that node-names have generic names like "bus".
>> Fix that in the Amlogic DTs, while leaving the label names to have more
>> SoC-specific names that match with the HW documentation.
>> 
>> Suggested-by: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
>> Signed-off-by: Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
>> ---
>>  arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
>>  arch/arm64/boot/dts/amlogic/meson-gx.dtsi  | 6 +++---
>>  2 files changed, 5 insertions(+), 5 deletions(-)
>> 
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> index b932a784b02a..e7213eb53958 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> @@ -113,7 +113,7 @@
>>  		#size-cells = <2>;
>>  		ranges;
>>  
>> -		cbus: cbus@ffd00000 {
>> +		cbus: bus@ffd00000 {
>>  			compatible = "simple-bus";
>>  			reg = <0x0 0xffd00000 0x0 0x25000>;
>>  			#address-cells = <2>;
>> @@ -175,7 +175,7 @@
>>  			};
>>  		};
>>  
>> -		aobus: aobus@ff800000 {
>> +		aobus: bus@ff800000 {
>>  			compatible = "simple-bus";
>>  			reg = <0x0 0xff800000 0x0 0x100000>;
>>  			#address-cells = <2>;
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> index 7cdbf58a062f..6cb3c2a52baf 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> @@ -211,7 +211,7 @@
>>  		#size-cells = <2>;
>>  		ranges;
>>  
>> -		cbus: cbus@c1100000 {
>> +		cbus: bus@c1100000 {
>>  			compatible = "simple-bus";
>>  			reg = <0x0 0xc1100000 0x0 0x100000>;
>>  			#address-cells = <2>;
>> @@ -366,7 +366,7 @@
>>  			};
>>  		};
>>  
>> -		aobus: aobus@c8100000 {
>> +		aobus: bus@c8100000 {
>>  			compatible = "simple-bus";
>>  			reg = <0x0 0xc8100000 0x0 0x100000>;
>>  			#address-cells = <2>;
>> @@ -453,7 +453,7 @@
>>  			};
>>  		};
>>  
>> -		hiubus: hiubus@c883c000 {
>> +		hiubus: bus@c883c000 {
>>  			compatible = "simple-bus";
>>  			reg = <0x0 0xc883c000 0x0 0x2000>;
>>  			#address-cells = <2>;
>> 
>
> Reviewed-by: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>

Applied to v4.16/dt64 with Neil's review and after doing some basic
build/boot tests.

Thanks,

Kevin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2017-12-07 19:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-06 19:30 [PATCH] ARM64: dts: amlogic: use generic bus node names Kevin Hilman
     [not found] ` <20171206193005.24171-1-khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2017-12-07  8:35   ` Neil Armstrong
     [not found]     ` <fb631d1c-2b12-34e4-c157-ba11242e68de-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2017-12-07 19:30       ` Kevin Hilman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7hindiqqss.fsf@baylibre.com \
    --to=khilman-rdvid1duhrbwk0htik3j/w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox