From: Kevin Hilman <khilman@kernel.org>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Roger Lu <roger.lu@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Enric Balletbo Serra <eballetbo@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Nicolas Boichat <drinkcat@google.com>,
Stephen Boyd <sboyd@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: Fan Chen <fan.chen@mediatek.com>,
HenryC Chen <HenryC.Chen@mediatek.com>,
Xiaoqing Liu <Xiaoqing.Liu@mediatek.com>,
Charles Yang <Charles.Yang@mediatek.com>,
Angus Lin <Angus.Lin@mediatek.com>,
Mark Rutland <mark.rutland@arm.com>, Nishanth Menon <nm@ti.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
Guenter Roeck <linux@roeck-us.net>,
Jia-wei Chang <jia-wei.chang@mediatek.com>
Subject: Re: [PATCH v23 0/7] soc: mediatek: SVS: introduce MTK SVS
Date: Fri, 18 Mar 2022 09:48:02 -0700 [thread overview]
Message-ID: <7hlex7p5q5.fsf@baylibre.com> (raw)
In-Reply-To: <60613d10-f7fc-03ea-900f-4255ebe0d5aa@collabora.com>
AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
writes:
> Il 21/02/22 07:39, Roger Lu ha scritto:
>> The Smart Voltage Scaling(SVS) engine is a piece of hardware
>> which calculates suitable SVS bank voltages to OPP voltage table.
>> Then, DVFS driver could apply those SVS bank voltages to PMIC/Buck
>> when receiving OPP_EVENT_ADJUST_VOLTAGE.
>>
>> 1. SVS driver uses OPP adjust event in [1] to update OPP table voltage part.
>> 2. SVS driver gets thermal/GPU device by node [2][3] and CPU device by get_cpu_device().
>> After retrieving subsys device, SVS driver calls device_link_add() to make sure probe/suspend callback priority.
>>
>> [1] https://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git/commit/?h=opp/linux-next&id=25cb20a212a1f989385dfe23230817e69c62bee5
>> [2] https://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git/commit/?h=opp/linux-next&id=b325ce39785b1408040d90365a6ab1aa36e94f87
>> [3] https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/commit/?h=v5.16-next/dts64&id=a8168cebf1bca1b5269e8a7eb2626fb76814d6e2
>>
>> change since v22:
>> - Make "svsb_volt = max(svsb->volt[i] + temp_voffset, svsb->vmin);" become one line.
>> - Remove voffset read/write commands for better system safety.
>> - Add more comments on @turn_freq_base.
>>
>> Roger Lu (7):
>> [v23,1/7] dt-bindings: soc: mediatek: add mtk svs dt-bindings
>> [v23,2/7] arm64: dts: mt8183: add svs device information
>> [v23,3/7] soc: mediatek: SVS: introduce MTK SVS engine
>> [v23,4/7] soc: mediatek: SVS: add monitor mode
>> [v23,5/7] soc: mediatek: SVS: add debug commands
>> [v23,6/7] dt-bindings: soc: mediatek: add mt8192 svs dt-bindings
>> [v23,7/7] soc: mediatek: SVS: add mt8192 SVS GPU driver
>>
>> .../bindings/soc/mediatek/mtk-svs.yaml | 91 +
>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 16 +
>> drivers/soc/mediatek/Kconfig | 10 +
>> drivers/soc/mediatek/Makefile | 1 +
>> drivers/soc/mediatek/mtk-svs.c | 2398 +++++++++++++++++
>> 5 files changed, 2516 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml
>> create mode 100644 drivers/soc/mediatek/mtk-svs.c
>>
>
> Hello,
> the entire series has got reviews, and this has already reached 23 iterations.
> I personally have no more complaints about this one.
>
> Does anyone have any KO comments about this series?
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
I haven't reviewed closely since much earlier versions, but reviewing it
again now, I think this series is in good shape now. Thank you Angelo
for all of your detailed reviews.
Also thank you Roger for your persistence and dedication on getting this
feature upstream. It has been a long road, but you've stuck with it.
Kevin
prev parent reply other threads:[~2022-03-18 16:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 6:39 [PATCH v23 0/7] soc: mediatek: SVS: introduce MTK SVS Roger Lu
2022-02-21 6:39 ` [PATCH v23 1/7] dt-bindings: soc: mediatek: add mtk svs dt-bindings Roger Lu
2022-02-22 9:27 ` AngeloGioacchino Del Regno
2022-02-21 6:39 ` [PATCH v23 2/7] arm64: dts: mt8183: add svs device information Roger Lu
2022-02-22 9:27 ` AngeloGioacchino Del Regno
2022-02-21 6:39 ` [PATCH v23 3/7] soc: mediatek: SVS: introduce MTK SVS engine Roger Lu
2022-02-21 6:39 ` [PATCH v23 4/7] soc: mediatek: SVS: add monitor mode Roger Lu
2022-02-21 6:39 ` [PATCH v23 5/7] soc: mediatek: SVS: add debug commands Roger Lu
2022-02-22 9:27 ` AngeloGioacchino Del Regno
2022-02-21 6:39 ` [PATCH v23 6/7] dt-bindings: soc: mediatek: add mt8192 svs dt-bindings Roger Lu
2022-02-22 9:27 ` AngeloGioacchino Del Regno
2022-02-21 6:39 ` [PATCH v23 7/7] soc: mediatek: SVS: add mt8192 SVS GPU driver Roger Lu
2022-03-02 14:35 ` [PATCH v23 0/7] soc: mediatek: SVS: introduce MTK SVS AngeloGioacchino Del Regno
2022-03-18 16:48 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hlex7p5q5.fsf@baylibre.com \
--to=khilman@kernel.org \
--cc=Angus.Lin@mediatek.com \
--cc=Charles.Yang@mediatek.com \
--cc=HenryC.Chen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Xiaoqing.Liu@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@google.com \
--cc=eballetbo@gmail.com \
--cc=fan.chen@mediatek.com \
--cc=jia-wei.chang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=nm@ti.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=roger.lu@mediatek.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).