From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E88C7C433FE for ; Fri, 18 Mar 2022 16:48:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239354AbiCRQtZ (ORCPT ); Fri, 18 Mar 2022 12:49:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239353AbiCRQtY (ORCPT ); Fri, 18 Mar 2022 12:49:24 -0400 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F17B213DFC for ; Fri, 18 Mar 2022 09:48:04 -0700 (PDT) Received: by mail-pg1-f175.google.com with SMTP id 6so5423994pgg.0 for ; Fri, 18 Mar 2022 09:48:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=UiwMNQAcJybAKewEM0dZcEYqnf9WKLLDT9V2nDkKi3Y=; b=qNXUmcGE9rsSzJEpwKzaMdTnqKVai/MSPsAKk/+MjGysCH8+5gWjdTRNQt+KT526O6 WajBAblQX+S6ZIB8SCSxv3kxJxEeKGJi8e2ZJ2uGHx5eiwcuJL1zPFRYGkvwzp6hjJ9f V4bvodVsG79rHjiaviLATXI4IdmD9vPN7S+3vbSbo7CFTRdM6x5tMPZ1CAbltMGK+Tv5 XzA6D7mnJsrnd2UWlD9cxxT6tvYFNQozEYKNd9AXVMIxbytST2xK0a6jGo8s27/GmMZv 1tb+mg9pxkJO2pBeRd7Twp32uDIxSWVhGXY7VV90lxmA6Jw7AJ6GA6XrrALX3Ru4JIKY RkVw== X-Gm-Message-State: AOAM532zwwH2SUsHfZQMh7g00Segg3wX+6c2rOamRSMBaKHZxibXUNyv avxn+dD3A9cNdCMkWuCdlW6P+g== X-Google-Smtp-Source: ABdhPJwwVK19S8VwNYG9iLz/w3CUg34rZ/2OYsNz+NiHLrH99YHMdqQhKsiphPx4pIEeAHDV0b6ogQ== X-Received: by 2002:a63:7b57:0:b0:382:2edd:fcc4 with SMTP id k23-20020a637b57000000b003822eddfcc4mr2914667pgn.559.1647622084331; Fri, 18 Mar 2022 09:48:04 -0700 (PDT) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id oa12-20020a17090b1bcc00b001bf430c3909sm13497665pjb.32.2022.03.18.09.48.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Mar 2022 09:48:03 -0700 (PDT) From: Kevin Hilman To: AngeloGioacchino Del Regno , Roger Lu , Matthias Brugger , Enric Balletbo Serra , Rob Herring , Nicolas Boichat , Stephen Boyd , Philipp Zabel Cc: Fan Chen , HenryC Chen , Xiaoqing Liu , Charles Yang , Angus Lin , Mark Rutland , Nishanth Menon , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com, Guenter Roeck , Jia-wei Chang Subject: Re: [PATCH v23 0/7] soc: mediatek: SVS: introduce MTK SVS In-Reply-To: <60613d10-f7fc-03ea-900f-4255ebe0d5aa@collabora.com> References: <20220221063939.14969-1-roger.lu@mediatek.com> <60613d10-f7fc-03ea-900f-4255ebe0d5aa@collabora.com> Date: Fri, 18 Mar 2022 09:48:02 -0700 Message-ID: <7hlex7p5q5.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org AngeloGioacchino Del Regno writes: > Il 21/02/22 07:39, Roger Lu ha scritto: >> The Smart Voltage Scaling(SVS) engine is a piece of hardware >> which calculates suitable SVS bank voltages to OPP voltage table. >> Then, DVFS driver could apply those SVS bank voltages to PMIC/Buck >> when receiving OPP_EVENT_ADJUST_VOLTAGE. >> >> 1. SVS driver uses OPP adjust event in [1] to update OPP table voltage part. >> 2. SVS driver gets thermal/GPU device by node [2][3] and CPU device by get_cpu_device(). >> After retrieving subsys device, SVS driver calls device_link_add() to make sure probe/suspend callback priority. >> >> [1] https://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git/commit/?h=opp/linux-next&id=25cb20a212a1f989385dfe23230817e69c62bee5 >> [2] https://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git/commit/?h=opp/linux-next&id=b325ce39785b1408040d90365a6ab1aa36e94f87 >> [3] https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/commit/?h=v5.16-next/dts64&id=a8168cebf1bca1b5269e8a7eb2626fb76814d6e2 >> >> change since v22: >> - Make "svsb_volt = max(svsb->volt[i] + temp_voffset, svsb->vmin);" become one line. >> - Remove voffset read/write commands for better system safety. >> - Add more comments on @turn_freq_base. >> >> Roger Lu (7): >> [v23,1/7] dt-bindings: soc: mediatek: add mtk svs dt-bindings >> [v23,2/7] arm64: dts: mt8183: add svs device information >> [v23,3/7] soc: mediatek: SVS: introduce MTK SVS engine >> [v23,4/7] soc: mediatek: SVS: add monitor mode >> [v23,5/7] soc: mediatek: SVS: add debug commands >> [v23,6/7] dt-bindings: soc: mediatek: add mt8192 svs dt-bindings >> [v23,7/7] soc: mediatek: SVS: add mt8192 SVS GPU driver >> >> .../bindings/soc/mediatek/mtk-svs.yaml | 91 + >> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 16 + >> drivers/soc/mediatek/Kconfig | 10 + >> drivers/soc/mediatek/Makefile | 1 + >> drivers/soc/mediatek/mtk-svs.c | 2398 +++++++++++++++++ >> 5 files changed, 2516 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml >> create mode 100644 drivers/soc/mediatek/mtk-svs.c >> > > Hello, > the entire series has got reviews, and this has already reached 23 iterations. > I personally have no more complaints about this one. > > Does anyone have any KO comments about this series? Reviewed-by: Kevin Hilman I haven't reviewed closely since much earlier versions, but reviewing it again now, I think this series is in good shape now. Thank you Angelo for all of your detailed reviews. Also thank you Roger for your persistence and dedication on getting this feature upstream. It has been a long road, but you've stuck with it. Kevin