Re: [PATCH] ARM: dts: omap4-panda-a4: Add missing model and compatible properties

[Kevin Hilman <khilman@kernel.org>]

Hi Tom,

Tom Rini <trini@konsulko.com> writes:

> When moving the model and compatible properties out of the common
> Pandaboard files and in to the specific boards, the omap4-panda-a4
> file wasn't updated as well and so has lacked a model and compatible
> entry ever since.
>
> Fixes: a1a57abaaf82 ("ARM: dts: omap4-panda: Fix model and SoC family details")
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---

Checkpatch tells me:

 WARNING: DT compatible string "ti,omap4-panda-a4" appears un-documented

So I think Documentation/devicetree/bindings/arm/ti/omap.yaml needs an
update too.  (and note the binding update should be a separate patch[1])

> Given how long this has been broken it's entirely plausible no a4
> hardware even exists anymore and so dropping this file instead makes
> sense. I only found this because scripts/make_fit.py crashed on these
> properties being missing.

If keeping it is just this binding update, then I'd say we keep it, but
if it gets any more paninful to maintain, I'm also not going to argue
very hard to keep it.

Kevin

[1] From:  Documentation/devicetree/bindings/submitting-patches.rst

  1) The Documentation/ and include/dt-bindings/ portion of the patch should
     be a separate patch. The preferred subject prefix for binding patches is::

       "dt-bindings: <binding dir>: ..."

> Cc: Nishanth Menon <nm@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: linux-omap@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
>  arch/arm/boot/dts/ti/omap/omap4-panda-a4.dts | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/ti/omap/omap4-panda-a4.dts b/arch/arm/boot/dts/ti/omap/omap4-panda-a4.dts
> index 8fd076e5d1b0..4b8bfd0188ad 100644
> --- a/arch/arm/boot/dts/ti/omap/omap4-panda-a4.dts
> +++ b/arch/arm/boot/dts/ti/omap/omap4-panda-a4.dts
> @@ -7,6 +7,11 @@
>  #include "omap443x.dtsi"
>  #include "omap4-panda-common.dtsi"
>  
> +/ {
> +	model = "TI OMAP4 PandaBoard (A4)";
> +	compatible = "ti,omap4-panda-a4", "ti,omap4-panda", "ti,omap4430", "ti,omap4";
> +};
> +
>  /* Pandaboard Rev A4+ have external pullups on SCL & SDA */
>  &dss_hdmi_pins {
>  	pinctrl-single,pins = <
> -- 
> 2.43.0