From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs Date: Thu, 27 Aug 2015 17:24:13 -0700 Message-ID: <7hmvxc45w2.fsf@deeprootsystems.com> References: <1440487486-6154-1-git-send-email-wxt@rock-chips.com> <1440487486-6154-5-git-send-email-wxt@rock-chips.com> <7hfv37axhj.fsf@deeprootsystems.com> <7htwrn6l7g.fsf@deeprootsystems.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: (Dmitry Torokhov's message of "Tue, 25 Aug 2015 16:47:58 -0700") Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Torokhov Cc: Doug Anderson , Caesar Wang , Heiko =?utf-8?Q?St=C3=BCbner?= , Ulf Hansson , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , Tomasz Figa , "linux-kernel@vger.kernel.org" , Kumar Gala , Russell King , Rob Herring , Arnd Bergmann , Linus Walleij , Ian Campbell , "devicetree@vger.kernel.org" , "jinkun.hong" List-Id: devicetree@vger.kernel.org Dmitry Torokhov writes: > On Tue, Aug 25, 2015 at 3:45 PM, Kevin Hilman wrote: >> Doug Anderson writes: >> >>> To put things in a >>> concrete way, for pd_vio we'd go through the entire device tree >>> ourselves and find all properties that look like "power-domains = >>> <&power RK3288_PD_VIO>;". We'd then find the parent of those >>> properties and look for a property named "clocks". We'd then iterate >>> over all those clocks and turn those on. Did I get that right? >> >> ... but you make it sound like more work than it is. The genpd already >> keeps a list of devices that refer to the power domain. In fact, the >> genpd 'attach' method can be platform-specific, so could be used to keep >> track of a list (or a subset) of clocks which are needed for reset. > > That is not really workable: the attach and detach happen in > probe/remove path; if you do not have driver for the device you will > miss the clocks for it. And in my proposal, I suggested that clocks without drivers are good candidates to list in the domain, with the caveat that the be called out (documented) as being device clocks that are missing a driver, so when a driver shows up they can be moved accordingly, and in a way that actually describes the hardware. > And the quirk of this SoC is that we need to > turn all clocks during domain transition, regardless of whether there > is a driver for all devices. I understand. And that "quirk" is not unique to rockchip socs. Kevin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html