From: Kevin Hilman <khilman@kernel.org>
To: "jinkun.hong" <jinkun.hong@rock-chips.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Grant Likely <grant.likely@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Randy Dunlap <rdunlap@infradead.org>,
linux-doc@vger.kernel.org, dianders@chromium.org,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH v2 0/3] ARM: rk3288 : Add PM Domain support
Date: Wed, 01 Oct 2014 09:51:06 -0700 [thread overview]
Message-ID: <7hoatvvimd.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1411899774-8484-1-git-send-email-jinkun.hong@rock-chips.com> (jinkun hong's message of "Sun, 28 Sep 2014 03:22:51 -0700")
+Geert, Ulf
"jinkun.hong" <jinkun.hong@rock-chips.com> writes:
> From: "jinkun.hong" <jinkun.hong@rock-chips.com>
>
> Use PM Domain framework to manage the clock.
Which clock? This changelog needs a more thorough description. Also,
with this series alone, it's not clear how the power-domain transitions
ever happen, since I don't see any devices hooked up to your power
domains, or do I see your platform using runtime PM. In order for this
to be reviewed properely, it's important for reviewers to be able to see
how this PM domain support will be used.
Also, remember that the DT is supposed to reflect the hardware, not the
design choices of linux drivers. Because of that, it's a little
surprising to see clocks as properties of a power domain because clocks
are usually properties of devices.
I suggest you have a look at the sh-mobile implementation of DT-based
power domains by Geert[1], which shows how he's hooking up device clocks.
Kevin
[1] http://marc.info/?l=linux-pm&m=141166256415448&w=2
next prev parent reply other threads:[~2014-10-01 16:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-28 10:22 [PATCH v2 0/3] ARM: rk3288 : Add PM Domain support jinkun.hong
2014-09-28 10:22 ` [PATCH v2 1/3] power-domain: add power domain drivers for Rockchip platform jinkun.hong
[not found] ` <1411899774-8484-1-git-send-email-jinkun.hong-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-09-28 10:22 ` [PATCH v2 2/3] dt-bindings: add document of Rockchip power domain jinkun.hong
2014-09-28 10:22 ` [PATCH v2 3/3] ARM: dts: add rk3288 power-domain node jinkun.hong
2014-10-01 16:51 ` Kevin Hilman [this message]
2014-10-01 20:07 ` [PATCH v2 0/3] ARM: rk3288 : Add PM Domain support Doug Anderson
2014-10-01 20:25 ` Kevin Hilman
2014-10-02 9:47 ` Grygorii Strashko
2014-10-02 15:36 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hoatvvimd.fsf@deeprootsystems.com \
--to=khilman@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=geert+renesas@glider.be \
--cc=grant.likely@linaro.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jinkun.hong@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).