* [PATCH] ARM: dts: ti: am437x-l4: remove autoidle for UART
@ 2024-12-20 22:35 Judith Mendez
2024-12-21 11:16 ` Sukrut Bellary
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Judith Mendez @ 2024-12-20 22:35 UTC (permalink / raw)
To: Tony Lindgren, Kevin Hilman
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-omap,
devicetree, linux-kernel, Sukrut Bellary, Bin Liu
According to the TRM [0] in 21.5.1.42 UART_SYSC Register,
the autoidle bit should not be set for UART, so remove the
appropriate SYSC_OMAP2_AUTOIDLE flag.
[0] https://www.ti.com/lit/ug/spruhl7i/spruhl7i.pdf
Signed-off-by: Judith Mendez <jm@ti.com>
---
arch/arm/boot/dts/ti/omap/am437x-l4.dtsi | 18 ++++++------------
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi b/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi
index 824b9415ebbe9..fd4634f8c6293 100644
--- a/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi
+++ b/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi
@@ -180,8 +180,7 @@ target-module@9000 { /* 0x44e09000, ap 16 04.0 */
<0x9058 0x4>;
reg-names = "rev", "sysc", "syss";
ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
- SYSC_OMAP2_SOFTRESET |
- SYSC_OMAP2_AUTOIDLE)>;
+ SYSC_OMAP2_SOFTRESET)>;
ti,sysc-sidle = <SYSC_IDLE_FORCE>,
<SYSC_IDLE_NO>,
<SYSC_IDLE_SMART>,
@@ -698,8 +697,7 @@ target-module@22000 { /* 0x48022000, ap 8 0a.0 */
<0x22058 0x4>;
reg-names = "rev", "sysc", "syss";
ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
- SYSC_OMAP2_SOFTRESET |
- SYSC_OMAP2_AUTOIDLE)>;
+ SYSC_OMAP2_SOFTRESET)>;
ti,sysc-sidle = <SYSC_IDLE_FORCE>,
<SYSC_IDLE_NO>,
<SYSC_IDLE_SMART>,
@@ -726,8 +724,7 @@ target-module@24000 { /* 0x48024000, ap 10 1c.0 */
<0x24058 0x4>;
reg-names = "rev", "sysc", "syss";
ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
- SYSC_OMAP2_SOFTRESET |
- SYSC_OMAP2_AUTOIDLE)>;
+ SYSC_OMAP2_SOFTRESET)>;
ti,sysc-sidle = <SYSC_IDLE_FORCE>,
<SYSC_IDLE_NO>,
<SYSC_IDLE_SMART>,
@@ -1385,8 +1382,7 @@ target-module@a6000 { /* 0x481a6000, ap 40 16.0 */
<0xa6058 0x4>;
reg-names = "rev", "sysc", "syss";
ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
- SYSC_OMAP2_SOFTRESET |
- SYSC_OMAP2_AUTOIDLE)>;
+ SYSC_OMAP2_SOFTRESET)>;
ti,sysc-sidle = <SYSC_IDLE_FORCE>,
<SYSC_IDLE_NO>,
<SYSC_IDLE_SMART>,
@@ -1413,8 +1409,7 @@ target-module@a8000 { /* 0x481a8000, ap 42 20.0 */
<0xa8058 0x4>;
reg-names = "rev", "sysc", "syss";
ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
- SYSC_OMAP2_SOFTRESET |
- SYSC_OMAP2_AUTOIDLE)>;
+ SYSC_OMAP2_SOFTRESET)>;
ti,sysc-sidle = <SYSC_IDLE_FORCE>,
<SYSC_IDLE_NO>,
<SYSC_IDLE_SMART>,
@@ -1441,8 +1436,7 @@ target-module@aa000 { /* 0x481aa000, ap 44 12.0 */
<0xaa058 0x4>;
reg-names = "rev", "sysc", "syss";
ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
- SYSC_OMAP2_SOFTRESET |
- SYSC_OMAP2_AUTOIDLE)>;
+ SYSC_OMAP2_SOFTRESET)>;
ti,sysc-sidle = <SYSC_IDLE_FORCE>,
<SYSC_IDLE_NO>,
<SYSC_IDLE_SMART>,
--
2.47.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: ti: am437x-l4: remove autoidle for UART
2024-12-20 22:35 [PATCH] ARM: dts: ti: am437x-l4: remove autoidle for UART Judith Mendez
@ 2024-12-21 11:16 ` Sukrut Bellary
2025-01-06 23:07 ` Kevin Hilman
2025-01-06 23:45 ` Kevin Hilman
2 siblings, 0 replies; 4+ messages in thread
From: Sukrut Bellary @ 2024-12-21 11:16 UTC (permalink / raw)
To: Judith Mendez
Cc: Tony Lindgren, Kevin Hilman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-omap, devicetree, linux-kernel, Bin Liu
On Fri, Dec 20, 2024 at 04:35:23PM -0600, Judith Mendez wrote:
> According to the TRM [0] in 21.5.1.42 UART_SYSC Register,
> the autoidle bit should not be set for UART, so remove the
> appropriate SYSC_OMAP2_AUTOIDLE flag.
>
> [0] https://www.ti.com/lit/ug/spruhl7i/spruhl7i.pdf
> Signed-off-by: Judith Mendez <jm@ti.com>
> ---
> arch/arm/boot/dts/ti/omap/am437x-l4.dtsi | 18 ++++++------------
> 1 file changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi b/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi
> index 824b9415ebbe9..fd4634f8c6293 100644
> --- a/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/am437x-l4.dtsi
> @@ -180,8 +180,7 @@ target-module@9000 { /* 0x44e09000, ap 16 04.0 */
> <0x9058 0x4>;
> reg-names = "rev", "sysc", "syss";
> ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
> - SYSC_OMAP2_SOFTRESET |
> - SYSC_OMAP2_AUTOIDLE)>;
> + SYSC_OMAP2_SOFTRESET)>;
> ti,sysc-sidle = <SYSC_IDLE_FORCE>,
> <SYSC_IDLE_NO>,
> <SYSC_IDLE_SMART>,
> @@ -698,8 +697,7 @@ target-module@22000 { /* 0x48022000, ap 8 0a.0 */
> <0x22058 0x4>;
> reg-names = "rev", "sysc", "syss";
> ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
> - SYSC_OMAP2_SOFTRESET |
> - SYSC_OMAP2_AUTOIDLE)>;
> + SYSC_OMAP2_SOFTRESET)>;
> ti,sysc-sidle = <SYSC_IDLE_FORCE>,
> <SYSC_IDLE_NO>,
> <SYSC_IDLE_SMART>,
> @@ -726,8 +724,7 @@ target-module@24000 { /* 0x48024000, ap 10 1c.0 */
> <0x24058 0x4>;
> reg-names = "rev", "sysc", "syss";
> ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
> - SYSC_OMAP2_SOFTRESET |
> - SYSC_OMAP2_AUTOIDLE)>;
> + SYSC_OMAP2_SOFTRESET)>;
> ti,sysc-sidle = <SYSC_IDLE_FORCE>,
> <SYSC_IDLE_NO>,
> <SYSC_IDLE_SMART>,
> @@ -1385,8 +1382,7 @@ target-module@a6000 { /* 0x481a6000, ap 40 16.0 */
> <0xa6058 0x4>;
> reg-names = "rev", "sysc", "syss";
> ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
> - SYSC_OMAP2_SOFTRESET |
> - SYSC_OMAP2_AUTOIDLE)>;
> + SYSC_OMAP2_SOFTRESET)>;
> ti,sysc-sidle = <SYSC_IDLE_FORCE>,
> <SYSC_IDLE_NO>,
> <SYSC_IDLE_SMART>,
> @@ -1413,8 +1409,7 @@ target-module@a8000 { /* 0x481a8000, ap 42 20.0 */
> <0xa8058 0x4>;
> reg-names = "rev", "sysc", "syss";
> ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
> - SYSC_OMAP2_SOFTRESET |
> - SYSC_OMAP2_AUTOIDLE)>;
> + SYSC_OMAP2_SOFTRESET)>;
> ti,sysc-sidle = <SYSC_IDLE_FORCE>,
> <SYSC_IDLE_NO>,
> <SYSC_IDLE_SMART>,
> @@ -1441,8 +1436,7 @@ target-module@aa000 { /* 0x481aa000, ap 44 12.0 */
> <0xaa058 0x4>;
> reg-names = "rev", "sysc", "syss";
> ti,sysc-mask = <(SYSC_OMAP2_ENAWAKEUP |
> - SYSC_OMAP2_SOFTRESET |
> - SYSC_OMAP2_AUTOIDLE)>;
> + SYSC_OMAP2_SOFTRESET)>;
> ti,sysc-sidle = <SYSC_IDLE_FORCE>,
> <SYSC_IDLE_NO>,
> <SYSC_IDLE_SMART>,
> --
> 2.47.1
>
Looks good to me.
Reviewed-by: Sukrut Bellary <sbellary@baylibre.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: ti: am437x-l4: remove autoidle for UART
2024-12-20 22:35 [PATCH] ARM: dts: ti: am437x-l4: remove autoidle for UART Judith Mendez
2024-12-21 11:16 ` Sukrut Bellary
@ 2025-01-06 23:07 ` Kevin Hilman
2025-01-06 23:45 ` Kevin Hilman
2 siblings, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2025-01-06 23:07 UTC (permalink / raw)
To: Judith Mendez, Tony Lindgren, Kevin Hilman
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-omap,
devicetree, linux-kernel, Sukrut Bellary, Bin Liu
Judith Mendez <jm@ti.com> writes:
> According to the TRM [0] in 21.5.1.42 UART_SYSC Register,
> the autoidle bit should not be set for UART, so remove the
> appropriate SYSC_OMAP2_AUTOIDLE flag.
>
> [0] https://www.ti.com/lit/ug/spruhl7i/spruhl7i.pdf
> Signed-off-by: Judith Mendez <jm@ti.com>
Just curious, does this fix any particular usecase for you?
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: ti: am437x-l4: remove autoidle for UART
2024-12-20 22:35 [PATCH] ARM: dts: ti: am437x-l4: remove autoidle for UART Judith Mendez
2024-12-21 11:16 ` Sukrut Bellary
2025-01-06 23:07 ` Kevin Hilman
@ 2025-01-06 23:45 ` Kevin Hilman
2 siblings, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2025-01-06 23:45 UTC (permalink / raw)
To: Tony Lindgren, Kevin Hilman, Judith Mendez
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-omap,
devicetree, linux-kernel, Sukrut Bellary, Bin Liu
On Fri, 20 Dec 2024 16:35:23 -0600, Judith Mendez wrote:
> According to the TRM [0] in 21.5.1.42 UART_SYSC Register,
> the autoidle bit should not be set for UART, so remove the
> appropriate SYSC_OMAP2_AUTOIDLE flag.
>
> [0] https://www.ti.com/lit/ug/spruhl7i/spruhl7i.pdf
>
>
> [...]
Applied, thanks!
[1/1] ARM: dts: ti: am437x-l4: remove autoidle for UART
commit: f098253378c5c163b1e5450050ca5f12fc3082e7
Best regards,
--
Kevin Hilman <khilman@baylibre.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-01-06 23:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-20 22:35 [PATCH] ARM: dts: ti: am437x-l4: remove autoidle for UART Judith Mendez
2024-12-21 11:16 ` Sukrut Bellary
2025-01-06 23:07 ` Kevin Hilman
2025-01-06 23:45 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox