devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
	Christian Hewitt <christianshewitt@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] soc: amlogic: meson-gx-socinfo: Fix S905X3 and S905D3 ID's
Date: Mon, 29 Jun 2020 16:20:37 -0700	[thread overview]
Message-ID: <7hv9j9jw6y.fsf@baylibre.com> (raw)
In-Reply-To: <8757c066-2590-ff24-ebcc-2a9508fd9968@baylibre.com>

Neil Armstrong <narmstrong@baylibre.com> writes:

> On 09/06/2020 10:13, Christian Hewitt wrote:
>> Correct the SoC revision and package bits/mask values for S905D3/X3 to detect
>> a wider range of observed SoC IDs, and tweak sort order for A311D/S922X.
>> 
>> S905X3 05 0000 0101  (SEI610 initial devices)
>> S905X3 10 0001 0000  (ODROID-C4 and recent Android boxes)
>> S905X3 50 0101 0000  (SEI610 later revisions)
>> S905D3 04 0000 0100  (VIM3L devices in kernelci)
>> S905D3 b0 1011 0000  (VIM3L initial production)
>> 
>> Fixes commit c9cc9bec36d0 ("soc: amlogic: meson-gx-socinfo: Add SM1 and S905X3 IDs")
>> Suggested-by: Neil Armstrong <narmstrong@baylibre.com>
>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
>> ---
>>  drivers/soc/amlogic/meson-gx-socinfo.c | 8 +++++---
>>  1 file changed, 5 insertions(+), 3 deletions(-)
>> 
>> diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c
>> index 01fc0d20a70d..6f54bd832c8b 100644
>> --- a/drivers/soc/amlogic/meson-gx-socinfo.c
>> +++ b/drivers/soc/amlogic/meson-gx-socinfo.c
>> @@ -66,10 +66,12 @@ static const struct meson_gx_package_id {
>>  	{ "A113D", 0x25, 0x22, 0xff },
>>  	{ "S905D2", 0x28, 0x10, 0xf0 },
>>  	{ "S905X2", 0x28, 0x40, 0xf0 },
>> -	{ "S922X", 0x29, 0x40, 0xf0 },
>>  	{ "A311D", 0x29, 0x10, 0xf0 },
>> -	{ "S905X3", 0x2b, 0x5, 0xf },
>> -	{ "S905D3", 0x2b, 0xb0, 0xf0 },
>> +	{ "S922X", 0x29, 0x40, 0xf0 },
>> +	{ "S905D3", 0x2b, 0x4, 0xf5 },
>> +	{ "S905X3", 0x2b, 0x5, 0xf5 },
>> +	{ "S905X3", 0x2b, 0x10, 0x3f },
>> +	{ "S905D3", 0x2b, 0x30, 0x3f },
>>  	{ "A113L", 0x2c, 0x0, 0xf8 },
>>  };
>>  
>> 
>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>

Queued as a fix for v5.8,

Thanks,

Kevin

      reply	other threads:[~2020-06-29 23:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09  8:13 [PATCH v2] soc: amlogic: meson-gx-socinfo: Fix S905X3 and S905D3 ID's Christian Hewitt
2020-06-22  7:58 ` Neil Armstrong
2020-06-29 23:20   ` Kevin Hilman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7hv9j9jw6y.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=christianshewitt@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=narmstrong@baylibre.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).