* [PATCH] arm64: dts: meson-gxl-s905d-phicomm-n1: add status LED
@ 2019-03-12 8:33 Chuanhong Guo
2019-03-12 8:59 ` Neil Armstrong
0 siblings, 1 reply; 4+ messages in thread
From: Chuanhong Guo @ 2019-03-12 8:33 UTC (permalink / raw)
To: devicetree
Cc: Rob Herring, Mark Rutland, Kevin Hilman, linux-amlogic,
linux-kernel, Chuanhong Guo
There is a white LED on the front panel behind the logo and the
manufacturer uses that LED to indicate network and USB drive status.
Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
---
.../boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
index 9a8a8a7e4b53..b5667f1fb2c8 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
@@ -14,6 +14,16 @@
cvbs-connector {
status = "disabled";
};
+
+ leds {
+ compatible = "gpio-leds";
+
+ status {
+ label = "n1:white:status";
+ gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>;
+ default-state = "on";
+ };
+ };
};
&cvbs_vdac_port {
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: meson-gxl-s905d-phicomm-n1: add status LED
2019-03-12 8:33 [PATCH] arm64: dts: meson-gxl-s905d-phicomm-n1: add status LED Chuanhong Guo
@ 2019-03-12 8:59 ` Neil Armstrong
2019-03-12 10:29 ` Chuanhong Guo
2019-03-14 18:08 ` Kevin Hilman
0 siblings, 2 replies; 4+ messages in thread
From: Neil Armstrong @ 2019-03-12 8:59 UTC (permalink / raw)
To: Chuanhong Guo, devicetree
Cc: Mark Rutland, Kevin Hilman, linux-kernel, Rob Herring,
linux-amlogic
Hi Chuanhong,
On 12/03/2019 09:33, Chuanhong Guo wrote:
> There is a white LED on the front panel behind the logo and the
> manufacturer uses that LED to indicate network and USB drive status.
>
> Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
> ---
> .../boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
> index 9a8a8a7e4b53..b5667f1fb2c8 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
> @@ -14,6 +14,16 @@
> cvbs-connector {
> status = "disabled";
> };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + status {
> + label = "n1:white:status";
> + gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>;
> + default-state = "on";
> + };
> + };
> };
>
> &cvbs_vdac_port {
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
BTW, do you know if it's possible to have a sample of the Phicomm N1
in order to be added in kernelci ?
Neil
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: meson-gxl-s905d-phicomm-n1: add status LED
2019-03-12 8:59 ` Neil Armstrong
@ 2019-03-12 10:29 ` Chuanhong Guo
2019-03-14 18:08 ` Kevin Hilman
1 sibling, 0 replies; 4+ messages in thread
From: Chuanhong Guo @ 2019-03-12 10:29 UTC (permalink / raw)
To: Neil Armstrong
Cc: devicetree, Mark Rutland, Kevin Hilman, linux-kernel, Rob Herring,
linux-amlogic
Hi!
On Tue, Mar 12, 2019 at 4:59 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
> [...]
> BTW, do you know if it's possible to have a sample of the Phicomm N1
> in order to be added in kernelci ?
It's easy to purchase one in China and second-handed ones are dirt
cheap, but I don't think it's available worldwide.
I'm not familiar with world-wide shipping or exporting stuff so I
can't help much here.
>
> Neil
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: meson-gxl-s905d-phicomm-n1: add status LED
2019-03-12 8:59 ` Neil Armstrong
2019-03-12 10:29 ` Chuanhong Guo
@ 2019-03-14 18:08 ` Kevin Hilman
1 sibling, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2019-03-14 18:08 UTC (permalink / raw)
To: Neil Armstrong, Chuanhong Guo, devicetree
Cc: Mark Rutland, linux-kernel, Rob Herring, linux-amlogic
Neil Armstrong <narmstrong@baylibre.com> writes:
> Hi Chuanhong,
>
> On 12/03/2019 09:33, Chuanhong Guo wrote:
>> There is a white LED on the front panel behind the logo and the
>> manufacturer uses that LED to indicate network and USB drive status.
>>
>> Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
>> ---
>> .../boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
>> index 9a8a8a7e4b53..b5667f1fb2c8 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
>> @@ -14,6 +14,16 @@
>> cvbs-connector {
>> status = "disabled";
>> };
>> +
>> + leds {
>> + compatible = "gpio-leds";
>> +
>> + status {
>> + label = "n1:white:status";
>> + gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>;
>> + default-state = "on";
>> + };
>> + };
>> };
>>
>> &cvbs_vdac_port {
>>
>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Queued for v5.2 with Neil's tag (branch: v5.2/dt64)
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-14 18:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-12 8:33 [PATCH] arm64: dts: meson-gxl-s905d-phicomm-n1: add status LED Chuanhong Guo
2019-03-12 8:59 ` Neil Armstrong
2019-03-12 10:29 ` Chuanhong Guo
2019-03-14 18:08 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).