From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: net: renesas,ethertsn: Add bindings for Ethernet TSN
Date: Tue, 21 Nov 2023 13:53:47 +0100 [thread overview]
Message-ID: <8005f686-c4e5-487d-8bcc-4f057ee059aa@linaro.org> (raw)
In-Reply-To: <ZVymJF2dd7XssGaQ@oden.dyn.berto.se>
On 21/11/2023 13:44, Niklas Söderlund wrote:
>>
>>>
>>> I looked at the generic properties {rx,tx}-internal-delay-ps but they
>>> are of int type. So I opted for a vendor specific bool property. Do you
>>> think a better route is to use the generic property and force the value
>>> to be either 0 or the typical delay?
>>>
>>>> Why this is property of a board (not SoC)?
>>>
>>> I'm sorry I don't understand this question.
>>
>> Why setting internal delay is specific to a board, not to a SoC? Why
>> each board would need to configure it? On which parts of hardware on the
>> board does this depend?
>
> Ahh, I think I understand. It is per board as I understand the
> documentation. It depends on the electrical characteristics of the
> board.
>
> Maybe updating the description would help, how about?
>
> Enable internal Rx clock delay. Typically 1.8ns but depends on
> electrical characteristics of the board.
Yes, this looks fine.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-21 12:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 16:07 [PATCH] dt-bindings: net: renesas,ethertsn: Add bindings for Ethernet TSN Niklas Söderlund
2023-11-21 7:45 ` Krzysztof Kozlowski
2023-11-21 8:00 ` Geert Uytterhoeven
2023-11-21 8:40 ` Krzysztof Kozlowski
2023-11-21 8:45 ` Geert Uytterhoeven
2023-11-21 12:11 ` Niklas Söderlund
2023-11-21 12:10 ` Niklas Söderlund
2023-11-21 12:20 ` Krzysztof Kozlowski
2023-11-21 12:44 ` Niklas Söderlund
2023-11-21 12:53 ` Krzysztof Kozlowski [this message]
2023-11-21 16:11 ` Geert Uytterhoeven
2023-11-21 16:32 ` Niklas Söderlund
2023-11-21 19:53 ` Andrew Lunn
2023-11-22 7:40 ` Geert Uytterhoeven
2023-11-22 13:57 ` Andrew Lunn
2023-11-22 15:41 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8005f686-c4e5-487d-8bcc-4f057ee059aa@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).