From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 267B0C4332F for ; Mon, 17 Oct 2022 21:45:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230226AbiJQVo7 (ORCPT ); Mon, 17 Oct 2022 17:44:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229930AbiJQVoj (ORCPT ); Mon, 17 Oct 2022 17:44:39 -0400 Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE244804B2 for ; Mon, 17 Oct 2022 14:36:49 -0700 (PDT) Received: by mail-qv1-xf2b.google.com with SMTP id f14so8222273qvo.3 for ; Mon, 17 Oct 2022 14:36:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DUAbd7PmeJKBiJfQ07eVu5bQpKJMvb43G13KF7OIkwo=; b=HeL05hhHMdsOAK+qg566sPPBkN6kgIt7z+lVILK03xEGxC67ABaOs2Lh1pMpFZV/YA 91FAEGaiA2/ksquylfiEnw4m4AmpxG4viyyFwEnP63sF6HK0lZRuTUUwTQmKCncQYLlR 4SZjtioDWUKjirZPCk+DeiRzVUL4RHn5l0Pb8TBFxCUbV7/lEvlo8t2y6rg+pQa1w609 0i8yVd7H7oQCQDgYAJP6tm3C0PEaI6ciH6cx6LvTckrGfxzC5RtFfG4G4w0096fN9Gv4 ZZOwsnMRovkUyd3v9szJB+bS0xfLY7KiK3EOh0wVZEUg2kraxs/WtglCixV1gtBsHGBg Po4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DUAbd7PmeJKBiJfQ07eVu5bQpKJMvb43G13KF7OIkwo=; b=U2l43ema9HRQfFQKIYBe+YYK5mCJQQUrBCVcvPmz/vmu4az9dqJiUaFXhZ/szb0+EP XPJL6WASvBoTmVB4cBWwGAb31hriOHkHd7L6fLwbSXeR2cr1K8QFBgfZxDPj+Pr0oypC U1XcqZPqdTsdUnHunlc8mssRnlIeVbsun3+6IfVOIYUpEa6eyjz1xtsU4fF9f9Dh5OT0 rHdbe7iwqHQ5pW+qOVhsMJT4PM558h6rcYeZN2lWPe5oMgYa4DcUwfAwjrPKWge3DqSb 8SRVET0hLgWLDaPZMSXwtlncfkKfEXDfg6sAzswIsxDMDfyWapV/XvR8pioc7x4DICPD 3how== X-Gm-Message-State: ACrzQf14JH0IbBzYDH6ZzFE9kFk7KOOiJNNcE095vEvwZ/l2LVTpEXPe zopxzCsOjpnIFnRftgzSbxNeOQ== X-Google-Smtp-Source: AMsMyM7Hq8eHA8t8F9sJIwUeFLpaRZKfzg8HsGEaKLND4kBmFRrQQqTzpfWNlEDdv4nF9gO3bweJxg== X-Received: by 2002:ad4:574c:0:b0:4b1:87b5:c0dd with SMTP id q12-20020ad4574c000000b004b187b5c0ddmr10242320qvx.68.1666042608973; Mon, 17 Oct 2022 14:36:48 -0700 (PDT) Received: from [192.168.10.124] (pool-72-83-177-149.washdc.east.verizon.net. [72.83.177.149]) by smtp.gmail.com with ESMTPSA id y8-20020ac81288000000b00398a7c860c2sm639937qti.4.2022.10.17.14.36.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Oct 2022 14:36:48 -0700 (PDT) Message-ID: <801c902d-4e1a-6ddc-e050-afdc2514e687@linaro.org> Date: Mon, 17 Oct 2022 17:36:46 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH 2/5] dmaengine: qcom: gpi: document preferred SM6350 binding Content-Language: en-US To: Richard Acayan , Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Melody Olvera References: <20221015140447.55221-1-krzysztof.kozlowski@linaro.org> <20221015140447.55221-3-krzysztof.kozlowski@linaro.org> <20221017212320.4960-1-mailingradian@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20221017212320.4960-1-mailingradian@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/10/2022 17:23, Richard Acayan wrote: >> Devices with ee offset of 0x10000 should rather bind with SM6350 >> compatible, so the list will not unnecessarily grow for compatible >> devices. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> drivers/dma/qcom/gpi.c | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c >> index f8e19e6e6117..061add832295 100644 >> --- a/drivers/dma/qcom/gpi.c >> +++ b/drivers/dma/qcom/gpi.c >> @@ -2286,13 +2286,14 @@ static int gpi_probe(struct platform_device *pdev) >> } >> >> static const struct of_device_id gpi_of_match[] = { >> - { .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 }, >> { .compatible = "qcom,sdm845-gpi-dma", .data = (void *)0x0 }, >> { .compatible = "qcom,sm6350-gpi-dma", .data = (void *)0x10000 }, >> /* >> - * Deprecated, devices with ee_offset = 0 should use sdm845-gpi-dma as >> - * fallback and not need their own entries here. > > This comment is from the dependency series [1]. Why would we need to add it just > to remove it here? I was not notified that the dependency was applied anywhere > (except as a base for other series) so it's not set in stone. Let's just drop > the original patch that this comment originates from to prevent needlessly > adding and removing the same lines at once. I don't remove the comment, I re-phrase it to be better suited for final code. Best regards, Krzysztof