devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: sabiya.d@mistralsolutions.com, nm@ti.com, vigneshr@ti.com,
	kristo@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, linus.walleij@linaro.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Dasnavis Sabiya <sabiya.d@ti.com>
Subject: Re: [PATCH 2/2] arch: arm64: dts: Add support for AM69 Starter Kit
Date: Thu, 19 Jan 2023 14:36:00 +0100	[thread overview]
Message-ID: <802ae1e3-8046-675d-cf4e-d3468604a3e8@linaro.org> (raw)
In-Reply-To: <20230119132958.124435-3-sabiya.d@ti.com>

On 19/01/2023 14:29, sabiya.d@mistralsolutions.com wrote:
> From: Dasnavis Sabiya <sabiya.d@ti.com>
> 
> AM69 Starter Kit is a single board designed for TI AM69 SOC that
> provides advanced system integration in automotive ADAS applications,
> autonomous mobile robot and edge AI applications. The SOC comprises
> of Cortex-A72s in dual clusters, lockstep capable dual Cortex-R5F MCUs,
> Vision Processing Accelerators (VPAC) with Image Signal Processor (ISP)
> and multiple vision assist accelerators, Depth and Motion Processing
> Accelerators (DMPAC), Deep-learning Matrix Multiply Accelerator(MMA)
> and C7x floating point vector DSP
> 
> AM69 SK supports the following interfaces:
>        * 32 GB LPDDR4 RAM
>        * x1 Gigabit Ethernet interface
>        * x3 USB 3.0 Type-A ports
>        * x1 USB 3.0 Type-C port
>        * x1 UHS-1 capable micro-SD card slot
>        * x4 MCAN instances
>        * 32 GB eMMC Flash
>        * 512 Mbit OSPI flash
>        * x2 Display connectors
>        * x1 PCIe M.2 M Key
>        * x1 PCIe M.2 E Key
>        * x1 4L PCIe Card Slot
>        * x3 CSI2 Camera interface
>        * 40-pin Raspberry Pi header
> 
> Add initial support for the AM69 SK board.

Thank you for your patch. There is something to discuss/improve.

> 
> Design Files: https://www.ti.com/lit/zip/SPRR466
> TRM: https://www.ti.com/lit/zip/spruj52
> 
> Signed-off-by: Dasnavis Sabiya <sabiya.d@ti.com>
> ---
>  arch/arm64/boot/dts/ti/Makefile       |   1 +
>  arch/arm64/boot/dts/ti/k3-am69-sk.dts | 180 ++++++++++++++++++++++++++
>  2 files changed, 181 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/ti/k3-am69-sk.dts
> 
> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
> index e7c2c7dd0b25..04b1a7611096 100644
> --- a/arch/arm64/boot/dts/ti/Makefile
> +++ b/arch/arm64/boot/dts/ti/Makefile
> @@ -20,6 +20,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-j7200-common-proc-board.dtb
>  
>  dtb-$(CONFIG_ARCH_K3) += k3-j721s2-common-proc-board.dtb
>  
> +dtb-$(CONFIG_ARCH_K3) += k3-am69-sk.dtb

I was told the order of entries here is "time of release". Is it
correct? This is the order you want to keep here and am69-sk was
released after j721s2-common-proc-board but before j784s4-evm?

>  dtb-$(CONFIG_ARCH_K3) += k3-j784s4-evm.dtb
>  


Best regards,
Krzysztof


  reply	other threads:[~2023-01-19 13:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19 13:29 [PATCH 0/2] Add initial support for AM69 Starter Kit sabiya.d
2023-01-19 13:29 ` [PATCH 1/2] dt-bindings: arm: ti: Add binding " sabiya.d
2023-01-19 13:34   ` Krzysztof Kozlowski
2023-01-19 13:29 ` [PATCH 2/2] arch: arm64: dts: Add support " sabiya.d
2023-01-19 13:36   ` Krzysztof Kozlowski [this message]
2023-01-20 10:32     ` Vignesh Raghavendra
2023-01-23  7:28       ` Dasnavis Sabiya
2023-01-25 13:14         ` Dasnavis Sabiya
2023-01-25 14:09           ` Vignesh Raghavendra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=802ae1e3-8046-675d-cf4e-d3468604a3e8@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=sabiya.d@mistralsolutions.com \
    --cc=sabiya.d@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).