From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>,
agross@kernel.org, bjorn.andersson@linaro.org,
lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz,
tiwai@suse.com, rohitkr@codeaurora.org,
linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
Subject: Re: [PATCH v7 4/6] Asoc: qcom: lpass:Update lpaif_dmactl members order
Date: Tue, 29 Sep 2020 10:02:04 +0100 [thread overview]
Message-ID: <8059e28b-39c5-d71b-3e22-357d4d121f7e@linaro.org> (raw)
In-Reply-To: <1601286811-25962-5-git-send-email-srivasam@codeaurora.org>
On 28/09/2020 10:53, Srinivasa Rao Mandadapu wrote:
> From: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
>
> Update the lpaif_dmactl struct members order to match
> HDMI reg map members sequence. Separate Interface reg map
> as it is used for I2S control but not for HDMI control,
> to make use of bulk API, which makes code more readable.
>
> Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> sound/soc/qcom/lpass-platform.c | 8 ++++----
> sound/soc/qcom/lpass.h | 6 +++---
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/sound/soc/qcom/lpass-platform.c b/sound/soc/qcom/lpass-platform.c
> index e7cf4e5..db0d959 100644
> --- a/sound/soc/qcom/lpass-platform.c
> +++ b/sound/soc/qcom/lpass-platform.c
> @@ -71,13 +71,13 @@ static int lpass_platform_alloc_dmactl_fields(struct device *dev,
> rd_dmactl = drvdata->rd_dmactl;
> wr_dmactl = drvdata->wr_dmactl;
>
> - rval = devm_regmap_field_bulk_alloc(dev, map, &rd_dmactl->bursten,
> - &v->rdma_bursten, 6);
> + rval = devm_regmap_field_bulk_alloc(dev, map, &rd_dmactl->intf,
> + &v->rdma_intf, 6);
> if (rval)
> return rval;
>
> - return devm_regmap_field_bulk_alloc(dev, map, &wr_dmactl->bursten,
> - &v->wrdma_bursten, 6);
> + return devm_regmap_field_bulk_alloc(dev, map, &wr_dmactl->intf,
> + &v->wrdma_intf, 6);
> }
>
> static int lpass_platform_pcmops_open(struct snd_soc_component *component,
> diff --git a/sound/soc/qcom/lpass.h b/sound/soc/qcom/lpass.h
> index 51c9991..7089d4c 100644
> --- a/sound/soc/qcom/lpass.h
> +++ b/sound/soc/qcom/lpass.h
> @@ -31,9 +31,9 @@ struct lpaif_i2sctl {
>
>
> struct lpaif_dmactl {
> + struct regmap_field *intf;
> struct regmap_field *bursten;
> struct regmap_field *wpscnt;
> - struct regmap_field *intf;
> struct regmap_field *fifowm;
> struct regmap_field *enable;
> struct regmap_field *dyncclk;
> @@ -110,17 +110,17 @@ struct lpass_variant {
> struct reg_field bitwidth;
>
> /* RD_DMA Register fields */
> + struct reg_field rdma_intf;
> struct reg_field rdma_bursten;
> struct reg_field rdma_wpscnt;
> - struct reg_field rdma_intf;
> struct reg_field rdma_fifowm;
> struct reg_field rdma_enable;
> struct reg_field rdma_dyncclk;
>
> /* WR_DMA Register fields */
> + struct reg_field wrdma_intf;
> struct reg_field wrdma_bursten;
> struct reg_field wrdma_wpscnt;
> - struct reg_field wrdma_intf;
> struct reg_field wrdma_fifowm;
> struct reg_field wrdma_enable;
> struct reg_field wrdma_dyncclk;
>
next prev parent reply other threads:[~2020-09-29 9:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 9:53 [PATCH v7 0/6] Qualcomm's lpass-hdmi ASoC driver to support audio over dp port Srinivasa Rao Mandadapu
2020-09-28 9:53 ` [PATCH v7 1/6] ASoC: Add sc7180-lpass binding header hdmi define Srinivasa Rao Mandadapu
2020-09-28 9:53 ` [PATCH v7 2/6] ASoC: dt-bindings: Add dt binding for lpass hdmi Srinivasa Rao Mandadapu
2020-09-28 9:53 ` [PATCH v7 3/6] Asoc:qcom:lpass-cpu:Update dts property read API Srinivasa Rao Mandadapu
2020-09-29 9:01 ` Srinivas Kandagatla
2020-09-28 9:53 ` [PATCH v7 4/6] Asoc: qcom: lpass:Update lpaif_dmactl members order Srinivasa Rao Mandadapu
2020-09-29 9:02 ` Srinivas Kandagatla [this message]
2020-09-28 9:53 ` [PATCH v7 5/6] ASoC: qcom: Add support for lpass hdmi driver Srinivasa Rao Mandadapu
2020-09-29 9:02 ` Srinivas Kandagatla
2020-09-29 14:29 ` Srinivasa Rao Mandadapu
2020-09-28 9:53 ` [PATCH v7 6/6] ASoC: qcom: sc7180: Add support for audio over DP Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8059e28b-39c5-d71b-3e22-357d4d121f7e@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=srivasam@codeaurora.org \
--cc=tiwai@suse.com \
--cc=vsujithk@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).