From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4B8BC4727F for ; Tue, 29 Sep 2020 09:02:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49A182075E for ; Tue, 29 Sep 2020 09:02:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DO2qH4j9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727832AbgI2JCI (ORCPT ); Tue, 29 Sep 2020 05:02:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727838AbgI2JCI (ORCPT ); Tue, 29 Sep 2020 05:02:08 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B854DC0613D1 for ; Tue, 29 Sep 2020 02:02:07 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id g4so4459596wrs.5 for ; Tue, 29 Sep 2020 02:02:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/A7aNSm3cdga1VZaRmJ05RVUoqJfegPG8Brx5Ka5WGE=; b=DO2qH4j9aG8GSMVOMJ14DMKAPsmoURMiGLFD2cXSDA+rFlLU3RUvtnvdUxZyjZEWoE hUeYHGiMv8zI1FteDtN13NQhpVyXsnmryARr5aCX2SHQHKCrHFpsy5qcO3ciYgZZFlKD mF+l+dH3+fPIN80ML1NEtd0s11s9qbDf7Qw4Ffik03AAY7VthUMA0Rac32EEO8lN4q59 zqxhasPIrscXXMn/fuRFuWHNk3ams+hG4O1HKi39AjFLCJYLObl/2mm5qG60vub7QOPY mdG/7YxhwmCg5aSRqrr9IkdXIIHMXmE9KlKEWOJyHPnYO+v56Rf+xHaeFfEUPzEVrgvR 0J/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/A7aNSm3cdga1VZaRmJ05RVUoqJfegPG8Brx5Ka5WGE=; b=Bc4A1hWOQw9j3D9IZcQ3twraKNzLfsTetlO05gVuUd/h3fhx/ZjYI01RlSj1sVaa6y TRuYGcJFtDEAEXDiCOc3b1PIkllmr2OVVOwVy7cFE1I25Y/oXsfqQMosq4gomPPj9KuV 1JY0K1pwbZ4sdEBbMZ8nRgAh5yHF02dwjbHWilVRK49gZKan7/A2ToerRHDLjZszPlb5 /DvT+g580eX19srYVIMjv5e8h58wqD4nRDCGJ5lgAa9z0ZDpqP0Nt4OfkPE9O3e3xiCr YoWTYLLSmVaLHpkdScL7/byXxhZ+Ra6u0oeCduC0A+IKRA8pMQaVL3spfiIdlTRiXlkn /JYg== X-Gm-Message-State: AOAM531YkvFVQAy9jfVICRe5m+sHgnVkAHMVMsi2yt3S/SqOhnKUY88v 2cdP1Ot1flMDpuTL4n4PAehXsw== X-Google-Smtp-Source: ABdhPJzQKyr2tz/uJM9dF4tNkWt1NDTUANm3HQkHYNhXxHlAf3Gx3/6+nhwrh7etV+RVPrZyqC407Q== X-Received: by 2002:adf:c188:: with SMTP id x8mr3236405wre.201.1601370126436; Tue, 29 Sep 2020 02:02:06 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id u12sm5199475wrt.81.2020.09.29.02.02.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Sep 2020 02:02:05 -0700 (PDT) Subject: Re: [PATCH v7 4/6] Asoc: qcom: lpass:Update lpaif_dmactl members order To: Srinivasa Rao Mandadapu , agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com, rohitkr@codeaurora.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: V Sujith Kumar Reddy References: <1601286811-25962-1-git-send-email-srivasam@codeaurora.org> <1601286811-25962-5-git-send-email-srivasam@codeaurora.org> From: Srinivas Kandagatla Message-ID: <8059e28b-39c5-d71b-3e22-357d4d121f7e@linaro.org> Date: Tue, 29 Sep 2020 10:02:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1601286811-25962-5-git-send-email-srivasam@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/09/2020 10:53, Srinivasa Rao Mandadapu wrote: > From: V Sujith Kumar Reddy > > Update the lpaif_dmactl struct members order to match > HDMI reg map members sequence. Separate Interface reg map > as it is used for I2S control but not for HDMI control, > to make use of bulk API, which makes code more readable. > > Signed-off-by: V Sujith Kumar Reddy > Signed-off-by: Srinivasa Rao Mandadapu Reviewed-by: Srinivas Kandagatla > --- > sound/soc/qcom/lpass-platform.c | 8 ++++---- > sound/soc/qcom/lpass.h | 6 +++--- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/sound/soc/qcom/lpass-platform.c b/sound/soc/qcom/lpass-platform.c > index e7cf4e5..db0d959 100644 > --- a/sound/soc/qcom/lpass-platform.c > +++ b/sound/soc/qcom/lpass-platform.c > @@ -71,13 +71,13 @@ static int lpass_platform_alloc_dmactl_fields(struct device *dev, > rd_dmactl = drvdata->rd_dmactl; > wr_dmactl = drvdata->wr_dmactl; > > - rval = devm_regmap_field_bulk_alloc(dev, map, &rd_dmactl->bursten, > - &v->rdma_bursten, 6); > + rval = devm_regmap_field_bulk_alloc(dev, map, &rd_dmactl->intf, > + &v->rdma_intf, 6); > if (rval) > return rval; > > - return devm_regmap_field_bulk_alloc(dev, map, &wr_dmactl->bursten, > - &v->wrdma_bursten, 6); > + return devm_regmap_field_bulk_alloc(dev, map, &wr_dmactl->intf, > + &v->wrdma_intf, 6); > } > > static int lpass_platform_pcmops_open(struct snd_soc_component *component, > diff --git a/sound/soc/qcom/lpass.h b/sound/soc/qcom/lpass.h > index 51c9991..7089d4c 100644 > --- a/sound/soc/qcom/lpass.h > +++ b/sound/soc/qcom/lpass.h > @@ -31,9 +31,9 @@ struct lpaif_i2sctl { > > > struct lpaif_dmactl { > + struct regmap_field *intf; > struct regmap_field *bursten; > struct regmap_field *wpscnt; > - struct regmap_field *intf; > struct regmap_field *fifowm; > struct regmap_field *enable; > struct regmap_field *dyncclk; > @@ -110,17 +110,17 @@ struct lpass_variant { > struct reg_field bitwidth; > > /* RD_DMA Register fields */ > + struct reg_field rdma_intf; > struct reg_field rdma_bursten; > struct reg_field rdma_wpscnt; > - struct reg_field rdma_intf; > struct reg_field rdma_fifowm; > struct reg_field rdma_enable; > struct reg_field rdma_dyncclk; > > /* WR_DMA Register fields */ > + struct reg_field wrdma_intf; > struct reg_field wrdma_bursten; > struct reg_field wrdma_wpscnt; > - struct reg_field wrdma_intf; > struct reg_field wrdma_fifowm; > struct reg_field wrdma_enable; > struct reg_field wrdma_dyncclk; >