From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from server.couthit.com (server.couthit.com [162.240.164.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBAA9263C75; Wed, 3 Sep 2025 06:24:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=162.240.164.96 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756880665; cv=none; b=hnVTb7VlWeWpv8mUL064nHnbt2joMjP106RP0qZvU680y+8vViszws9O+MH6CQt7ganpOQJ03WH0oeGWUyGe0nRexkd9nH03+SwjdH7BRld3/ax7wEAq+psWKwlxON3KYc5N6rN2Wgu61FORB/JKT72Xo9QfbJSTQmpwRZz649g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756880665; c=relaxed/simple; bh=Iv7bNu8u4qg1R4rWSyiQsI+0IiNTLHdoRTQUkbCexds=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=Dq6b7GAirfyLUiL1vOLnKURo8RUFPa/Q4oiQwl/pp3nGlMGQ36zM6oQK3w/pQEXJcq020uG/3/oFUKiiNFpP4DA5c6yuiIy5PwgqjqDlEs723P4BP+WZHbFa76IJ99LosNJmLaF+bSanW1K9jzxjmPweLuEIGYgt3WsfJWPqHU4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=couthit.com; spf=pass smtp.mailfrom=couthit.com; dkim=pass (2048-bit key) header.d=couthit.com header.i=@couthit.com header.b=gEhSP1mt; arc=none smtp.client-ip=162.240.164.96 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=couthit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=couthit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=couthit.com header.i=@couthit.com header.b="gEhSP1mt" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=couthit.com ; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Subject: References:In-Reply-To:Message-ID:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=x4tCiHtEuBHcImWWTid6RD8zgtR1UUnyUWotA4DUPnM=; b=gEhSP1mtfUGcLZ09rC2smCtsK6 T0tSls0dAi/cgEHrDAQ2LfNb4+LPYu/okrLOXpML/Fx8NqGVNseED23x0c+pPTBE+s61KBJTuQMsx vfKgL62zMUIiQAb5NqJNiq7sBJVDEbXfIT7djkWNiiood2lMStN/Gtb3B6U5/j/Efxv4qYsuO9MTA +5zD/Qqn6N6+LkrSXIdWDMAVH2z4xda+9mPD5ljmN+u8e9ILp8jvh8wynTJsQDJ21+kZIMfi8jh4N 10u7WjZfgECckNcZYqHHVUv/wN5abRN8PXomVtoeRz/haH1Elo7TGKsC8VUgNGf3eYDZPs078izSY QvHEHZQw==; Received: from [122.175.9.182] (port=39230 helo=zimbra.couthit.local) by server.couthit.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1utgug-0000000AzlO-2Eye; Wed, 03 Sep 2025 02:24:11 -0400 Received: from zimbra.couthit.local (localhost [127.0.0.1]) by zimbra.couthit.local (Postfix) with ESMTPS id 715AC1782011; Wed, 3 Sep 2025 11:53:58 +0530 (IST) Received: from localhost (localhost [127.0.0.1]) by zimbra.couthit.local (Postfix) with ESMTP id 4B13717820F5; Wed, 3 Sep 2025 11:53:58 +0530 (IST) Received: from zimbra.couthit.local ([127.0.0.1]) by localhost (zimbra.couthit.local [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id MbJDssR--aGZ; Wed, 3 Sep 2025 11:53:58 +0530 (IST) Received: from zimbra.couthit.local (zimbra.couthit.local [10.10.10.103]) by zimbra.couthit.local (Postfix) with ESMTP id E63761782011; Wed, 3 Sep 2025 11:53:57 +0530 (IST) Date: Wed, 3 Sep 2025 11:53:57 +0530 (IST) From: Parvathi Pudi To: Md Danish Anwar Cc: parvathi , danishanwar , rogerq , andrew+netdev , davem , edumazet , kuba , pabeni , robh , krzk+dt , conor+dt , ssantosh , richardcochran , m-malladi , s hauer , afd , jacob e keller , horms , johan , m-karicheri2 , s-anna , glaroque , saikrishnag , kory maincent , diogo ivo , javier carrasco cruz , basharath , linux-arm-kernel , netdev , devicetree , linux-kernel , Vadim Fedorenko , ALOK TIWARI , Bastien Curutchet , pratheesh , Prajith Jayarajan , Vignesh Raghavendra , praneeth , srk , rogerq , krishna , pmohan , mohan Message-ID: <806290623.278790.1756880637551.JavaMail.zimbra@couthit.local> In-Reply-To: <1b892cde-bcdc-4a4e-83b7-35cc13eef8f4@ti.com> References: <20250822132758.2771308-1-parvathi@couthit.com> <20250822132758.2771308-3-parvathi@couthit.com> <1b892cde-bcdc-4a4e-83b7-35cc13eef8f4@ti.com> Subject: Re: [PATCH net-next v14 2/5] net: ti: icssm-prueth: Adds ICSSM Ethernet driver Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: Zimbra 8.8.15_GA_3968 (ZimbraWebClient - GC138 (Linux)/8.8.15_GA_3968) Thread-Topic: icssm-prueth: Adds ICSSM Ethernet driver Thread-Index: mF5rnq3mgVHUKrTfxh1Anq5GbFjbRg== X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.couthit.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - couthit.com X-Get-Message-Sender-Via: server.couthit.com: authenticated_id: smtp@couthit.com X-Authenticated-Sender: server.couthit.com: smtp@couthit.com X-Source: X-Source-Args: X-Source-Dir: Hi, >=20 > On 8/22/2025 6:55 PM, Parvathi Pudi wrote: >> From: Roger Quadros >>=20 >> Updates Kernel configuration to enable PRUETH driver and its dependencie= s >> along with makefile changes to add the new PRUETH driver. >>=20 >> Changes includes init and deinit of ICSSM PRU Ethernet driver including >> net dev registration and firmware loading for DUAL-MAC mode running on >> PRU-ICSS2 instance. >>=20 >> Changes also includes link handling, PRU booting, default firmware loadi= ng >> and PRU stopping using existing remoteproc driver APIs. >>=20 >> Signed-off-by: Roger Quadros >> Signed-off-by: Andrew F. Davis >> Signed-off-by: Basharath Hussain Khaja >> Signed-off-by: Parvathi Pudi >=20 > [ ... ] >=20 >> +=09/* get mac address from DT and set private and netdev addr */ >> +=09ret =3D of_get_ethdev_address(eth_node, ndev); >> +=09if (!is_valid_ether_addr(ndev->dev_addr)) { >> +=09=09eth_hw_addr_random(ndev); >> +=09=09dev_warn(prueth->dev, "port %d: using random MAC addr: %pM\n", >> +=09=09=09 port, ndev->dev_addr); >> +=09} >> +=09ether_addr_copy(emac->mac_addr, ndev->dev_addr); >> + >> +=09/* connect PHY */ >> +=09emac->phydev =3D of_phy_get_and_connect(ndev, eth_node, >> +=09=09=09=09=09 icssm_emac_adjust_link); >> +=09if (!emac->phydev) { >> +=09=09dev_dbg(prueth->dev, "PHY connection failed\n"); >> +=09=09ret =3D -EPROBE_DEFER; >> +=09=09goto free; >> +=09} >> + >=20 > Why are you returning EPROBE_DEFER here? If phy connection fails, you > should just return and fail the probe. That's what ICSSG driver does. >=20 > In drivers/net/ethernet/ti/icssg/icssg_prueth.c >=20 > 404 =E2=94=82 ndev->phydev =3D of_phy_connect(emac->ndev, emac->phy= _node, > 405 =E2=94=82 &emac_adjust_link, 0, > 406 =E2=94=82 emac->phy_if); > 407 =E2=94=82 if (!ndev->phydev) { > 408 =E2=94=82 dev_err(prueth->dev, "couldn't connect to phy %s\= n", > 409 =E2=94=82 emac->phy_node->full_name); > 410 =E2=94=82 return -ENODEV; > 411 =E2=94=82 } >=20 >=20 > Before phy connect you do `dev_warn(prueth->dev, "port %d: using random > MAC addr: %pM\n"` >=20 > If device is using random mac address, this will be printed, your phy > connect fails, you try probe again, print comes again, phy fails again > and so on ... >=20 > This results in system getting spammed with continuos prints of "using > random MAC addr" >=20 > I suggest if phy fails, let the probe fail don't do EPROBE_DEFER. >=20 > Saw this issue on few boards which has issue with ICSSG phy. >=20 Yes, we will check and address this in the next version. Thanks and Regards, Parvathi.