From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75EF7C43217 for ; Tue, 17 May 2022 09:11:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232719AbiEQJLr (ORCPT ); Tue, 17 May 2022 05:11:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244422AbiEQJLK (ORCPT ); Tue, 17 May 2022 05:11:10 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 976C521E34 for ; Tue, 17 May 2022 02:11:06 -0700 (PDT) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nqtEK-0000za-Qh; Tue, 17 May 2022 11:11:00 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: dri-devel@lists.freedesktop.org, Sascha Hauer , robh+dt@kernel.org, Krzysztof Kozlowski Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis , krzk+dt@kernel.org Subject: Re: [PATCH v2 1/3] dt-bindings: display: rockchip: make reg-names mandatory for VOP2 Date: Tue, 17 May 2022 11:10:59 +0200 Message-ID: <8064279.T7Z3S40VBb@diego> In-Reply-To: References: <20220511082109.1110043-1-s.hauer@pengutronix.de> <6824319.LvFx2qVVIh@phil> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Dienstag, 17. Mai 2022, 11:02:06 CEST schrieb Krzysztof Kozlowski: > On 14/05/2022 00:26, Heiko Stuebner wrote: > > Hi Rob, Krzysztof, > > > > Am Mittwoch, 11. Mai 2022, 10:21:07 CEST schrieb Sascha Hauer: > >> The VOP2 driver relies on reg-names properties, but these are not > >> documented. Add the missing documentation, make reg-names mandatory > >> and increase minItems to 2 as always both register spaces are needed. > >> > >> Signed-off-by: Sascha Hauer > > > > does this look ok now? > > Neither Rob nor me was Cced on original email, so I don't have it in my > mailbox... I would expect that scripts/get_maintainers.pl is a known tool. Rob wrote in the past that he's working off of the devicetree-patchwork, and has reviewed the binding yesterday [0]. But you're right, including all the maintainers get_maintainers.pl suggests would be better in the future. [0] https://lore.kernel.org/r/20220516151226.GA2653888-robh@kernel.org