Re: [PATCH v4 1/2] dt-bindings: iio: dac: add mcp4728.yaml

[Andrea Collamati <andrea.collamati@gmail.com>]

Sorry it's the first time I try to submit a driver.

So after your positive review I should add...

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

I will do in v5..

        Andrea


On 8/3/23 17:21, Conor Dooley wrote:
> On Thu, Aug 03, 2023 at 02:56:34PM +0200, Andrea Collamati wrote:
>> Add documentation for MCP4728
>>
>> Signed-off-by: Andrea Collamati <andrea.collamati@gmail.com>
> I gave you a reviewed-by on v3, is there a reason that you dropped it?
>
> Thanks,
> Conor.
>
>> ---
>>  .../bindings/iio/dac/microchip,mcp4728.yaml   | 49 +++++++++++++++++++
>>  1 file changed, 49 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml
>> new file mode 100644
>> index 000000000000..99831d7f1c16
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp4728.yaml
>> @@ -0,0 +1,49 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +
>> +$id: http://devicetree.org/schemas/iio/dac/microchip,mcp4728.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Microchip MCP4728 DAC
>> +
>> +maintainers:
>> +  - Andrea Collamati <andrea.collamati@gmail.com>
>> +
>> +description: |
>> +  MCP4728 is a quad channel, 12-bit voltage output
>> +  Digital-to-Analog Converter with non-volatile
>> +  memory and I2C compatible Serial Interface.
>> +  https://www.microchip.com/en-us/product/mcp4728
>> +
>> +properties:
>> +  compatible:
>> +    const: microchip,mcp4728
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  vdd-supply:
>> +    description: |
>> +      Provides both power and acts as the reference supply on the MCP4728
>> +      when Internal Vref is not selected.
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - vdd-supply
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    i2c {
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>> +        dac@60 {
>> +            compatible = "microchip,mcp4728";
>> +            reg = <0x60>;
>> +            vdd-supply = <&vdac_vdd>;
>> +        };
>> +    };
>> -- 
>> 2.34.1
>>