From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Marijn Suijten <marijn.suijten@somainline.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Luca Weiss <luca@z3ntu.xyz>, Adam Skladowski <a39.skl@gmail.com>,
Martin Botka <martin.botka@somainline.org>,
Jami Kettunen <jami.kettunen@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/6] arm64: dts: qcom: msm8976: Declare and use SDC1 pins
Date: Tue, 6 Feb 2024 19:58:50 +0100 [thread overview]
Message-ID: <808bd239-6a61-4932-ab91-3dcbe10a7a05@linaro.org> (raw)
In-Reply-To: <20240121-msm8976-dt-v2-4-7b186a02dc72@somainline.org>
On 21.01.2024 23:33, Marijn Suijten wrote:
> Add the pinctrl states for SDC1 and use them on sdhc_1.
>
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
> ---
[...]
> @@ -840,6 +890,11 @@ sdhc_1: mmc@7824900 {
> <&gcc GCC_SDCC1_APPS_CLK>,
> <&rpmcc RPM_SMD_XO_CLK_SRC>;
> clock-names = "iface", "core", "xo";
> +
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&sdc1_on_state>;
> + pinctrl-1 = <&sdc1_off_state>;
-names should go last
Konrad
next prev parent reply other threads:[~2024-02-06 18:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-21 22:33 [PATCH v2 0/6] arm64: dts: qcom: msm8956-loire: SDCard and USB support Marijn Suijten
2024-01-21 22:33 ` [PATCH v2 1/6] arm64: dts: qcom: pmi8950: Add USB vbus and id sensing nodes Marijn Suijten
2024-02-06 18:57 ` Konrad Dybcio
2024-01-21 22:33 ` [PATCH v2 2/6] arm64: dts: qcom: msm8956-loire: Add usb vbus and id extcons to ci-hdrc Marijn Suijten
2024-02-06 18:57 ` Konrad Dybcio
2024-01-21 22:33 ` [PATCH v2 3/6] arm64: dts: qcom: pmi8950: Add missing ADC channels Marijn Suijten
2024-01-21 22:33 ` [PATCH v2 4/6] arm64: dts: qcom: msm8976: Declare and use SDC1 pins Marijn Suijten
2024-02-06 18:58 ` Konrad Dybcio [this message]
2024-02-06 22:36 ` Marijn Suijten
2024-02-07 12:15 ` AngeloGioacchino Del Regno
2024-02-09 16:59 ` Konrad Dybcio
2024-01-21 22:33 ` [PATCH v2 5/6] arm64: dts: qcom: msm8976: Declare and use SDC2 pins Marijn Suijten
2024-01-21 22:33 ` [PATCH v2 6/6] arm64: dts: qcom: msm8956-loire: Add SD Card Detect to SDC2 pin states Marijn Suijten
2024-01-22 11:48 ` AngeloGioacchino Del Regno
2024-01-22 13:49 ` Marijn Suijten
2024-01-22 14:59 ` AngeloGioacchino Del Regno
2024-01-22 15:15 ` Marijn Suijten
2024-01-29 11:05 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=808bd239-6a61-4932-ab91-3dcbe10a7a05@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=a39.skl@gmail.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jami.kettunen@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).