From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB0BD3D39B; Tue, 2 Apr 2024 07:38:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712043495; cv=none; b=UWgIpkTRbypEa8HZidNX3CHWu+OyRrhBu6yPaOdXwE89QFI2Rvq5bb8Mqpra+SOnJ/VJQsakcowl1wJGlSYwTSQOEmc8moxejpv8cnKuNg88k5iqlf13lfJ/4duf8v1ImF7OgcYxpxfWLJyaabiUEfg6lHUtmKNZBU6UiQ3/Y+E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712043495; c=relaxed/simple; bh=TfkRnq5Iex/rUtVkNVsPycE3pm25lH41VYxu3rMQUOA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sUQorFgHvKI5oqnrMwrPMGcJgkzeUCUbGBZtACUJhmNuYqWTxU6PaEkgz4Q8y9Cpp2wzWknVFgwmIjOb0lavzaJQ+1W7Am/70r1nUw8cdX6icPzEuRd5gYjXr/GxTqCGLQyhCOI5vMt3JbGqXFfxSjqCF8Lp1cbvHPnoaSACH/o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=V7S6CQI9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="V7S6CQI9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C703C433F1; Tue, 2 Apr 2024 07:38:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712043495; bh=TfkRnq5Iex/rUtVkNVsPycE3pm25lH41VYxu3rMQUOA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=V7S6CQI93E3zwLQFAHvPkTOZroqxnXZLv+j98cTwbl0BfjL5riHoJJlkAWmqd/RzX QMGelJ3/TmSzX16VOatTUkmy/KgJ4pFHEMvETHPBid9Ud93Icownw9abE3svYuvIYF 4feje6sQtbq3Gl1YyBy1YA5xCyYLY8skgtD52QNgIS19gijoD9rCPvxdXDAAD8KOcS BBL8jMywvaTotqTRcIM48kKaFZYieUm7CwUSaYwblGSxXFVO511ITLIFcZtfgEvZFC EEie4rNsP8Q8SEcQLtqKg6gZIdANxMQTWe8OHLcY7d361v9PDIyWJbmDRbEUJ6Qf59 uQtLfckete3pQ== Message-ID: <80c4c37b-8c5c-4628-a455-fcccfc3b3730@kernel.org> Date: Tue, 2 Apr 2024 16:38:12 +0900 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 17/18] dt-bindings: pci: rockchip,rk3399-pcie-ep: Add ep-gpios property To: Krzysztof Kozlowski , Manivannan Sadhasivam , Lorenzo Pieralisi , Kishon Vijay Abraham I , Shawn Lin , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Rick Wertenbroek , Wilfred Mallawa , Niklas Cassel References: <20240330041928.1555578-1-dlemoal@kernel.org> <20240330041928.1555578-18-dlemoal@kernel.org> <518f04ea-7ff6-4568-be76-60276d18b209@linaro.org> <49ecab2e-8f36-47be-a1b0-1bb0089dab0f@kernel.org> <57d5d6ea-5fef-423c-9f85-5f295bfa4c5f@linaro.org> Content-Language: en-US From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <57d5d6ea-5fef-423c-9f85-5f295bfa4c5f@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/2/24 16:33, Krzysztof Kozlowski wrote: > On 02/04/2024 01:36, Damien Le Moal wrote: >> On 4/1/24 18:57, Krzysztof Kozlowski wrote: >>> On 01/04/2024 01:06, Damien Le Moal wrote: >>>> On 3/30/24 18:16, Krzysztof Kozlowski wrote: >>>>> On 30/03/2024 05:19, Damien Le Moal wrote: >>>>>> From: Wilfred Mallawa >>>>>> >>>>>> Describe the `ep-gpios` property which is used to map the PERST# input >>>>>> signal for endpoint mode. >>>>>> >>>>>> Signed-off-by: Wilfred Mallawa >>>>>> Signed-off-by: Damien Le Moal >>>>>> --- >>>>>> .../devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml | 3 +++ >>>>>> 1 file changed, 3 insertions(+) >>>>>> >>>>>> diff --git a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml >>>>>> index 6b62f6f58efe..9331d44d6963 100644 >>>>>> --- a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml >>>>>> +++ b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml >>>>>> @@ -30,6 +30,9 @@ properties: >>>>>> maximum: 32 >>>>>> default: 32 >>>>>> >>>>>> + ep-gpios: >>>>>> + description: Input GPIO configured for the PERST# signal. >>>>> >>>>> Missing maxItems. But more important: why existing property perst-gpios, >>>>> which you already have there in common schema, is not correct for this case? >>>> >>>> I am confused... Where do you find perst-gpios defined for the rk3399 ? >>>> Under Documentation/devicetree/bindings/pci/, the only schema I see using >>>> perst-gpios property are for the qcom (Qualcomm) controllers. >>> >>> You are right, it's so far only in Qualcomm. >>> >>>> The RC bindings for the rockchip rk3399 PCIe controller >>>> (pci/rockchip,rk3399-pcie.yaml) already define the ep-gpios property. So if >>> >>> Any reason why this cannot be named like GPIO? Is there already a user >>> of this in Linux kernel? Commit msg says nothing about this, so that's >>> why I would expect name matching the signal. >> >> The RC-mode PCIe controller node of the rk3399 DTS already defines the ep-gpios >> property for RC side PERST# signal handling. So we simply reused the exact same >> name to be consistent between RC and EP. I personnally have no preferences. If >> there is an effort to rename such signal with some preferred pattern, I will >> follow. For the EP node, there was no PERST signal handling in the driver and >> no property defined for it, so any name is fine. "perst-gpios" would indeed be >> a better name, but again, given that the RC controller node has ep-gpios, we >> reused that. What is your recommendation here ? > > Actually I don't know, perst and ep would work for me. If you do not > have code for this in the driver yet (nothing is shared between ep and > host), then maybe let's go with perst to match the actual name. That works for me. The other simple solution would be to move the RC node ep-gpios description to the common schema pci/rockchip,rk3399-pcie-common.yaml, maybe ? Otherwise, perst-gpios like the Qualcomm schemas would be nice too. > > Anyway, you need maxItems. I sent a patch for the other binding: > https://lore.kernel.org/all/20240401100058.15749-1-krzysztof.kozlowski@linaro.org/ Thanks for that. > > Best regards, > Krzysztof > -- Damien Le Moal Western Digital Research