From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38292C3DA7A for ; Fri, 6 Jan 2023 12:38:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232599AbjAFMip (ORCPT ); Fri, 6 Jan 2023 07:38:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232149AbjAFMip (ORCPT ); Fri, 6 Jan 2023 07:38:45 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98660687A8 for ; Fri, 6 Jan 2023 04:38:43 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id m3so988429wmq.0 for ; Fri, 06 Jan 2023 04:38:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OJ7xr6hqaFunxstN9Frwa743d6EY0RYUMvbu/BvcENU=; b=k533u49JmlzI9E0GmLi1/SbA4DHKKnuJLwcWPrk5dQCS8t7rkz+MHy08ABQhin/X/6 JgRoDBIY7EFHGJgc9dMEvwbhzTO0xbC3ALki8QJnhibyoI2nI9CwYpQcqCg9P/fjNqCs KOGaNGKYtv0TvGzekX+Rn0gYaHJa96u63r2TCFFwoG5i49iv8XvbV92w7kwe2FydP22z 7kn9AMzHk5eFhxiflGGLIWTzivhLMwSi6yQQpqwWwpjbXoQKRkw2MZsgbtZZ9iOmr5Qb IH6h6ZmVnSg3H5JJ2/HvwbK0bBIk4wLbn/xXWxNANNI6X1Kc37/4U42ZwinHarOws8PY bAjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OJ7xr6hqaFunxstN9Frwa743d6EY0RYUMvbu/BvcENU=; b=8CWLCc99I5GyR/9EGye9GLjO+Dzwzupg6QwtbR7lemiQ19h3Gg1C2Y8lQcxrzZpghd 7QuuIuI3289uadxyDEtqftjIOn2Uw951aOF1KnU9j7GXNI5hO8bA+XgX3SxxELd5Oba1 20bPX9SdyR2APZg6fLmqOHHtvtlmL5JV2PFnAdaH32C7x50Jkq9DIvv5tPX8HeyeLDXK nSrRQo7gxCBq4i2LGixmYMBLIvr49op8sa+YkHu5jcgUV3jNF682S8dTcjq0cHEB2E15 FRsTl//59Bu3ZQBhbpOoS2NjydiOMvvr01UNvAsGQiPZWVcnxCmtIB0JsDbHPa0xvXqL 9c/A== X-Gm-Message-State: AFqh2kpc/v8XwJ8S/3s8gpalvJLZXDfdNtABDW7+Hd4XX0D6Pxsl5RJl iiUVo69K5jQ9QirWn5FnNM4aiA== X-Google-Smtp-Source: AMrXdXuDF8odo1Q4/ENstUcn7M+3KtSn24l85y5PF2Bz6Wp1IzYdkylooKFh18FcHa+t5fjNy1Ng1A== X-Received: by 2002:a05:600c:5012:b0:3d3:5a4a:9103 with SMTP id n18-20020a05600c501200b003d35a4a9103mr38570557wmr.31.1673008722161; Fri, 06 Jan 2023 04:38:42 -0800 (PST) Received: from [192.168.1.102] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id s2-20020adff802000000b00241bd7a7165sm1025445wrp.82.2023.01.06.04.38.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jan 2023 04:38:41 -0800 (PST) Message-ID: <80c9fac7-36fe-293e-62f0-945515b8f481@linaro.org> Date: Fri, 6 Jan 2023 13:38:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 2/7] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names Content-Language: en-US To: Yanhong Wang , linux-riscv@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Richard Cochran , Andrew Lunn , Heiner Kallweit , Peter Geis References: <20230106030001.1952-1-yanhong.wang@starfivetech.com> <20230106030001.1952-3-yanhong.wang@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <20230106030001.1952-3-yanhong.wang@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/01/2023 03:59, Yanhong Wang wrote: > Some boards(such as StarFive VisionFive v2) require more than one value > which defined by resets property, so the original definition can not > meet the requirements. In order to adapt to different requirements, > adjust the maxitems number definition. > > Signed-off-by: Yanhong Wang > --- > .../devicetree/bindings/net/snps,dwmac.yaml | 36 ++++++++++++++----- > 1 file changed, 28 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index e26c3e76ebb7..f7693e8c8d6d 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -132,14 +132,6 @@ properties: > - pclk > - ptp_ref > > - resets: > - maxItems: 1 > - description: > - MAC Reset signal. > - > - reset-names: > - const: stmmaceth Do not remove properties from top-level properties. Instead these should have widest constraints which are further constrain in allOf:if:then. Here you should list items with minItems: 1. > - Best regards, Krzysztof