From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D68BC001DE for ; Mon, 7 Aug 2023 09:37:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229436AbjHGJhq (ORCPT ); Mon, 7 Aug 2023 05:37:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231604AbjHGJho (ORCPT ); Mon, 7 Aug 2023 05:37:44 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10B4710C0; Mon, 7 Aug 2023 02:37:42 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 7F62F7FD3; Mon, 7 Aug 2023 17:37:40 +0800 (CST) Received: from EXMBX061.cuchost.com (172.16.6.61) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 7 Aug 2023 17:37:40 +0800 Received: from [192.168.125.128] (113.72.146.246) by EXMBX061.cuchost.com (172.16.6.61) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 7 Aug 2023 17:37:39 +0800 Message-ID: <80d6ac43-2b78-97e4-9905-38bf8440ffb9@starfivetech.com> Date: Mon, 7 Aug 2023 17:33:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v1 2/5] ASoC: dt-bindings: snps,designware-i2s: Add StarFive JH7110 SoC support To: Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Maxim Kochetkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing CC: Jose Abreu , Paul Walmsley , Palmer Dabbelt , Albert Ou , Walker Chen , , , , References: <20230802084301.134122-1-xingyu.wu@starfivetech.com> <20230802084301.134122-3-xingyu.wu@starfivetech.com> <37a636dd-fbd8-d475-8814-e0cc6d5cc812@linaro.org> <12a9bfda-9c9f-6baf-3e5f-ce7cc7d79aee@starfivetech.com> Content-Language: en-US From: Xingyu Wu In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.146.246] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX061.cuchost.com (172.16.6.61) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023/8/7 17:17, Krzysztof Kozlowski wrote: > On 07/08/2023 11:03, Xingyu Wu wrote: >>>>> + - if: >>>> + properties: >>>> + compatible: >>>> + contains: >>>> + const: snps,designware-i2s >>>> + then: >>>> + properties: >>>> + clocks: >>>> + maxItems: 1 >>>> + clock-names: >>>> + maxItems: 1 >>>> + resets: >>>> + maxItems: 1 >>>> + else: >>>> + properties: >>>> + resets: >>>> + minItems: 2 >> >> The resets of TX0/TX1/RX on JH7110 SoC are mentioned in 'else' here. > > Ah, its fine. Clocks seem to be also constrained. OK, I will keep it here. > >> >>>> + - if: >>>> + properties: >>>> + compatible: >>>> + contains: >>>> + const: starfive,jh7110-i2stx0 >>>> + then: >>>> + properties: >>>> + clocks: >>>> + minItems: 5 >>> >>> Also maxItems >> >> Will add. >> >>> >>>> + clock-names: >>>> + minItems: 5 >>> >>> Also maxItems >> >> Will add. >> >>> >>> What about resets? 1 or 2 items? >> >> Mentioned it in the 'else'. >> Or do you mean I should drop the 'else' and add the resets in here? >> And is the same for TX1 and RX? > > It won't be easy to read... probably the binding should be split. > Anyway, it's fine as is, except the maxItems above. > So I will keep it and just add the maxItems in next version. Thanks, Xingyu Wu