From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC3E6CCA47B for ; Fri, 10 Jun 2022 09:51:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347493AbiFJJvo (ORCPT ); Fri, 10 Jun 2022 05:51:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347152AbiFJJvn (ORCPT ); Fri, 10 Jun 2022 05:51:43 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73FC7AEE28 for ; Fri, 10 Jun 2022 02:51:42 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id w27so34484647edl.7 for ; Fri, 10 Jun 2022 02:51:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Su/vdY6lGj+Pr3dmdikt3VdGnrhvMFnJcFP72Ow7dC4=; b=zgRwcmTAgD0viyAxwBer3iPOUi0MEbyLAPXlWR/pLQzcQhksejfo8DVt5Rp8mk8mkA mWFDWHE1c6WTvhN81Xke8gzP9TCiZyoJPZc+rwPr0H1yzVpPx88rLkPWHn8jRAqgvvuE 2d17ZSiKC1ioFftJYlL+dL7TfeEfjY7PLCSdMuuSKxvSxPXAn/kYPRlfOmktVPXgNAu2 InKcNJ9OgyscXNdxac+SDgTm8uQeGyJrdF5GqYQjWSjXhy8TMAkCriZwItIKBlMNuGm0 Spjfvoscvy/uBhozkRybtDbBFL2Ws+ZfSlvv7KB3+OOOeTCh6eC4W85byY1xuRUIASIC TkDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Su/vdY6lGj+Pr3dmdikt3VdGnrhvMFnJcFP72Ow7dC4=; b=ILtErBRQ6EuVgjEacHm7HVRV6mXxWikkUs9Kv66dmr07ydUyVIfjths2myBI/68X0v nX8CQcR1Px3qqPTYjbkhYgWkDY37f9zsyj/eCSU6cTylNYjXYzExLlbXblrARZkZb1A3 2CIEkkUPHONLpYDdJO+XGtnzX4JKiLlr1DDUjTFMf4Xj9smg2ndzvTFvoJzDHWUfzpru C1aQCj/bmoI1xJ+5z+If50ayu79GShHAcjVVP0i9zRXxMsxkySogzp5Ll5IBqNP5v9Gf Q5DQfBUPQoTw7oNCAN0eyLT/Md+g8MhHlVNvDVrP/K8he9R1JzG/qy+poKbvDoUT931H 1fyQ== X-Gm-Message-State: AOAM533WmvoXBo1YR/FsIp48KZFj5cPRhqU2/Y3hV6C3FRYH4N7FgjIN rI4iv/fX6BTye6EapMiyIyewSw== X-Google-Smtp-Source: ABdhPJyj6TklRqD3zDYQVccZ7hzIqwXHNLa/IvjlZmFFmrZBmG/TM9HKYw08cXo1RRXjvutTxqKtgA== X-Received: by 2002:a05:6402:1907:b0:42d:e90e:337 with SMTP id e7-20020a056402190700b0042de90e0337mr51038751edz.405.1654854701058; Fri, 10 Jun 2022 02:51:41 -0700 (PDT) Received: from [192.168.0.201] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id de46-20020a1709069bee00b0070f6855b90bsm9492759ejc.170.2022.06.10.02.51.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jun 2022 02:51:40 -0700 (PDT) Message-ID: <80f9c2d5-52d9-b03d-c272-ac475ae8c69e@linaro.org> Date: Fri, 10 Jun 2022 11:51:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 10/20] ARM: dts: nuvoton: add reset syscon property Content-Language: en-US To: Tomer Maimon Cc: Avi Fishman , Tali Perry , Joel Stanley , Patrick Venture , Nancy Yuen , Benjamin Fair , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Philipp Zabel , Greg KH , Daniel Lezcano , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Catalin Marinas , Will Deacon , Arnd Bergmann , Olof Johansson , Jiri Slaby , Shawn Guo , Bjorn Andersson , Geert Uytterhoeven , Marcel Ziswiler , Vinod Koul , Biju Das , Nobuhiro Iwamatsu , Robert Hancock , =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= , Lubomir Rintel , devicetree , Linux Kernel Mailing List , linux-clk , "open list:SERIAL DRIVERS" , LINUXWATCHDOG , Linux ARM References: <20220608095623.22327-1-tmaimon77@gmail.com> <20220608095623.22327-11-tmaimon77@gmail.com> <3aa70c91-d6d7-e2eb-9c45-a1fb0a5751ca@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/06/2022 23:30, Tomer Maimon wrote: > Hi Krzysztof, > > Thanks for your comments > > On Wed, 8 Jun 2022 at 13:07, Krzysztof Kozlowski > wrote: >> >> On 08/06/2022 11:56, Tomer Maimon wrote: >>> Add nuvoton,sysgcr syscon property to the reset >>> node to handle the general control registers. >> >> Wrong wrapping. > it will be very helpful if you could point me what wrong wrapped in > the commit message, is it the explanation or the header? or something > else? I pointed you last time. I pointed the exact line, exact rule you need to follow. I pointed it three times already and three times I said wrapping is wrong: https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 "The body of the explanation, line wrapped at 75 columns, which will be copied to the permanent changelog to describe this patch." Your wrapping is not at 75 columns and it causes the commit to be less readable, without any reason. Please follow Linux kernel coding style/rules. Best regards, Krzysztof