From: Florian Fainelli <f.fainelli@gmail.com>
To: Matthew Hagan <mnhagan88@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/3] ARM: dts: NSP: Add support for Cisco Meraki NSP devices
Date: Tue, 2 Jun 2020 14:55:32 -0700 [thread overview]
Message-ID: <80fb3020-22ee-26a4-0286-137b5388a0ab@gmail.com> (raw)
In-Reply-To: <cover.1591114003.git.mnhagan88@gmail.com>
Hi Matthew,
On 6/2/2020 9:11 AM, Matthew Hagan wrote:
> This patch set adds support for the Meraki MX64(W) and MX65(W) security
> devices. There are four devices in total, all using the same basic hardware.
>
> The MX64 series has five ethernet ports connected to the BCM SRAB. The MX65
> series has two ports conected to the SRAB, and two QCA8337 switches connected
> by SGMII to SRAB ports 4 and 5, each providing five additional ports.
>
> The W variants of these devices have two BCM43520s on the PCIe bus. On the
> non-wireless variants PCIe is inactive, hence separate dts files.
>
> 1/3 contains common bindings for both Meraki devices.
> 2/3 contains MX64 specific bindings.
> 3/3 contains MX65 specific bindings.
Glad to see those patches being submitted upstream to support those
devices, don't we need a change to arch/arm/boot/dts/Makefile to add
those DTS files to be built when ARCH_BCM_NSP is enabled?
>
> Note that Chris Packham's "[PATCH 2/2] ARM: dts: NSP: avoid unnecessary probe
> deferrals" is also necessary.
Humm, I am not sure this patch is really the way to go, but I have to
look at it again.
>
> Thanks,
> Matthew
>
> Matthew Hagan (3):
> ARM: dts: NSP: Add common bindings for Meraki MX64/65
> ARM: dts: NSP: Add support for Cisco Meraki MX64(W)
> ARM: dts: NSP: Add support for Cisco Meraki MX65(W)
>
> arch/arm/boot/dts/bcm958625-mx64.dts | 15 +
> arch/arm/boot/dts/bcm958625-mx64w.dts | 23 ++
> arch/arm/boot/dts/bcm958625-mx64x.dtsi | 136 ++++++++
> arch/arm/boot/dts/bcm958625-mx65.dts | 15 +
> arch/arm/boot/dts/bcm958625-mx65w.dts | 23 ++
> arch/arm/boot/dts/bcm958625-mx65x.dtsi | 321 +++++++++++++++++++
> arch/arm/boot/dts/bcm958625-mx6x-common.dtsi | 172 ++++++++++
> 7 files changed, 705 insertions(+)
> create mode 100644 arch/arm/boot/dts/bcm958625-mx64.dts
> create mode 100644 arch/arm/boot/dts/bcm958625-mx64w.dts
> create mode 100644 arch/arm/boot/dts/bcm958625-mx64x.dtsi
> create mode 100644 arch/arm/boot/dts/bcm958625-mx65.dts
> create mode 100644 arch/arm/boot/dts/bcm958625-mx65w.dts
> create mode 100644 arch/arm/boot/dts/bcm958625-mx65x.dtsi
> create mode 100644 arch/arm/boot/dts/bcm958625-mx6x-common.dtsi
>
--
Florian
prev parent reply other threads:[~2020-06-02 21:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 16:11 [PATCH 0/3] ARM: dts: NSP: Add support for Cisco Meraki NSP devices Matthew Hagan
2020-06-02 16:11 ` [PATCH 1/3] ARM: dts: NSP: Add common bindings for Meraki MX64/65 Matthew Hagan
2020-06-02 16:11 ` [PATCH 2/3] ARM: dts: NSP: Add support for Cisco Meraki MX64(W) Matthew Hagan
2020-06-02 16:11 ` [PATCH 3/3] ARM: dts: NSP: Add support for Cisco Meraki MX65(W) Matthew Hagan
2020-06-02 21:55 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80fb3020-22ee-26a4-0286-137b5388a0ab@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mnhagan88@gmail.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).