From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D772DC38145 for ; Wed, 7 Sep 2022 14:34:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229761AbiIGOd5 (ORCPT ); Wed, 7 Sep 2022 10:33:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230201AbiIGOdT (ORCPT ); Wed, 7 Sep 2022 10:33:19 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC1FA8983D; Wed, 7 Sep 2022 07:32:55 -0700 (PDT) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oVw6m-0006Sc-31; Wed, 07 Sep 2022 16:32:52 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: linus.walleij@linaro.org, Jianqun Xu Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org, Jianqun Xu Subject: Re: [PATCH 1/2] dt-bindings: gpio: rockchip: add clock-names Date: Wed, 07 Sep 2022 16:32:49 +0200 Message-ID: <8119974.jRhZ6ZUK3Y@diego> In-Reply-To: <20220902060426.2980951-2-jay.xu@rock-chips.com> References: <20220902060426.2980951-1-jay.xu@rock-chips.com> <20220902060426.2980951-2-jay.xu@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Freitag, 2. September 2022, 08:04:25 CEST schrieb Jianqun Xu: > Add 'clock-names' to the gpio dt node. so the driver could get clocks by > a const char id, this patch names the clock-names as > - 'bus': the apb clock for cpu to access the gpio controller > - 'db': the debounce clock for cpu to set debounce clock rate > > Since the old dt nodes may have no clock-names, this patch not make them > as part of 'required properties'. > > Signed-off-by: Jianqun Xu Acked-by: Heiko Stuebner > --- > .../devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > index affd823c881d..d43d4c71bebf 100644 > --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml > @@ -27,6 +27,12 @@ properties: > - description: APB interface clock source > - description: GPIO debounce reference clock source > > + clock-names: > + minItems: 1 > + items: > + - const: bus > + - const: db > + > gpio-ranges: true > > gpio-controller: true >