From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bharat Bhushan <bbhushan2@marvell.com>,
"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sunil Kovvuri Goutham <sgoutham@marvell.com>
Subject: Re: [EXT] Re: [PATCH 1/2 v7] dt-bindings: watchdog: marvell GTI system watchdog driver
Date: Tue, 9 May 2023 10:07:51 +0200 [thread overview]
Message-ID: <8119eec8-0190-b6a5-85a7-301bcb81b0c9@linaro.org> (raw)
In-Reply-To: <DM5PR1801MB1883175A2538B85FEF571B7AE3769@DM5PR1801MB1883.namprd18.prod.outlook.com>
On 09/05/2023 09:26, Bharat Bhushan wrote:
>>> +properties:
>>> + compatible:
>>> + oneOf:
>>> + - const: marvell,octeontx2-wdt
>>
>> Why is this alone? Judging by the enum below, octeontx2 is not specific.
>>
>>> + - items:
>>> + - enum:
>>> + - marvell,octeontx2-95xx-wdt
>>> + - marvell,octeontx2-96xx-wdt
>>> + - marvell,octeontx2-98xx-wdt
>>
>> We don't allow wildcards in general
>
> Marvell have octeontx2 series of processor which have watchdog timer.
> In 95xx,98xx,96xx are the processors in octeontx2 series of processor. So octeontx2-95xx is on soc, octeontx2-96xx is another and so on.
No, 95xx is not a processor. Otherwise please point me to exact product
datasheet. Hint: I checked it.
>
>>
>>> + - const: marvell,octeontx2-wdt
>>> + - const: marvell,cn10k-wdt
>>
>> Same question - why is this alone?
> Same here, Marvell have cn10k series of processors and cn10kx and cnf10kx are the processor in this series.
I don't understand how does it explain my concern. This is alone because
there are series of processors? How is that related?
>
> One of the difference between octeontx2 and cn10k series processor is number of timers available. Which within the available set of timers one of the timer is programmed to be watchdog timer.
Wrap your replies. It's difficult to read.
>
> Can you please propose how you want these compatible to be defined?
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml#L19
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-09 8:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 13:15 [PATCH 1/2 v7] dt-bindings: watchdog: marvell GTI system watchdog driver Bharat Bhushan
2023-05-08 13:15 ` [PATCH 2/2 v7] Watchdog: Add marvell GTI " Bharat Bhushan
2023-05-08 17:35 ` kernel test robot
2023-05-09 9:36 ` kernel test robot
2023-05-09 6:53 ` [PATCH 1/2 v7] dt-bindings: watchdog: marvell GTI system " Krzysztof Kozlowski
2023-05-09 7:26 ` [EXT] " Bharat Bhushan
2023-05-09 8:07 ` Krzysztof Kozlowski [this message]
2023-05-09 9:01 ` Bharat Bhushan
2023-05-09 13:06 ` Krzysztof Kozlowski
2023-05-16 10:06 ` Sunil Kovvuri Goutham
2023-05-16 10:25 ` Krzysztof Kozlowski
2023-05-16 11:24 ` Sunil Kovvuri Goutham
2023-05-16 11:42 ` Krzysztof Kozlowski
2023-05-16 11:54 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8119eec8-0190-b6a5-85a7-301bcb81b0c9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bbhushan2@marvell.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=sgoutham@marvell.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).