From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB39DC433F5 for ; Sun, 29 May 2022 14:26:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230420AbiE2O0N (ORCPT ); Sun, 29 May 2022 10:26:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230418AbiE2O0N (ORCPT ); Sun, 29 May 2022 10:26:13 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40F675E151 for ; Sun, 29 May 2022 07:26:11 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id rs12so16446189ejb.13 for ; Sun, 29 May 2022 07:26:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=3JaAWKa1bZRwQXdiutq3KI0xLzzTpwZUulcAkJ3MYjM=; b=KRMv70BYNXO5K4g2IQQvfaI/pcabvXgzAfht622ys8tKYzwvf3ofKMlRf6PdjuwS/9 X5abjnqdqyAcufM080Z4QbIOUIoWwMYVWdWsNwIRmj+tL5LFL+ntX9DgRCQrOs109ovN E35I9HBfy6NOdqQFKyX8T7zNFQMUqWGueuOQkQtZE3pEsyVxwFA2ahAmDZReu0fcIqms fiu0eK/aDeoFamLT1/pdTcYrp07T+7/9Vv3JtgDsVqMgoMlU9REYuKcL4lsteUnfbh61 cPqJcPG81LCrK7PoY1jke+x7BjpcoVgO7f9PxmNYBdMewrjn8eBEPidomKsHpNEVoEmn bU/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=3JaAWKa1bZRwQXdiutq3KI0xLzzTpwZUulcAkJ3MYjM=; b=fs2uY6y6TPbvfuoF8JuMWJqYRg0/DhcHNiDV74OhhLt65Ncy33z1qyaTrmhc66BrVx G0yZVNXvUkstKT4oj1lZpftOhOPPOgIE+kagtAk53E0ZjFGt+Mxs2zvkBkQD5UDwkLCU kcvEXFJj4cspwmXfaE/TXPYYg52naLw4rs7vLMYldQ3UyPg+P/T6E/6GxJMQcRHmVs9i 9c0z9ca2tL3XjBYZolEybjCYT0u8n8tkjJwlcFIVz16CjqPjtkEowlTrlHhWfCzzulPQ fIPJscHuSOH0zXhEPwYciL6k+Qce2uY5ULvoRNnQ+DxL3vHBuun908pThXn0yueTncVr 2qIQ== X-Gm-Message-State: AOAM531rF1wQ99P2JXONLOtyE+SdE+OuXk0CGOWQRxCFK6/rLsl7dDeV YyfhIBTu8cY0UP297F29FxTgiQ== X-Google-Smtp-Source: ABdhPJySVlVvENmtWvnwL1k/sepyDlzyv6YTdAOFbHANvVoWjCkbv8v/KqvZg0t+m68ewWBbun5GaQ== X-Received: by 2002:a17:907:7256:b0:6ff:2ed0:95d with SMTP id ds22-20020a170907725600b006ff2ed0095dmr12654168ejc.452.1653834369795; Sun, 29 May 2022 07:26:09 -0700 (PDT) Received: from [192.168.0.177] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id a92-20020a509ee5000000b0042dbc55f6e4sm2231061edf.7.2022.05.29.07.26.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 May 2022 07:26:09 -0700 (PDT) Message-ID: <8123f029-8d0b-be52-ba8d-8458f424ee32@linaro.org> Date: Sun, 29 May 2022 16:26:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro Content-Language: en-US To: Tom Fitzhenry , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , linux-rockchip@lists.infradead.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Samuel Holland , Ondrej Jirman , Martijn Braam , Ondrej Jirman References: <20220529031705.278631-1-tom@tom-fitzhenry.me.uk> <20220529031705.278631-3-tom@tom-fitzhenry.me.uk> From: Krzysztof Kozlowski In-Reply-To: <20220529031705.278631-3-tom@tom-fitzhenry.me.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/05/2022 05:17, Tom Fitzhenry wrote: > This is a basic DT that includes only features that are already > supported by mainline drivers. > > Tested to work: booting from eMMC, WiFi, charging. > > Future patches will flesh out the DT. Some components, e.g. the panel, > are awaiting driver mainlining. > > This is derived from a combination of https://gitlab.com/pine64-org/linux > and https://megous.com/git/linux. > > https://wiki.pine64.org/wiki/PinePhone_Pro > > Co-developed-by: Ondrej Jirman > Co-developed-by: Martijn Braam > Signed-off-by: Tom Fitzhenry > --- > arch/arm64/boot/dts/rockchip/Makefile | 1 + > .../dts/rockchip/rk3399-pinephone-pro.dts | 939 ++++++++++++++++++ > 2 files changed, 940 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > index 4ae9f35434b8..c00e7922d974 100644 > --- a/arch/arm64/boot/dts/rockchip/Makefile > +++ b/arch/arm64/boot/dts/rockchip/Makefile > @@ -41,6 +41,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-nanopi-neo4.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-nanopi-r4s.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-orangepi.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-pinebook-pro.dtb > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-pinephone-pro.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-puma-haikou.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-roc-pc.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-roc-pc-mezzanine.dtb > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > new file mode 100644 > index 000000000000..b1a486db1dfe > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > @@ -0,0 +1,939 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2020 Martijn Braam > + * Copyright (c) 2021 Kamil Trzciński > + */ > + > +// PinePhone Pro datasheet: https://files.pine64.org/doc/PinePhonePro/PinephonePro-Schematic-V1.0-20211127.pdf > + > +/dts-v1/; > +#include > +#include > +#include > +#include > +#include "rk3399.dtsi" > +#include "rk3399-opp.dtsi" > + > +/ { > + model = "Pine64 PinePhonePro"; > + compatible = "pine64,pinephone-pro", "rockchip,rk3399"; > + > + chosen { > + bootargs = "earlycon=uart8250,mmio32,0xff1a0000"; earlycon is debugging piece so it should not be in generic DTS. Best regards, Krzysztof