From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FE2DEB64DC for ; Tue, 18 Jul 2023 07:57:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231737AbjGRH5O (ORCPT ); Tue, 18 Jul 2023 03:57:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231796AbjGRH5J (ORCPT ); Tue, 18 Jul 2023 03:57:09 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDC981732 for ; Tue, 18 Jul 2023 00:56:59 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-98de21518fbso743483566b.0 for ; Tue, 18 Jul 2023 00:56:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689667018; x=1692259018; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j2mqKS21xBBL3zXrGxkLzWPef1bfANHcgljJaPtyzwU=; b=NKVNVbSckCvKGu0R0gppl9879OSOLjK0QBshjeArkJbgy01VI80E4ELIEbae215ANi mlgqB12E4Fo6xQNJRtM36yFXDtWXCOKWxa6H5eUVxm9udkLeWJiS7LQ1Nm04DbMZ0rg5 cYua6GM/+FQeZOjvuI7QLV7lj3Lutt+6PdiFNio2Vu5zcEABUD1PIxuyPB4EeNSujQbJ kevbs/nBsPBMNvd+Ggn9Si+9c0yna5jTsVAdkOyE76Vjny3tXJE7Jv2Wlb+7vg3JZCcv PDoyzNASsfa3aRZ8gXyq7l66lVxk+rAN0+Q4CK1V6xGjIJQd1I/x+lpEsf32dU+2cOqJ c62g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689667018; x=1692259018; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j2mqKS21xBBL3zXrGxkLzWPef1bfANHcgljJaPtyzwU=; b=E0LwH2nWaXFSQls9totbycXtqO/t/WRFBdKc3NnKWyVs9PUbtv4kQbwJBhuJIYergr 44MFrxvXxB3Jv+5J8zioU3xPiid00mxjPAQMN+adbWfSZiHhtZ+WyOr567M5G1P2BQUr 51s1Da/ZLnVI9jXCrXnYjFqZuPo3sht2ktvIbMpHDb7V643DNKqEDeUoatSwmRMED1rA //kKs1HJ7ZeE/bDMuSmL2bsDKfmjiCl82rW1iqazo0/MkcIjSNHcB1hCHjgoTwbO09TV ZaXDXSw5w/4AOrMuLbUNZtr+PXxbOeJBTS/9z+eiZbAYgCZAP/RsdNAV4ZZ4fzCgNSON 6shg== X-Gm-Message-State: ABy/qLbJs+9X67/TjnJtTmUQkfMtntRfKbLYQPO2oYZtm6EPaKS0P6Kv SfaiKP4FT59yO8bh1lqBlXTnZJM+7W8+/FJX0ueYwQ== X-Google-Smtp-Source: APBJJlHcVq7zSEK4BPdjL4HH9uIjX0xE3a8mSTjRnUA7ZqdPtwY+Rn4WkWqqCMKZQzwPF27zs9aTzA== X-Received: by 2002:a17:907:3d90:b0:997:d975:64eb with SMTP id he16-20020a1709073d9000b00997d97564ebmr1408272ejc.35.1689667017838; Tue, 18 Jul 2023 00:56:57 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id gx19-20020a170906f1d300b0099275c59bc9sm684299ejb.33.2023.07.18.00.56.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jul 2023 00:56:57 -0700 (PDT) Message-ID: <81285b87-866e-198c-b32c-f09a0d3e9d24@linaro.org> Date: Tue, 18 Jul 2023 09:56:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] usb: dwc2: add new compatible for Intel SoCFPGA Stratix10 platform Content-Language: en-US To: "Li, Meng" , "dinguyen@kernel.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "devicetree@vger.kernel.org" Cc: "linux-kernel@vger.kernel.org" References: <20230718030851.2014306-1-Meng.Li@windriver.com> <78b06bf0-ab71-acdf-5799-1f6d849e7ead@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/07/2023 09:43, Li, Meng wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Tuesday, July 18, 2023 2:11 PM >> To: Li, Meng ; dinguyen@kernel.org; >> robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; >> devicetree@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Subject: Re: [PATCH] usb: dwc2: add new compatible for Intel SoCFPGA Stratix10 >> platform >> >> CAUTION: This email comes from a non Wind River email account! >> Do not click links or open attachments unless you recognize the sender and >> know the content is safe. >> >> On 18/07/2023 05:08, Meng Li wrote: >>> Intel Stratix10 is very the same with Agilex platform, the DWC2 IP on >>> the Stratix platform also does not support clock-gating. The commit >>> 3d8d3504d233("usb: dwc2: Add platform specific data for Intel's >>> Agilex") had fixed this issue. So, add the essential compatible to >>> also use the specific data on Stratix10 platform. >>> >>> Signed-off-by: Meng Li >>> --- >>> arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi >>> b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi >>> index ea788a920eab..b8dd5509c214 100644 >>> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi >>> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi >>> @@ -490,7 +490,7 @@ usbphy0: usbphy@0 { >>> }; >>> >>> usb0: usb@ffb00000 { >>> - compatible = "snps,dwc2"; >>> + compatible = "intel,socfpga-agilex-hsotg", >>> + "snps,dwc2"; >> >> You miss SoC specific compatible. >> > > Sorry! I don't understand what do you mean about SoC specific compatible. > I think agilex is the soc specific. > Could you please show your example? But this is stratix. rk3128.dtsi Or many other devices in Linux kernel. Best regards, Krzysztof