devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bastian Germann <bage@debian.org>,
	Wilken Gottwalt <wilken.gottwalt@posteo.net>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	Samuel Holland <samuel@sholland.org>,
	linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: hwlock: sun6i: Add missing names
Date: Tue, 14 Feb 2023 13:38:17 +0100	[thread overview]
Message-ID: <8128a13d-e088-d358-b098-9f45ec73338a@linaro.org> (raw)
In-Reply-To: <20230213231931.6546-3-bage@debian.org>

On 14/02/2023 00:19, Bastian Germann wrote:
> The allwinner,sun6i-a31-hwspinlock.yaml binding needs clock-names
> and reset-names set to "ahb" as required by the driver.
> 
> Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")

NAK.

Original driver should have been changed, as requested during review.
Since the driver was not changed, we must not accept bindings post factum.

Best regards,
Krzysztof


  parent reply	other threads:[~2023-02-14 12:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13 23:19 [PATCH 0/3] Enable hwlock on Allwinner A64 Bastian Germann
2023-02-13 23:19 ` [PATCH 1/3] dt-bindings: hwlock: sun6i: Add missing #hwlock-cells Bastian Germann
2023-02-14  0:04   ` Andre Przywara
2023-02-14  8:08   ` Krzysztof Kozlowski
2023-02-14 16:12   ` Rob Herring
2023-02-15 14:07   ` Rob Herring
2023-02-16  8:39     ` Bastian Germann
2023-02-13 23:19 ` [PATCH 2/3] dt-bindings: hwlock: sun6i: Add missing names Bastian Germann
2023-02-14  0:07   ` Andre Przywara
2023-02-14  8:09   ` Krzysztof Kozlowski
2023-02-14  9:45   ` Wilken Gottwalt
2023-02-14 12:12     ` Andre Przywara
2023-02-14 12:39       ` Krzysztof Kozlowski
2023-02-14 12:37     ` Krzysztof Kozlowski
2023-02-14 18:11       ` Andre Przywara
2023-02-16  8:15         ` Krzysztof Kozlowski
2023-02-14 12:38   ` Krzysztof Kozlowski [this message]
2023-02-13 23:19 ` [PATCH 3/3] arm64: dts: allwinner: a64: Add hwspinlock node Bastian Germann
2023-02-14  0:12   ` Andre Przywara
2023-02-14  0:18 ` [PATCH 0/3] Enable hwlock on Allwinner A64 Andre Przywara
2023-02-14 21:55   ` Bastian Germann
2023-02-15  5:01     ` Wilken Gottwalt
2023-02-14 20:57 ` (subset) " Bjorn Andersson
2023-02-15 22:31   ` Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8128a13d-e088-d358-b098-9f45ec73338a@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=andersson@kernel.org \
    --cc=bage@debian.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=ohad@wizery.com \
    --cc=robh+dt@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    --cc=wilken.gottwalt@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).