devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frank Rowand <frowand.list@gmail.com>
To: Alexander Sverdlin <alexander.sverdlin@nokia.com>,
	devicetree@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] of: Export of_node_ktype
Date: Fri, 13 Jul 2018 09:05:42 -0700	[thread overview]
Message-ID: <8140ab69-3fa4-b448-0507-7b038f1d8b7b@gmail.com> (raw)
In-Reply-To: <20180713151450.2098-1-alexander.sverdlin@nokia.com>

Hi Alexander,

On 07/13/18 08:14, Alexander Sverdlin wrote:
> This is necessary for of_node_init() to work in modules.
> 
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> ---
>  drivers/of/kobj.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/of/kobj.c b/drivers/of/kobj.c
> index 7a0a18980b98..6348174ff615 100644
> --- a/drivers/of/kobj.c
> +++ b/drivers/of/kobj.c
> @@ -27,6 +27,7 @@ static void of_node_release(struct kobject *kobj)
>  struct kobj_type of_node_ktype = {
>  	.release = of_node_release,
>  };
> +EXPORT_SYMBOL_GPL(of_node_ktype);
>  
>  static ssize_t of_node_property_read(struct file *filp, struct kobject *kobj,
>  				struct bin_attribute *bin_attr, char *buf,
> 

I would not expect a generic module to need of_node_init().  So digging a
little bit deeper, what module needs of_node_init() and how is it using it?

Thanks,

Frank

  reply	other threads:[~2018-07-13 16:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13 15:14 [PATCH] of: Export of_node_ktype Alexander Sverdlin
2018-07-13 16:05 ` Frank Rowand [this message]
2018-07-13 16:11   ` Alexander Sverdlin
2018-07-13 20:32     ` Frank Rowand
  -- strict thread matches above, loose matches on Subject: below --
2017-01-18  9:37 Alexander Sverdlin
     [not found] ` <20170118093733.32152-1-alexander.sverdlin-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2017-01-18 20:30   ` Frank Rowand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8140ab69-3fa4-b448-0507-7b038f1d8b7b@gmail.com \
    --to=frowand.list@gmail.com \
    --cc=alexander.sverdlin@nokia.com \
    --cc=devicetree@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).