From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25C56C4338F for ; Wed, 28 Jul 2021 17:34:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3CFF6103E for ; Wed, 28 Jul 2021 17:34:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229537AbhG1Ret convert rfc822-to-8bit (ORCPT ); Wed, 28 Jul 2021 13:34:49 -0400 Received: from gloria.sntech.de ([185.11.138.130]:52028 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229515AbhG1Ret (ORCPT ); Wed, 28 Jul 2021 13:34:49 -0400 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m8nS6-000730-28; Wed, 28 Jul 2021 19:34:42 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Michael Riesch Cc: Rob Herring , Liang Chen , Peter Geis , Michael Riesch , Simon Xue Subject: Re: [PATCH 1/2] arm64: dts: rockchip: add gmac0 node to rk3568 Date: Wed, 28 Jul 2021 19:34:41 +0200 Message-ID: <814179037.0ifERbkFSE@diego> In-Reply-To: <2193550.atdPhlSkOF@diego> References: <20210728161020.3905-1-michael.riesch@wolfvision.net> <20210728161020.3905-2-michael.riesch@wolfvision.net> <2193550.atdPhlSkOF@diego> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Mittwoch, 28. Juli 2021, 18:43:24 CEST schrieb Heiko Stübner: > Hi, > > Am Mittwoch, 28. Juli 2021, 18:10:19 CEST schrieb Michael Riesch: > > While both RK3566 and RK3568 feature the gmac1 node, the gmac0 > > node is exclusive to the RK3568. > > > > Signed-off-by: Michael Riesch > > --- > > arch/arm64/boot/dts/rockchip/rk3568.dtsi | 51 ++++++++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts/rockchip/rk3568.dtsi > > index da01a59f6f26..ec39a2c593b6 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi > > @@ -22,6 +22,57 @@ > > compatible = "rockchip,rk3568-qos", "syscon"; > > reg = <0x0 0xfe190200 0x0 0x20>; > > }; > > + > > + gmac0: ethernet@fe2a0000 { > > + compatible = "rockchip,rk3568-gmac", "snps,dwmac-4.20a"; > > + reg = <0x0 0xfe2a0000 0x0 0x10000>; > > + interrupts = , > > + ; > > + interrupt-names = "macirq", "eth_wake_irq"; > > + rockchip,grf = <&grf>; Johan thankfully pointed out that the grf is hiding up here, so this should move below reset-names ;-) Heiko > > + clocks = <&cru SCLK_GMAC0>, <&cru SCLK_GMAC0_RX_TX>, > > + <&cru SCLK_GMAC0_RX_TX>, <&cru CLK_MAC0_REFOUT>, > > + <&cru ACLK_GMAC0>, <&cru PCLK_GMAC0>, > > + <&cru SCLK_GMAC0_RX_TX>, <&cru CLK_GMAC0_PTP_REF>, > > + <&cru PCLK_XPCS>; > > + clock-names = "stmmaceth", "mac_clk_rx", > > + "mac_clk_tx", "clk_mac_refout", > > + "aclk_mac", "pclk_mac", > > + "clk_mac_speed", "ptp_ref", > > + "pclk_xpcs"; > > + resets = <&cru SRST_A_GMAC0>; > > + reset-names = "stmmaceth"; > > + > > is this missing a rockchip,grf phandle? > > gmac1 has one and the driver side also does want to access the grf for both > controllers. > > > Heiko > > > + snps,mixed-burst; > > + snps,tso; > > + > > + snps,axi-config = <&gmac0_stmmac_axi_setup>; > > + snps,mtl-rx-config = <&gmac0_mtl_rx_setup>; > > + snps,mtl-tx-config = <&gmac0_mtl_tx_setup>; > > + status = "disabled"; > > + > > + mdio0: mdio { > > + compatible = "snps,dwmac-mdio"; > > + #address-cells = <0x1>; > > + #size-cells = <0x0>; > > + }; > > + > > + gmac0_stmmac_axi_setup: stmmac-axi-config { > > + snps,wr_osr_lmt = <4>; > > + snps,rd_osr_lmt = <8>; > > + snps,blen = <0 0 0 0 16 8 4>; > > + }; > > + > > + gmac0_mtl_rx_setup: rx-queues-config { > > + snps,rx-queues-to-use = <1>; > > + queue0 {}; > > + }; > > + > > + gmac0_mtl_tx_setup: tx-queues-config { > > + snps,tx-queues-to-use = <1>; > > + queue0 {}; > > + }; > > + }; > > }; > > > > &cpu0_opp_table { > > > >