devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Marcel Ziswiler <marcel@ziswiler.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-imx@nxp.com, Liu Ying <victor.liu@nxp.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Max Krummenacher <max.krummenacher@toradex.com>,
	Philippe Schenker <philippe.schenker@toradex.com>,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	Fabio Estevam <festevam@gmail.com>, Frank Li <Frank.Li@nxp.com>,
	Joakim Zhang <qiangqing.zhang@nxp.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Peng Fan <peng.fan@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v5 02/10] arm64: dts: imx8-ss-dma: add io-channel-cells to adc nodes
Date: Tue, 31 Jan 2023 16:00:37 +0100	[thread overview]
Message-ID: <8183250.T7Z3S40VBb@steina-w> (raw)
In-Reply-To: <20230126110833.264439-3-marcel@ziswiler.com>

Hi Marcel,

Am Donnerstag, 26. Januar 2023, 12:08:25 CET schrieb Marcel Ziswiler:
> From: Max Krummenacher <max.krummenacher@toradex.com>
> 
> This commit adds io-channel-cells property to the ADC nodes. This
> property is required in order for an IIO consumer driver to work.
> Especially required for Apalis iMX8 QM, as the touchscreen driver
> uses ADC channels with the ADC driver based on IIO framework.
> 
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

Yep, that's even required per bindings.
Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com>

> ---
> 
> (no changes since v3)
> 
> Changes in v3:
> - Fix subject as pointed out by Shawn. Thanks!
> 
>  arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi index
> a943a1e2797f..6e5ef8b69bf8 100644
> --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> @@ -270,6 +270,7 @@ i2c3: i2c@5a830000 {
> 
>  	adc0: adc@5a880000 {
>  		compatible = "nxp,imx8qxp-adc";
> +		#io-channel-cells = <1>;
>  		reg = <0x5a880000 0x10000>;
>  		interrupts = <GIC_SPI 240 IRQ_TYPE_LEVEL_HIGH>;
>  		interrupt-parent = <&gic>;
> @@ -284,6 +285,7 @@ adc0: adc@5a880000 {
> 
>  	adc1: adc@5a890000 {
>  		compatible = "nxp,imx8qxp-adc";
> +		#io-channel-cells = <1>;
>  		reg = <0x5a890000 0x10000>;
>  		interrupts = <GIC_SPI 241 IRQ_TYPE_LEVEL_HIGH>;
>  		interrupt-parent = <&gic>;





  reply	other threads:[~2023-01-31 15:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-26 11:08 [PATCH v5 00/10] arm64: dts: freescale: prepare and add apalis imx8 support Marcel Ziswiler
2023-01-26 11:08 ` [PATCH v5 01/10] arm64: dts: freescale: imx8-ss-lsio: add support for lsio_pwm0-3 Marcel Ziswiler
2023-01-26 11:08 ` [PATCH v5 02/10] arm64: dts: imx8-ss-dma: add io-channel-cells to adc nodes Marcel Ziswiler
2023-01-31 15:00   ` Alexander Stein [this message]
2023-01-26 11:08 ` [PATCH v5 03/10] arm64: dts: freescale: imx8-ss-dma: set lpspi0 max frequency to 60mhz Marcel Ziswiler
2023-01-26 11:08 ` [PATCH v5 04/10] firmware: imx: scu-pd: add missed lvds lpi2c and pwm power domains Marcel Ziswiler
2023-01-26 11:08 ` [PATCH v5 05/10] arm64: dts: imx8qxp: add flexcan in adma Marcel Ziswiler
2023-01-31 14:55   ` Alexander Stein
2023-01-26 11:08 ` [PATCH v5 06/10] arm64: dts: imx8qm: add can node in devicetree Marcel Ziswiler
2023-01-26 11:08 ` [PATCH v5 07/10] arm64: dts: imx8qm: add vpu decoder and encoder Marcel Ziswiler
2023-01-26 11:08 ` [PATCH v5 08/10] dt-bindings: arm: fsl: add toradex,apalis-imx8 et al Marcel Ziswiler
2023-01-26 11:08 ` [PATCH v5 09/10] arm64: dts: freescale: add initial apalis imx8 aka quadmax module support Marcel Ziswiler
2023-01-29  3:19   ` Shawn Guo
2023-02-01  3:01     ` Marcel Ziswiler
2023-02-03 13:14       ` Marcel Ziswiler
2023-01-26 11:08 ` [PATCH v5 10/10] arm64: dts: freescale: add apalis imx8 aka quadmax carrier board support Marcel Ziswiler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8183250.T7Z3S40VBb@steina-w \
    --to=alexander.stein@ew.tq-group.com \
    --cc=Frank.Li@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel.ziswiler@toradex.com \
    --cc=marcel@ziswiler.com \
    --cc=max.krummenacher@toradex.com \
    --cc=peng.fan@nxp.com \
    --cc=philippe.schenker@toradex.com \
    --cc=qiangqing.zhang@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=victor.liu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).