From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E41EDC4332F for ; Mon, 7 Nov 2022 11:46:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230434AbiKGLqb (ORCPT ); Mon, 7 Nov 2022 06:46:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231365AbiKGLqa (ORCPT ); Mon, 7 Nov 2022 06:46:30 -0500 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A706E167F2 for ; Mon, 7 Nov 2022 03:46:26 -0800 (PST) Received: by mail-lj1-x234.google.com with SMTP id b9so15824052ljr.5 for ; Mon, 07 Nov 2022 03:46:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=+JKZi6enSst2kWBJr01vLjOt2FvneWEg8LFzz5LHGB0=; b=jRVQIfmhXkPyQnD1t0mtaV1FdLeZIGj3gSbWh1rV/Z4ZOVlfY1/hK0O5VkF0xmCWOp Oi/hUjXVsGyFoWijFXycIFRbt8rXdq6HltPG7+Q3sfTeKCnglMKmU/1dv0XliC+qLYp8 KnbVu3PoifP80c87ciD4PHRNArjB9XIUQ4GcFBcQgyf8q23ONyTdnrK0AjdFf9R47Z2X hu+i+p1M+qlgmEluomPb91cwXF/CwqUx2bkHAkgs4/nKLFRT07XnQSsDc9DnlpKA7bF2 aQnHXZPKtkCh0nf51yYKDew4qY8SNHunHgCiK5BA6dPQSCPkZCn66qqo073FJNZxpcEo UqPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+JKZi6enSst2kWBJr01vLjOt2FvneWEg8LFzz5LHGB0=; b=I+MSqyR8YyERl98kceOTbi+398TSqxmnauRNE+Id/TrfE3kmun0mxsfMCDi2RlTp3r 56uq+OjHAL7B7zpuOZDjIssMsXxEQdNZRI2Ofzac8BimsPeb/XILFDYrT2eJlKJsHQ8f ILZvsk7xF9/DiQUj2BCznf29mKxCp+ReLhgwg8507HLPm9Utaa/oZdKSkQwM/xdMcaT9 5RmfSztmsfHCZGzXgbiPAnBlvy2du2vi0pT9YkR/KaGO7PpkCNulZ2WdAypGJwTivmxe yZwvyQxVYW0jCMHiUIKIa3Y8Ktys64rWLaw8ojUhPsQrBPDKS2PXWrMc9r9t+F8jTuHa c54Q== X-Gm-Message-State: ACrzQf2NxHk1MS7C5r9uKCNW9eYpCvoMct5rKrsERTgpmly5TuYFrLXA 5vHq/VOKmkGdleDo+fmIP+7PSw== X-Google-Smtp-Source: AMsMyM5mKL7r8syre1BT4ctSIJFcHz6VTdD+N62rT1HzWdp50D84I5g9TtrE6H6vZRgIfavxv+ReSw== X-Received: by 2002:a2e:a367:0:b0:277:7daa:cec6 with SMTP id i7-20020a2ea367000000b002777daacec6mr7265039ljn.265.1667821585056; Mon, 07 Nov 2022 03:46:25 -0800 (PST) Received: from [192.168.31.208] ([194.29.137.22]) by smtp.gmail.com with ESMTPSA id c10-20020a056512324a00b004afc1607130sm1204444lfr.8.2022.11.07.03.46.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Nov 2022 03:46:24 -0800 (PST) Message-ID: <819dc2f9-c1f2-201d-d611-f8b2a323473d@linaro.org> Date: Mon, 7 Nov 2022 12:46:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v1 3/5] arm64: dts: qcom: sm8450-hdk: enable display hardware To: Krzysztof Kozlowski , Bjorn Andersson , Dmitry Baryshkov Cc: Andy Gross , Rob Clark , Sean Paul , Abhinav Kumar , Rob Herring , Krzysztof Kozlowski , Stephen Boyd , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Vinod Koul References: <20221104131358.1025987-1-dmitry.baryshkov@linaro.org> <20221104131358.1025987-4-dmitry.baryshkov@linaro.org> <20221106043011.pw5fqeame7otzdcn@builder.lan> <163d117e-e519-e86d-b052-e4a2a53388d7@linaro.org> From: Konrad Dybcio In-Reply-To: <163d117e-e519-e86d-b052-e4a2a53388d7@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/11/2022 12:36, Krzysztof Kozlowski wrote: > On 07/11/2022 11:46, Konrad Dybcio wrote: >> >> On 06/11/2022 05:30, Bjorn Andersson wrote: >>> On Fri, Nov 04, 2022 at 04:13:56PM +0300, Dmitry Baryshkov wrote: >>>> Enable MDSS/DPU/DSI0 on SM8450-HDK device. Note, there is no panel >>>> configuration (yet). >>>> >>>> Signed-off-by: Dmitry Baryshkov >>>> --- >>>> arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 18 ++++++++++++++++++ >>>> 1 file changed, 18 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts >>>> index 38ccd44620d0..e1a4cf1ee51d 100644 >>>> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts >>>> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts >>>> @@ -442,3 +442,21 @@ &usb_1_qmpphy { >>>> vdda-phy-supply = <&vreg_l6b_1p2>; >>>> vdda-pll-supply = <&vreg_l1b_0p91>; >>>> }; >>>> + >>>> +&mdss { >>>> + status = "okay"; >>>> +}; >>>> + >>>> +&mdss_mdp { >>>> + status = "okay"; >>>> +}; >>>> + >>>> +&dsi0 { >>> Please prefix the labels with "mdss_" so that you can keep them sorted >>> alphabetically. >> Why such a change all of a sudden? Only downstream (and sc7280 upstream) >> has mdss_ prefixes for dsi. > For keeping the nodes together - this makes review of code and patches > easier. Ok, I can see the reasoning. >> Plain 'dsiN' is more generic. > And why the label should be generic? Label should be useful and > descriptive, although not too much, so mdss_dsi still fits in reasonable > choice. I was under the impression that it should be. But you're right. Konrad > > Best regards, > Krzysztof >