From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B992A27F732 for ; Fri, 13 Jun 2025 14:06:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749823588; cv=none; b=KycTw/CHmfkyVPnkSK/ylVobrzNIx6yhS8z8/PnXlhIW+9XKcnmxphTZOdacGLueIgJFSH6OCheiHB/fOC0t0AiWkky9cJ/bm1uGHkLi3MPM3w3z13QjEJhcDVXP7lMA4LnZuAfzav4subVFaUTKhiBGbPgQ9l8M26MpGizUI+s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749823588; c=relaxed/simple; bh=KbUlGtpfhdEZom8VAmFrDXTGJwRDxsPYiWV9ksPDsMM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qAD6+2Vu4p5RLQygJbFAOGxr2lYAKryitaxkmOG/FdQLLUlfnY0DtrjlFXXuUakkMIoQp5XOaA7wTBOeufN/WR0/GmZBYmrgMsNXkjlJqmXvUL+NEFjnkOexYhjBsGEDAyuxp2zcoXfXqSSlh+lZgAc02Og75PFEVTVq+gKoXoc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hpmlYs1G; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hpmlYs1G" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3a50956e5d3so1778307f8f.1 for ; Fri, 13 Jun 2025 07:06:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749823585; x=1750428385; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xUn/T2v9DcG34w0Q+hYirGCU74t68lTP6XWgRwe314k=; b=hpmlYs1GiAoWTOQCu6ldv6fqocvJYrBFraiTudtOB2hwSV3+QAp93Z+yA7GJZ5KS0n DS+SAXzGhYfiXggSDIG1cfzLawqoidMXt46FJcvIkxYIhXNk3W8S9TeA+1sZ9aOSvCKq SiH6547GXK3nhQmt+VPJnMFu3Q/+vtitGfibWhO80KtKSS27iu5FFqb49gzZsw5YEm2j YFxB15qepUYgJCR8/SW51jfcTRauUaPuRF2cF6muhvFnu9mmLndj1FN3FS9hpP1QN+g0 7DoIVyUnxTiQA8G7Px/jY2F3UYELv0ICg4sd1AMUN0H/O5JUpgQyclz+EzIDShTopOAI WzBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749823585; x=1750428385; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xUn/T2v9DcG34w0Q+hYirGCU74t68lTP6XWgRwe314k=; b=aQWkpQ6fI2UFLwWsuVuRfv9kyDg404w3E9pG1vPyDE5Q3jnjCfkIfazVZuNAnNVIIb QGnqbuHOYcPHp7F/XKiIaBjlJn30jV1h99ipVqyIyyxchBnBOssGeAbvtkskXgA/4f9v WZpdG9zfldqsaCtj/UY6RZjHGvndAv/Wnpvff9VB8KSp+xTGKSL3yTZo1mhQdnc7Jzzr 0o1OkciUlbmwfMg0eEp+TKKYbTUhMZHGrUK9FvC4LZN0SswguAE4dMgOUkQlu+Oouf0d QnPNNVjSR6oRmSTFIg696L/U+N3DtRa0AscCUWXZ50rQTX0zs2njMWXy4qsmDGgblbJZ eCyw== X-Forwarded-Encrypted: i=1; AJvYcCW3iKmrqX1f6rYPq6P71520W23+lV5DAdPRoI/iqnXo+cKFs2WZxLpPVh9Zf2kOfSsEwAc4tBqc+bdv@vger.kernel.org X-Gm-Message-State: AOJu0YzIbYE85cMb0IsiUdNVYJMpmYOapo/6wCiOmhJfB5j5+JEsWO+A zn2CkWSaDbMdN/KHm2spkR3AslAbjbYc06vBUFpXiHz/DrlOjf93UfBb9fb3XNgn5U8= X-Gm-Gg: ASbGncv2fR6E50dC4aYxnoQjhU5eifURJfMlV6IzP4pTXEhgvcZwyU78QgTPbooJBWI inHTzoKoU+zofANiRVXIZit1L4hUGCoRQnmnIBdT1tULDtcfo9zXjMaIxoup/eckZN4KOkK1wus UJ6CAR7mHlkRYhDRpwpE22rnT3WMkHa8wYWpv7oyc0axSwhnIq+Zz71d55HjTwu2XtoB7qS8HSI DuUidAPCM9DuQrniV/0FOLCQW5KQ6AvjojT9DxruN2EW+DRHqLv+R7TgSJxIkaS8Y6lo8cOeCjT V5MHyqm/RzxCbuMOtIdJs46ZtXYPg6+3tBeOSVmaEeYr5r4zxAjA4YpLGBVRsmLvKzOS5kqO0px VeyAfBCstcFu09D2sAyTjbuNQEmM= X-Google-Smtp-Source: AGHT+IH1fMP2KnFNWRoIIFgpfDxW7MxNb1uMSxg0eL6l8twtoQZjitcGVI8/ENMR8PDgAtAlfuMQQg== X-Received: by 2002:a05:6000:2505:b0:3a4:ef00:a7b9 with SMTP id ffacd0b85a97d-3a56868319emr2894882f8f.12.1749823584788; Fri, 13 Jun 2025 07:06:24 -0700 (PDT) Received: from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a73a7bsm2525723f8f.36.2025.06.13.07.06.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jun 2025 07:06:24 -0700 (PDT) Message-ID: <81a65ea6-2f46-4d11-9a3f-50664da78eea@linaro.org> Date: Fri, 13 Jun 2025 15:06:23 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] arch: arm64: dts: qcom: qcm2290: Add venus video node To: Jorge Ramirez-Ortiz , quic_vgarodia@quicinc.com, quic_dikshita@quicinc.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, stanimir.varbanov@linaro.org Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250613140402.3619465-1-jorge.ramirez@oss.qualcomm.com> <20250613140402.3619465-3-jorge.ramirez@oss.qualcomm.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20250613140402.3619465-3-jorge.ramirez@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/06/2025 15:03, Jorge Ramirez-Ortiz wrote: > Add DT entries for the qcm2290 venus encoder/decoder. > > Signed-off-by: Jorge Ramirez-Ortiz > --- > arch/arm64/boot/dts/qcom/qcm2290.dtsi | 53 +++++++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcm2290.dtsi b/arch/arm64/boot/dts/qcom/qcm2290.dtsi > index f49ac1c1f8a3..af2c1f66fe07 100644 > --- a/arch/arm64/boot/dts/qcom/qcm2290.dtsi > +++ b/arch/arm64/boot/dts/qcom/qcm2290.dtsi > @@ -1628,6 +1628,59 @@ adreno_smmu: iommu@59a0000 { > #iommu-cells = <2>; > }; > > + venus: video-codec@5a00000 { > + compatible = "qcom,qcm2290-venus"; > + reg = <0 0x5a00000 0 0xff000>; > + interrupts = ; > + > + power-domains = <&gcc GCC_VENUS_GDSC>, > + <&gcc GCC_VCODEC0_GDSC>, > + <&rpmpd QCM2290_VDDCX>; > + power-domain-names = "venus", "vcodec0", "cx"; > + operating-points-v2 = <&venus_opp_table>; > + > + clocks = <&gcc GCC_VIDEO_VENUS_CTL_CLK>, > + <&gcc GCC_VIDEO_AHB_CLK>, > + <&gcc GCC_VENUS_CTL_AXI_CLK>, > + <&gcc GCC_VIDEO_THROTTLE_CORE_CLK>, > + <&gcc GCC_VIDEO_VCODEC0_SYS_CLK>, > + <&gcc GCC_VCODEC0_AXI_CLK>; > + clock-names = "core", "iface", "bus", "throttle", > + "vcodec0_core", "vcodec0_bus"; > + > + memory-region = <&pil_video_mem>; > + iommus = <&apps_smmu 0x860 0x0>, > + <&apps_smmu 0x880 0x0>, > + <&apps_smmu 0x861 0x04>, > + <&apps_smmu 0x863 0x0>, > + <&apps_smmu 0x804 0xE0>; > + > + interconnects = <&mmnrt_virt MASTER_VIDEO_P0 0 &bimc SLAVE_EBI1 0>, > + <&bimc MASTER_APPSS_PROC 0 &config_noc SLAVE_VENUS_CFG 0>; > + interconnect-names = "video-mem", "cpu-cfg"; > + > + venus_opp_table: opp-table { > + compatible = "operating-points-v2"; > + opp-133000000 { > + opp-hz = /bits/ 64 <133000000>; > + required-opps = <&rpmpd_opp_low_svs>; > + }; > + > + opp-240000000 { > + opp-hz = /bits/ 64 <240000000>; > + required-opps = <&rpmpd_opp_svs>; > + }; > + }; > + > + video-decoder { > + compatible = "venus-decoder"; > + }; > + > + video-encoder { > + compatible = "venus-encoder"; > + }; These should be dropped in favour of static config in the driver. > + }; > + > mdss: display-subsystem@5e00000 { > compatible = "qcom,qcm2290-mdss"; > reg = <0x0 0x05e00000 0x0 0x1000>; --- bod