From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DBA21922FA for ; Thu, 15 May 2025 14:05:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747317904; cv=none; b=UkN5/ykQUwI4QFoDFuESlLthEXexXR5daJFZIzd0P7wDFjLbyRovjaOviaJRkSkdKcLHWzBn3cidY6SpaBGT9ZRiMXRFOHOARP6bF7v/4tqazMa0Auvecrv1cX0czsl33yKgdv0eo7px9jyMVKyNVAHUQOyNmhp43YqSKTxlHtw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747317904; c=relaxed/simple; bh=i8tlY/LbfI0ZDQSrDItL+NiokGBk6h8Vq0LsxV2KBrU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DYbELux5FOEjlMF/EIOIjG57uj+xyULfvKxS5IsbUAc4Q3+gm3i6sNo4BpeQoOWqxBioeQvwIYF+pHsJUIN1P9bF+FXDFhrD9gyiPuYZCNgJPTWejKX5LH7JNXweC+T7UkUIZbY3oR6XKLa2APkwEEA8S+09XgMWJvc/verOuL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Z7pwWEil; arc=none smtp.client-ip=209.85.210.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Z7pwWEil" Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-72c172f1de1so754285a34.3 for ; Thu, 15 May 2025 07:05:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1747317900; x=1747922700; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9K77ZU3+im9NvK6fucyyQ4XpbTRkWMjyw12HrfwTZqs=; b=Z7pwWEiltQ7ovS77kfVNfs+mxU8th+aD84I2nMsFmNNtyX7Apij1J3/lT+X0Lry8ng GkW3fq9HbaQAfJ4YnUL2puCafh88xDUAv0hEV1ALrx2Ql3mBXmGNwyFD6g9Ksajv+/4z iKF1bHFe8BZzz7J70RpoOtQ55+jLc25bQdZDdPjC4lKLY4sbp1Sh8svOleLndqY2kPrs /uKsJqwBNo0ZWkp9HVbC1q3OmFfDlVhSJmMK9831958aiQdc24q4kVzdGmI10xPysXrS 3gdwo+W8UJE+0e3Zlw0qXi1++zNiiRB1BL2Otq1UaYZfjSSOCsjZbCU9b8JsEB3KzYvl Of5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747317900; x=1747922700; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9K77ZU3+im9NvK6fucyyQ4XpbTRkWMjyw12HrfwTZqs=; b=P/i+kQ4RKQEh/kmx8eAVy0i4dwkYMfbhyBVLBKHkdiyPg3CZJmYkSh2himRbY1n0qD EN4pTs2VnjzAZSiUXDTUPHtAEWFfrfOpVDof9vi44z6sn4EziCNszmkARYkBsp7Uc9nh StgQFa3bnfqJUQpdcfAz+Tv8yTJAoPU+kxcIRxiLEi04omNUPn00Bck0LerR6YhnB01p Mc/LhuoMfbIhA8UI/w+MEQa7bf8ycdWMqRXYKhFgg8agYH40zGB4nIz8CNYB5qBMmfzd lRslKB7G9Jd8skvhFnkJxX7H0vm9QjzyMQkD3qc/DcEcJJmkSLvljz6oN2mSoGJJJ2wL ZgRw== X-Forwarded-Encrypted: i=1; AJvYcCXWT6Fkg/qJHl4o8doAuQUamWpsfOOKEdGxFmr41SbdG0cGblCKQIqEDQhjAvshT9WmKgfoF8SER4lf@vger.kernel.org X-Gm-Message-State: AOJu0YzrGwz8pZQxQ8QCEfiha5cWMtYiMTS9uIAvjFUEnKW32AIMk2Wp s9948moX5KAlgPYSaqyiNdqRPIIX0IrukSxrs8JHMKTT3kKpK+K+pAo1XjeenLE= X-Gm-Gg: ASbGncuM4xlDly2i5eSkbby3iXzbVo4iSMT7vslljXTUOKBOCl2zKlSB55QMwJegdn5 anSw762pUYbRYd+9jthneJPI3lu2BmrkOedjRIFZh1hBUdXBbPAP/PWRwXYlrLe8Ini1jC9KJA+ /+mIMIqgUY/+jltbiPv/iDrZxK8T5X9B52sFJpN+XJH6/U+kbsoAfg0GQfP5ddWzaVZuGCIVxkC vcE3em1RDuYUEoD5osF30ZSwjGI/QWvKWBlKpPdfza8TMqpd4NZJg5wLm4RTXSROJKbAgzXbx6L qnfJQxf85r0MfAdyok9KRli3T5TN4II58ltMSmmycpvwhANJ6vdAeRtJCriR3l4O1Pe42PkkJAT h3Xgg67qJLA+H/fLFQMd55t734AW5 X-Google-Smtp-Source: AGHT+IE5zLtoEtrW+oFDBQ1zy1uWy5TOgC1cPAyin7uJmHiCiE/9u6LzX2kphTwBuNw2dfLO3Zn//g== X-Received: by 2002:a05:6830:4109:b0:731:cac7:3634 with SMTP id 46e09a7af769-734e13d0966mr4171455a34.3.1747317899864; Thu, 15 May 2025 07:04:59 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:bb18:367a:73d3:5230? ([2600:8803:e7e4:1d00:bb18:367a:73d3:5230]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-732264d78fbsm2733023a34.32.2025.05.15.07.04.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 May 2025 07:04:59 -0700 (PDT) Message-ID: <81b2a499-1927-4fb3-b581-a533c64507a6@baylibre.com> Date: Thu, 15 May 2025 09:04:57 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dt-bindings:iio:gyroscope:invensense,itg3200: add binding To: Rodrigo Gobbi , robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, nuno.sa@analog.com, andy@kernel.org Cc: ~lkcamp/patches@lists.sr.ht, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250515002817.81863-1-rodrigo.gobbi.7@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20250515002817.81863-1-rodrigo.gobbi.7@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/14/25 7:21 PM, Rodrigo Gobbi wrote: > There is no txt file for it, add yaml for invensense,itg3200 gyroscope. > > Signed-off-by: Rodrigo Gobbi > --- > Added @Jonathan as the maintainer here due a suggestion in a > different thread for a different binding file. > Created this yaml using the driver probe and comparing with other gyro bindings. > Tks and regards. > --- > .../iio/gyroscope/invensense,itg3200.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml > > diff --git a/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml b/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml > new file mode 100644 > index 000000000000..0656dbb58cf2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/gyroscope/invensense,itg3200.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/gyroscope/invensense,itg3200.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Invensense ITG-3200 Gyroscope > + > +maintainers: > + - Jonathan Cameron > + > +description: | > + Triple-axis, digital output gyroscope with a three 16-bit analog-to-digital > + converters (ADCs) for digitizing the gyro outputs, a user-selectable internal > + low-pass filter bandwidth, and a Fast-Mode I2C . Datasheet can be found here: > + https://invensense.tdk.com/wp-content/uploads/2015/02/ITG-3200-Register-Map.pdf This is only the register map, not a proper datasheet, so isn't useful for the devicetree bindings. > + > +properties: > + compatible: > + const: invensense,itg3200 > + > + reg: > + maxItems: 1 > + Missing vdd-supply and vlogic-supply properties. These should be required. Missing clocks property for optional external clock. We always try to make the DT bindings as complete as possible even if the driver doesn't use all of it. > + interrupts: > + minItems: 1 > + > + mount-matrix: > + description: an optional 3x3 mounting rotation matrix. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + itg3200@68 { gyro@68 Generic names are preferred. > + compatible = "invensense,itg3200"; > + reg = <0x68>; > + pinctrl-names = "default"; > + pinctrl-0 = <&itg3200_pins>; Probably don't need pinctrl stuff in the example. > + interrupt-parent = <&gpio2>; > + interrupts = <24 IRQ_TYPE_EDGE_FALLING>; > + }; > + };