From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DFB5C3A5A7 for ; Thu, 8 Dec 2022 09:53:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229521AbiLHJxM (ORCPT ); Thu, 8 Dec 2022 04:53:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230032AbiLHJxI (ORCPT ); Thu, 8 Dec 2022 04:53:08 -0500 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 534BF1F2E4 for ; Thu, 8 Dec 2022 01:53:07 -0800 (PST) Received: by mail-lj1-x22a.google.com with SMTP id x11so988777ljh.7 for ; Thu, 08 Dec 2022 01:53:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7u4aL/xpIdblYmbF/S8Sj8AuIu5jDM1rBtZZo4FjHsA=; b=oOYdGFZqrtgKOqOZAsi9qW9yDTBmTRR8FTdkdx8S0yyEY/xi/3ynl4iRHy+QBuLypz 80SQgj6/Nmk0H5MzyD4B+RTrNPGbqnRGh+cLAV4xkFoSDEBT+62w1tWdtAe4nT5FZ3Wi 6aVzbYOJuKeZ0PnGNCGfhdcx+TG05kc65H+8TykLS0fgQYpX3zb2kfKcWnrX75qVMaFV LemVmqHgOhi98IJxp9y54IvFICyyuXKCZuxcBsx2H6gX6OgXDy8QFgJKPD1RTHXN/xDc QW3uOaheniZ+GkhDsN2/gvy3mR3WdMvKL5bZ7yxWnLr4NxWusMhpbhG4jeEzPG4MKXfT TQcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7u4aL/xpIdblYmbF/S8Sj8AuIu5jDM1rBtZZo4FjHsA=; b=HA8Qcs/4OOFAGyxAWYakTLXrXUjaajPDIBkDuaDurdFjEWl1BHgxNhB0krgjVcx0nN mUiLJCT+jdDRagzLR1IhlM5ORgyKh/y41WQd4WDqr9h4qDgRdS/MDY+MVua3z1ZeLu9A I+kxXsQDaUte9KKkoCZmKooR5AOfVKVH+t3oExOLnX6FcV81Y8MURsUcIq36MGAIa070 bqFmpf2eK5HlrdLouoWje987Qt3U3fMoxi7dLLLJxhciJKWbwgWTnlE8dQ0PilNW2f2n PR+wNvyh3sgpVYJBcOTe9Wno6lGuktPtHBsDJIJRrMUkYuvP0BUaPYGD71RfB9ggcOcZ p8uA== X-Gm-Message-State: ANoB5pmUD9VubItU4ecK4HccNV7us8XZYXHrvQuktoj7kUVJVOo2yocn 1nzaw+ogXYTH2FCDny7hZvTNMQ== X-Google-Smtp-Source: AA0mqf6NoOewg6gCSiROs5fwIGVTz6CRoTlYFRVgOMC46zrTxDXYoqYzYZzDfPqQUAYnVQjBKiajIg== X-Received: by 2002:a2e:a54d:0:b0:278:f31b:2770 with SMTP id e13-20020a2ea54d000000b00278f31b2770mr25305817ljn.310.1670493185690; Thu, 08 Dec 2022 01:53:05 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id u13-20020a05651220cd00b004b58500383bsm1078232lfr.272.2022.12.08.01.53.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Dec 2022 01:53:05 -0800 (PST) Message-ID: <81b3ee7d-826c-b270-99d4-292e51e3cfdc@linaro.org> Date: Thu, 8 Dec 2022 10:53:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v2 1/1] dt-bindings: lcdif: Fix constraints for imx8mp Content-Language: en-US To: Alexander Stein , Marek Vasut , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org References: <20221208094519.3561610-1-alexander.stein@ew.tq-group.com> From: Krzysztof Kozlowski In-Reply-To: <20221208094519.3561610-1-alexander.stein@ew.tq-group.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/12/2022 10:45, Alexander Stein wrote: > i.MX8MP uses 3 clocks, so soften the restrictions for clocks & clock-names. > This SoC requires a power-domain for this peripheral to use. Add it as > a required property. > > Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP") > Signed-off-by: Alexander Stein > --- > Changes in v2: > * Squash both patches into one > * Split the conditionals from fsl,imx6sx-lcdif > * Mark power-domains as required for fsl,imx8mp-lcdif > * Ignored the A-b & R-b due to reorganization > > I'm not sure if this is the best way to add the constraints. I noticed that > imx6sx also uses a power-domain, but imx6ul which is compatible to imx6sx does > not, so they can't be merged. > > I also have noticed that dtbs_check doesn't raise a warning when > power-domains is actually missing. > > .../bindings/display/fsl,lcdif.yaml | 31 ++++++++++++++++++- > 1 file changed, 30 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > index 876015a44a1e6..24014651f7dc8 100644 > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > @@ -52,6 +52,9 @@ properties: > interrupts: > maxItems: 1 > > + power-domains: > + maxItems: 1 > + > port: > $ref: /schemas/graph.yaml#/properties/port > description: The LCDIF output port > @@ -81,7 +84,33 @@ allOf: > maxItems: 3 > required: > - clock-names > - else: > + - if: > + properties: > + compatible: > + contains: > + const: fsl,imx8mp-lcdif > + then: > + properties: > + clocks: > + minItems: 3 > + maxItems: 3 > + clock-names: > + minItems: 3 > + maxItems: 3 > + power-domains: > + minItems: 1 Drop power domains here. > + required: > + - clock-names > + - power-domains > + - if: > + not: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx6sx-lcdif > + - fsl,imx8mp-lcdif > + then: > properties: > clocks: > maxItems: 1 Best regards, Krzysztof