From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61A711991CB; Thu, 17 Apr 2025 13:34:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744896883; cv=none; b=PKgZbxxDP+5Z+Q1k2r17zPJ5gDMsExlXE3hHdJEs1t17HqeDYVQqX+Aw6Le8KXapaWw3CvzPAefuSU9b/qArioj5kXcU0IgNNg7HYKU2uQcUs+prb3cyqIL7hhrRAS+tg6BiONbrVUpB+JLubImvumyCkhJsYj+fitfRS37K6EU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744896883; c=relaxed/simple; bh=SB34PBY0RNUAZRZBFCty6nn1wf0hugGM1UTlDrumSZw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EXrSzjkfBFPizRXnz9nbQUKyDA9uh1uFkKM2CylC4vYobjixwU9QroslyAMuuuNDgqPAn8AsnUCHd/zoW6Z4AyPzG84/ztEbHL2PT6Pgu1t8ipMQvVQzvwAJXQ6aYY7uIeFtNuuFFdY2P9VSTdEHZu/SjCu2vA0/rOxxpBSqQFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tGSA3AaJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tGSA3AaJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3BC7AC4CEE4; Thu, 17 Apr 2025 13:34:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744896882; bh=SB34PBY0RNUAZRZBFCty6nn1wf0hugGM1UTlDrumSZw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=tGSA3AaJ3Au/8D16cER7nJP8rmOy2xPt8yhqiBtcGf29IqtyDhP7bTtVuQctPm8up FuPLhZKvP+etB6rz8o5fjVaxxOURWKXTd1iKeK59cvhbkrqmaZn3Egv7h2JMiAi4q1 MJnwTHML5RWLCZZ1r0LW8DGmLJZKmr0tRK5Q1ZHfViAbCQIXFTqaIu3I8h5RtcUJnD tFg+yyC4OyuPhQzgTGV5fH2AXi01n6F0P0oBGedrW+rPlGrS0abEXrPjjSGs4eIXeM ygs7YqVw9Yh00+11ME717PMi1GAuFAfbRy6Jd2JYuXD7cakrcxKH1ALj7vsWvrcfRk 7eWGaw1B6XyrA== Message-ID: <81fb1290-fb39-40b7-9d79-f147fae5b269@kernel.org> Date: Thu, 17 Apr 2025 14:34:37 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] nvmem: Add spmi-nvmem driver To: fnkl.kernel@gmail.com, Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Hector Martin References: <20250415-spmi-nvmem-v1-0-22067be253cf@gmail.com> <20250415-spmi-nvmem-v1-2-22067be253cf@gmail.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20250415-spmi-nvmem-v1-2-22067be253cf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15/04/2025 22:52, Sasha Finkelstein via B4 Relay wrote: > From: Hector Martin > > This driver exposes a SPMI device as an NVMEM device. > It is intended to be used with e.g. PMUs/PMICs that are used to > hold power management configuration, such as used on Apple Silicon > Macs. > > Signed-off-by: Hector Martin > Signed-off-by: Sasha Finkelstein > --- > MAINTAINERS | 1 + > drivers/nvmem/Kconfig | 14 +++++++++++ > drivers/nvmem/Makefile | 2 ++ > drivers/nvmem/spmi-nvmem.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 79 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index e7b2d0df81b387ba5398957131971588dc7b89dc..63c12f901aed1f3e6de8227d6db34af1bd046fe6 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2298,6 +2298,7 @@ F: drivers/iommu/io-pgtable-dart.c > F: drivers/irqchip/irq-apple-aic.c > F: drivers/nvme/host/apple.c > F: drivers/nvmem/apple-efuses.c > +F: drivers/nvmem/spmi-nvmem.c > F: drivers/pinctrl/pinctrl-apple-gpio.c > F: drivers/pwm/pwm-apple.c > F: drivers/soc/apple/* > diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig > index 8671b7c974b933e147154bb40b5d41b5730518d2..9ec907d8aa6ef7df0ea45cc35e92d8239d2705ee 100644 > --- a/drivers/nvmem/Kconfig > +++ b/drivers/nvmem/Kconfig > @@ -310,6 +310,20 @@ config NVMEM_SNVS_LPGPR > This driver can also be built as a module. If so, the module > will be called nvmem-snvs-lpgpr. > > +config NVMEM_SPMI > + tristate "Generic SPMI NVMEM" > + default ARCH_APPLE Why default is set to ARCH_APPLE? This will endup with y in arm64 defconfig, means increasing the size of kernel. should it be: depends on ARCH_APPLE || COMPILE_TEST --srini > + depends on SPMI > + select REGMAP_SPMI > + help > + Say y here to build a generic driver to expose a SPMI device > + as a NVMEM provider. This can be used for PMIC/PMU devices which > + are used to store power and RTC-related settings on certain > + platforms, such as Apple Silicon Macs. > + > + This driver can also be built as a module. If so, the module > + will be called nvmem-spmi. > + > config NVMEM_SPMI_SDAM > tristate "SPMI SDAM Support" > depends on SPMI > diff --git a/drivers/nvmem/Makefile b/drivers/nvmem/Makefile > index 5b77bbb6488bf89bfb305750a1cbf4a6731a0a58..b639f4284184db026bb27b11e04d54b8f7ff166f 100644 > --- a/drivers/nvmem/Makefile > +++ b/drivers/nvmem/Makefile > @@ -64,6 +64,8 @@ obj-$(CONFIG_NVMEM_SC27XX_EFUSE) += nvmem-sc27xx-efuse.o > nvmem-sc27xx-efuse-y := sc27xx-efuse.o > obj-$(CONFIG_NVMEM_SNVS_LPGPR) += nvmem_snvs_lpgpr.o > nvmem_snvs_lpgpr-y := snvs_lpgpr.o > +obj-$(CONFIG_NVMEM_SPMI) += nvmem_spmi.o > +nvmem_spmi-y := spmi-nvmem.o > obj-$(CONFIG_NVMEM_SPMI_SDAM) += nvmem_qcom-spmi-sdam.o > nvmem_qcom-spmi-sdam-y += qcom-spmi-sdam.o > obj-$(CONFIG_NVMEM_SPRD_EFUSE) += nvmem_sprd_efuse.o > diff --git a/drivers/nvmem/spmi-nvmem.c b/drivers/nvmem/spmi-nvmem.c > new file mode 100644 > index 0000000000000000000000000000000000000000..fff6162cb22dd7ab45883f004f5b63ebae014698 > --- /dev/null > +++ b/drivers/nvmem/spmi-nvmem.c > @@ -0,0 +1,62 @@ > +// SPDX-License-Identifier: GPL-2.0-only OR MIT > +/* > + * Generic SPMI NVMEM driver > + * > + * Copyright The Asahi Linux Contributors > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +static const struct regmap_config spmi_regmap_config = { > + .reg_bits = 16, > + .val_bits = 8, > + .max_register = 0xffff, > +}; > + > +static int spmi_nvmem_probe(struct spmi_device *sdev) > +{ > + struct regmap *regmap; > + struct nvmem_config nvmem_cfg = { > + .dev = &sdev->dev, > + .name = "spmi_nvmem", > + .id = NVMEM_DEVID_AUTO, > + .word_size = 1, > + .stride = 1, > + .size = 0xffff, > + .reg_read = (void *)regmap_bulk_read, > + .reg_write = (void *)regmap_bulk_write, > + }; > + > + regmap = devm_regmap_init_spmi_ext(sdev, &spmi_regmap_config); > + if (IS_ERR(regmap)) > + return PTR_ERR(regmap); > + > + nvmem_cfg.priv = regmap; > + > + return PTR_ERR_OR_ZERO(devm_nvmem_register(&sdev->dev, &nvmem_cfg)); > +} > + > +static const struct of_device_id spmi_nvmem_id_table[] = { > + { .compatible = "spmi-nvmem" }, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, spmi_nvmem_id_table); > + > +static struct spmi_driver spmi_nvmem_driver = { > + .probe = spmi_nvmem_probe, > + .driver = { > + .name = "spmi-nvmem", > + .of_match_table = spmi_nvmem_id_table, > + }, > +}; > + > +module_spmi_driver(spmi_nvmem_driver); > + > +MODULE_LICENSE("Dual MIT/GPL"); > +MODULE_AUTHOR("Hector Martin "); > +MODULE_DESCRIPTION("SPMI NVMEM driver"); >